Skip to content

tsan warning for SetIsTracing #1965

@agrieve

Description

@agrieve

This came up in chromium when enabling split dwarf (no idea why that would affect tsan, but it repro's 100%).

The warning is fixed by adding ABSL_ATTRIBUTE_NO_SANITIZE_THREAD to ExecutionCoverage::SetIsTracing, but I'm not sure if that's correct, or if it should be used to use an atomic bool.

This is the commit that triggers the failure, and here is a direct link showing the tsan error.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions