Merge pull request #60 from github/kh-migrate-more-rules

Migrate all rules from using `Counter` in name

Author: khiga8

README.md

@@ -23,56 +23,56 @@ require "erblint-github/linters"
 ```yaml 
 ---
 linters:
-  GitHub::Accessibility::AvoidBothDisabledAndAriaDisabledCounter:
+  GitHub::Accessibility::AvoidBothDisabledAndAriaDisabled:
     enabled: true
-  GitHub::Accessibility::AvoidGenericLinkTextCounter:
+  GitHub::Accessibility::AvoidGenericLinkText:
     enabled: true
-  GitHub::Accessibility::DisabledAttributeCounter:
+  GitHub::Accessibility::DisabledAttribute:
     enabled: true
-  GitHub::Accessibility::IframeHasTitleCounter:
+  GitHub::Accessibility::IframeHasTitle:
     enabled: true
-  GitHub::Accessibility::ImageHasAltCounter:
+  GitHub::Accessibility::ImageHasAlt:
     enabled: true
-  GitHub::Accessibility::LandmarkHasLabelCounter:
+  GitHub::Accessibility::LandmarkHasLabel:
     enabled: true
-  GitHub::Accessibility::LinkHasHrefCounter:
+  GitHub::Accessibility::LinkHasHref:
     enabled: true
-  GitHub::Accessibility::NestedInteractiveElementsCounter:
+  GitHub::Accessibility::NestedInteractiveElements:
     enabled: true
-  GitHub::Accessibility::NoAriaHiddenOnFocusableCounter:
+  GitHub::Accessibility::NoAriaHiddenOnFocusable:
     enabled: true
-  GitHub::Accessibility::NoAriaLabelMisuseCounter:
+  GitHub::Accessibility::NoAriaLabelMisuse:
     enabled: true
-  GitHub::Accessibility::NoPositiveTabIndexCounter:
+  GitHub::Accessibility::NoPositiveTabIndex:
     enabled: true
-  GitHub::Accessibility::NoRedundantImageAltCounter:
+  GitHub::Accessibility::NoRedundantImageAlt:
     enabled: true
-  GitHub::Accessibility::NoTitleAttributeCounter:
+  GitHub::Accessibility::NoTitleAttribute:
     enabled: true
-  GitHub::Accessibility::SvgHasAccessibleTextCounter:
+  GitHub::Accessibility::SvgHasAccessibleText:
     enabled: true
 ```
 
 ## Rules
 
-- [GitHub::Accessibility::AvoidBothDisabledAndAriaDisabledCounter](./docs/rules/accessibility/avoid-both-disabled-and-aria-disabled.md)
-- [GitHub::Accessibility::AvoidGenericLinkTextCounter](./docs/rules/accessibility/avoid-generic-link-text-counter.md)
-- [GitHub::Accessibility::DisabledAttributeCounter](./docs/rules/accessibility/disabled-attribute-counter.md)
-- [GitHub::Accessibility::LandmarkHasLabelCounter](./docs/rules/accessibility/landmark-has-label-counter.md)
-- [GitHub::Accessibility::LinkHasHrefCounter](./docs/rules/accessibility/link-has-href-counter.md)
-- [GitHub::Accessibility::NestedInteractiveElementsCounter](./docs/rules/accessibility/nested-interactive-elements-counter.md)
-- [GitHub::Accessibility::IframeHasTitleCounter](./docs/rules/accessibility/iframe-has-title-counter.md)
-- [GitHub::Accessibility::ImageHasAltCounter](./docs/rules/accessibility/image-has-alt-counter.md)
-- [GitHub::Accessibility::NoAriaHiddenOnFocusableCounter](./docs/rules/accessibility/no-aria-hidden-on-focusable-counter.md)
-- [GitHub::Accessibility::NoAriaLabelMisuseCounter](./docs/rules/accessibility/no-aria-label-misuse-counter.md)
-- [GitHub::Accessibility::NoPositiveTabIndexCounter](./docs/rules/accessibility/no-positive-tab-index-counter.md)
-- [GitHub::Accessibility::NoRedundantImageAltCounter](./docs/rules/accessibility/no-redundant-image-alt-counter.md)
-- [GitHub::Accessibility::NoTitleAttributeCounter](./docs/rules/accessibility/no-title-attribute-counter.md)
-- [GitHub::Accessibility::SvgHasAccessibleTextCounter](./docs/rules/accessibility/svg-has-accessible-text-counter.md)
-
-## Disabling a rule (experimental)
-
-_This is an experimental feature which should ideally be upstreamed to erblint_
+- [GitHub::Accessibility::AvoidBothDisabledAndAriaDisabled](./docs/rules/accessibility/avoid-both-disabled-and-aria-disabled.md)
+- [GitHub::Accessibility::AvoidGenericLinkText](./docs/rules/accessibility/avoid-generic-link-text.md)
+- [GitHub::Accessibility::DisabledAttribute](./docs/rules/accessibility/disabled-attribute.md)
+- [GitHub::Accessibility::LandmarkHasLabel](./docs/rules/accessibility/landmark-has-label.md)
+- [GitHub::Accessibility::LinkHasHref](./docs/rules/accessibility/link-has-href.md)
+- [GitHub::Accessibility::NestedInteractiveElements](./docs/rules/accessibility/nested-interactive-elements.md)
+- [GitHub::Accessibility::IframeHasTitle](./docs/rules/accessibility/iframe-has-title.md)
+- [GitHub::Accessibility::ImageHasAlt](./docs/rules/accessibility/image-has-alt.md)
+- [GitHub::Accessibility::NoAriaHiddenOnFocusable](./docs/rules/accessibility/no-aria-hidden-on-focusable.md)
+- [GitHub::Accessibility::NoAriaLabelMisuse](./docs/rules/accessibility/no-aria-label-misuse.md)
+- [GitHub::Accessibility::NoPositiveTabIndex](./docs/rules/accessibility/no-positive-tab-index.md)
+- [GitHub::Accessibility::NoRedundantImageAlt](./docs/rules/accessibility/no-redundant-image-alt.md)
+- [GitHub::Accessibility::NoTitleAttribute](./docs/rules/accessibility/no-title-attribute.md)
+- [GitHub::Accessibility::SvgHasAccessibleText](./docs/rules/accessibility/svg-has-accessible-text.md)
+
+## Disabling a rule (Deprecated)
+
+_This is a soon-to-be deprecated feature. Do not use. See [migration guide](./docs/counter-migration-guide.md)_
 
 `erblint` does not natively support rule disables. At GitHub, we've implemented these rules in a way to allow rules to be disabled at an offense-level via counters or disabled at a file-level because often times, we want to enable a rule but aren't able to address all offenses at once. We achieve this in one of two ways.
 
@@ -82,7 +82,7 @@ Rules that are marked as `Counter` can be disabled by adding a comment with the
 <%# erblint:counter GitHub::Accessibility::LinkHasHrefCounter 1 %>
 ```
 
-In this comment example, when a new `LinkHasHrefCounter` offense has been added, the counter will need to be bumped up to 2. More recent rules use a `Counter` format.
+In this comment example, when a new `LinkHasHref` offense has been added, the counter will need to be bumped up to 2. More recent rules use a `Counter` format.
 
 If you are enabling a rule for the first time and your codebase has a lot of offenses, you can use the `-a` command to automatically add these counter comments in the appropriate places.
 

…ility/avoid-generic-link-text-counter.md …accessibility/avoid-generic-link-text.mddocs/rules/accessibility/avoid-generic-link-text-counter.md renamed to docs/rules/accessibility/avoid-generic-link-text.md docs/rules/accessibility/avoid-generic-link-text-counter.md renamed to docs/rules/accessibility/avoid-generic-link-text.md

@@ -1,4 +1,4 @@
-# Disabled attribute counter
+# Disabled attribute
 
 ## Rule Details
 

…essibility/disabled-attribute-counter.md …ules/accessibility/disabled-attribute.mddocs/rules/accessibility/disabled-attribute-counter.md renamed to docs/rules/accessibility/disabled-attribute.md docs/rules/accessibility/disabled-attribute-counter.md renamed to docs/rules/accessibility/disabled-attribute.md

@@ -1,4 +1,4 @@
-# Landmark Has Label Counter
+# Landmark Has Label
 
 ## Rule Details
 

…ccessibility/iframe-has-title-counter.md …/rules/accessibility/iframe-has-title.mddocs/rules/accessibility/iframe-has-title-counter.md renamed to docs/rules/accessibility/iframe-has-title.md docs/rules/accessibility/iframe-has-title-counter.md renamed to docs/rules/accessibility/iframe-has-title.md

@@ -1,4 +1,4 @@
-# Link Has Href counter
+# Link Has Href
 
 ## Rule Details
 

…s/accessibility/image-has-alt-counter.md docs/rules/accessibility/image-has-alt.mddocs/rules/accessibility/image-has-alt-counter.md renamed to docs/rules/accessibility/image-has-alt.md docs/rules/accessibility/image-has-alt-counter.md renamed to docs/rules/accessibility/image-has-alt.md

@@ -1,4 +1,4 @@
-# Nested Interactive Elements Counter
+# Nested Interactive Elements
 
 ## Rule Details
 

…essibility/landmark-has-label-counter.md …ules/accessibility/landmark-has-label.mddocs/rules/accessibility/landmark-has-label-counter.md renamed to docs/rules/accessibility/landmark-has-label.md docs/rules/accessibility/landmark-has-label-counter.md renamed to docs/rules/accessibility/landmark-has-label.md

@@ -1,4 +1,4 @@
-# No aria-hidden on focusable counter
+# No aria-hidden on focusable
 
 ## Rule Details
 

…s/accessibility/link-has-href-counter.md docs/rules/accessibility/link-has-href.mddocs/rules/accessibility/link-has-href-counter.md renamed to docs/rules/accessibility/link-has-href.md docs/rules/accessibility/link-has-href-counter.md renamed to docs/rules/accessibility/link-has-href.md

@@ -1,4 +1,4 @@
-# No aria label misuse counter
+# No aria label misuse
 
 ## Rule Details