From 06ae41e99b1bbb5ddf3c1b015cfa047e70df6d21 Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Thu, 29 Jan 2026 15:35:58 -0800 Subject: [PATCH 1/4] ref(eap-items): Stop double writing booleans into float columns Boolean attributes were being written to both `attributes_bool` and `attributes_float_*` columns. This removes the redundant float write, so booleans are now only stored in `attributes_bool`. Co-Authored-By: Claude Opus 4.5 --- rust_snuba/src/processors/eap_items.rs | 2 -- ...uba__processors__eap_items__tests__serialization.snap | 9 --------- 2 files changed, 11 deletions(-) diff --git a/rust_snuba/src/processors/eap_items.rs b/rust_snuba/src/processors/eap_items.rs index 9931e754c43..e1f4e918a1b 100644 --- a/rust_snuba/src/processors/eap_items.rs +++ b/rust_snuba/src/processors/eap_items.rs @@ -208,8 +208,6 @@ impl AttributeMap { } pub fn insert_bool(&mut self, k: String, v: bool) { - // double write as float and bool - self.insert_float(k.clone(), v as u8 as f64); self.attributes_bool.insert(k, v); } diff --git a/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_items__tests__serialization.snap b/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_items__tests__serialization.snap index 5a40a3ea05e..430052efe94 100644 --- a/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_items__tests__serialization.snap +++ b/rust_snuba/src/processors/snapshots/rust_snuba__processors__eap_items__tests__serialization.snap @@ -8,9 +8,6 @@ expression: item "my.true.bool.field": true, "sentry.is_segment": true }, - "attributes_float_1": { - "my.true.bool.field": 1.0 - }, "attributes_float_14": { "my.int.field": 2000.0 }, @@ -24,9 +21,6 @@ expression: item "sentry.exclusive_time_ms": 0.228, "sentry.start_timestamp_precise": 1721319572.616648 }, - "attributes_float_26": { - "sentry.is_segment": 1.0 - }, "attributes_float_31": { "num_of_spans": 50.0 }, @@ -37,9 +31,6 @@ expression: item "my.neg.field": -100.0, "sentry.duration_ms": 152.0 }, - "attributes_float_6": { - "my.false.bool.field": 0.0 - }, "attributes_float_7": { "sentry.received": 1721319572.877828 }, From 5a6dedc6d23ba50dfaccf2b69a9c1368a7df5df0 Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Thu, 29 Jan 2026 16:36:53 -0800 Subject: [PATCH 2/4] fix(admin): Allow scrolling in admin body container Change overflow from hidden to auto to enable scrolling. Co-Authored-By: Claude Opus 4.5 --- snuba/admin/static/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snuba/admin/static/index.tsx b/snuba/admin/static/index.tsx index c475a43228d..867e0742056 100644 --- a/snuba/admin/static/index.tsx +++ b/snuba/admin/static/index.tsx @@ -21,7 +21,7 @@ const bodyStyle = { flexGrow: 1, display: "flex", minHeight: 0, - overflow: "hidden", + overflow: "auto", }; let client = Client(); From 293d829f85112d21d196813f7fb0eb6324614439 Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Thu, 29 Jan 2026 17:02:34 -0800 Subject: [PATCH 3/4] fix: Update Rust snapshot for boolean-to-float double-write removal Remove the `some_bool: 1.0` from `attributes_float_6` in the test snapshot since booleans are no longer double-written to float columns. Co-Authored-By: Claude Opus 4.5 --- ...items-EAPItemsProcessor-snuba-items__1__basic.protobuf.snap | 3 --- 1 file changed, 3 deletions(-) diff --git a/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-items-EAPItemsProcessor-snuba-items__1__basic.protobuf.snap b/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-items-EAPItemsProcessor-snuba-items__1__basic.protobuf.snap index bf570a6e3c1..8c00a40d011 100644 --- a/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-items-EAPItemsProcessor-snuba-items__1__basic.protobuf.snap +++ b/rust_snuba/src/processors/snapshots/rust_snuba__processors__tests__schemas@snuba-items-EAPItemsProcessor-snuba-items__1__basic.protobuf.snap @@ -10,9 +10,6 @@ expression: snapshot_payload "attributes_float_3": { "another_attribute": 1238.0 }, - "attributes_float_6": { - "some_bool": 1.0 - }, "attributes_float_8": { "with a float": 123.123 }, From be28f00b5dae092b68c82daab05a6f63e0eaad6c Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Thu, 29 Jan 2026 17:11:39 -0800 Subject: [PATCH 4/4] Revert "fix(admin): Allow scrolling in admin body container" This reverts commit 5a6dedc6d23ba50dfaccf2b69a9c1368a7df5df0. --- snuba/admin/static/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/snuba/admin/static/index.tsx b/snuba/admin/static/index.tsx index 867e0742056..c475a43228d 100644 --- a/snuba/admin/static/index.tsx +++ b/snuba/admin/static/index.tsx @@ -21,7 +21,7 @@ const bodyStyle = { flexGrow: 1, display: "flex", minHeight: 0, - overflow: "auto", + overflow: "hidden", }; let client = Client();