-
Notifications
You must be signed in to change notification settings - Fork 38
Suggest to loosen the dependency on rq #397
Description
Dear developers,
Your project freight requires "rq==1.0" in its dependency. After analyzing the source code, we found that the following versions of rq can also be suitable without affecting your project, i.e., rq 1.1.0. Therefore, we suggest to loosen the dependency on rq from "rq==1.0" to "rq>=1.0,<=1.1.0" to avoid any possible conflict for importing more packages or for downstream projects that may use ddos_script.
May I pull a request to further loosen the dependency on rq?
By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?
Details:
Your project (commit id: f39ed1d) directly uses 2 APIs from package rq.
rq.queue.Queue.__init__, rq.worker.Worker.__init__
Beginning fromwhich, 16 functions are then indirectly called, including 11 rq's internal APIs and 5 outsider APIs as follows:
[/getsentry/freight]
+--rq.queue.Queue.__init__
| +--rq.connections.resolve_connection
| | +--rq.connections.get_current_connection
| | +--rq.connections.NoRedisConnectionException.__init__
| +--rq.utils.parse_timeout
| | +--rq.exceptions.TimeoutFormatError.__init__
| +--warnings.warn
| +--rq.utils.import_attribute
| | +--importlib.import_module
+--rq.worker.Worker.__init__
| +--rq.connections.get_current_connection
| +--socket.gethostname
| +--os.getpid
| +--rq.utils.backend_class
| | +--rq.utils.import_attribute
| +--rq.utils.ensure_list
| | +--rq.utils.is_nonstring_iterable
| +--uuid.uuid4
| +--rq.worker.Worker.validate_queues
| +--rq.worker.Worker.push_exc_handler
Since all these functions have not been changed between any version for package "rq" from [1.1.0] and 1.0. Therefore, we believe it is safe to loosen the corresponding dependency.