From 8ded8cfb491dd2a08681be3cfb9bc95a2689c068 Mon Sep 17 00:00:00 2001 From: IvanJGG Date: Wed, 8 Jan 2025 13:46:09 -0600 Subject: [PATCH 1/2] CAF-41 Add Button to create user and test --- tests/cypress/e2e/users.index.cy.js | 11 ++++++++--- views/users/assets/index.js | 10 ++++++---- views/users/index.html | 6 +++++- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/tests/cypress/e2e/users.index.cy.js b/tests/cypress/e2e/users.index.cy.js index 13bcc5c..52e75e9 100644 --- a/tests/cypress/e2e/users.index.cy.js +++ b/tests/cypress/e2e/users.index.cy.js @@ -35,11 +35,10 @@ describe("User Table Tests", () => { ], }, }).as("getUsers"); + cy.visitWithToken("/users"); }); it("redirects to the add user page when edit buttons are clicked", () => { - cy.visitWithToken("/users"); - cy.wait("@getUsers"); cy.get('[data-cy="btnEdit"]').should("exist"); @@ -60,7 +59,6 @@ describe("User Table Tests", () => { body: { message: "Server Error", users: [] }, }).as("getEmptyUsers"); - cy.visitWithToken("/users"); cy.wait("@getEmptyUsers"); cy.get("#userTable").should("be.empty"); @@ -68,4 +66,11 @@ describe("User Table Tests", () => { cy.stub(win.console, "error").as("consoleError"); }); }); + + it("should redirect to /users/add.html when clicked", () => { + cy.get("#registerUser").should("exist"); + + cy.get("#registerUser").click(); + cy.url().should("include", "/users/add.html"); + }); }); diff --git a/views/users/assets/index.js b/views/users/assets/index.js index d988cb0..59c792b 100644 --- a/views/users/assets/index.js +++ b/views/users/assets/index.js @@ -11,9 +11,7 @@ function createTableRow(user) { const row = document.createElement("tr"); const addressCell = createCell(user.address); - const fullNameCell = createCell( - `${user.firstName} ${user.secondName} ${user.lastname} ${user.secondLastname} `, - ); + const fullNameCell = createCell(`${user.firstName} ${user.lastName}`); const phoneCell = createCell(user.phoneNumber); const actionsCell = createActionsCell(user); @@ -86,7 +84,7 @@ async function loadUsersTable() { const userTable = document.getElementById("userTable"); userTable.innerHTML = ""; - response.data.users.forEach((user) => { + response.data.addresses.forEach((user) => { const row = createTableRow(user); userTable.appendChild(row); }); @@ -95,6 +93,10 @@ async function loadUsersTable() { } } +document.getElementById("registerUser").addEventListener("click", () => { + window.location.href = "/users/add.html"; +}); + window.addEventListener("load", async () => { await loadUsersTable(); }); diff --git a/views/users/index.html b/views/users/index.html index 6f2b101..c3fac8d 100644 --- a/views/users/index.html +++ b/views/users/index.html @@ -3,6 +3,10 @@

Lista de Usuarios

+ + @@ -17,4 +21,4 @@

Lista de Usuarios

- + From e84acc36e9e79a36f49cb945a14740f0f70e8cbf Mon Sep 17 00:00:00 2001 From: IvanJGG Date: Wed, 8 Jan 2025 14:20:36 -0600 Subject: [PATCH 2/2] CAF-41 Correction of code in user index.js --- tests/cypress/e2e/users.index.cy.js | 6 ++++-- views/users/assets/index.js | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/cypress/e2e/users.index.cy.js b/tests/cypress/e2e/users.index.cy.js index 52e75e9..f9aab8b 100644 --- a/tests/cypress/e2e/users.index.cy.js +++ b/tests/cypress/e2e/users.index.cy.js @@ -59,6 +59,7 @@ describe("User Table Tests", () => { body: { message: "Server Error", users: [] }, }).as("getEmptyUsers"); + cy.visitWithToken("/users"); cy.wait("@getEmptyUsers"); cy.get("#userTable").should("be.empty"); @@ -67,10 +68,11 @@ describe("User Table Tests", () => { }); }); - it("should redirect to /users/add.html when clicked", () => { + it("should redirect to /users/add when clicked", () => { + cy.visitWithToken("/users"); cy.get("#registerUser").should("exist"); cy.get("#registerUser").click(); - cy.url().should("include", "/users/add.html"); + cy.url().should("include", "/users/add"); }); }); diff --git a/views/users/assets/index.js b/views/users/assets/index.js index 59c792b..0277094 100644 --- a/views/users/assets/index.js +++ b/views/users/assets/index.js @@ -84,7 +84,7 @@ async function loadUsersTable() { const userTable = document.getElementById("userTable"); userTable.innerHTML = ""; - response.data.addresses.forEach((user) => { + response.data.users.forEach((user) => { const row = createTableRow(user); userTable.appendChild(row); }); @@ -94,7 +94,7 @@ async function loadUsersTable() { } document.getElementById("registerUser").addEventListener("click", () => { - window.location.href = "/users/add.html"; + window.location.href = "/users/add"; }); window.addEventListener("load", async () => {