Kitty keyboard: incorrect handling of shifted keys

[rockorager]

Reproducer

kitten show-key -m kitty

Press ":" on us layout (shift + ;)

Expected output

CSI 59 : 58 ; 2 ; 58 u

Actual output

CSI 58 ; 2 ; 58 u

Issue

We need to get the physical key from xkb. Using wev I can see this is delivered as "key: 47" for both a ';' press and a 'shift + ;' press, but I can't see how to get this information from xkb directly in wraith. Ultimately, this will need to be used to set the input.KeyEvent key, physical_key, and unshifted_codepoint just before the keyCallback function.

[ferrreo]

How does foot handle this or is it just wrong?

[rockorager]

Foots output is the same as expected, which matches Ghostty core:

CSI 59 : 58 ; 2 : 1 ; 58 u

[gabydd]

I have seen something similar with shift tab not working, will look into it

[gabydd]

ah shift tab was me just not handling an enum so a bit different, correct me if I am wrong but the problem here is we are sending the shifted key and we need to get the unshifted one I think we just need to get the level 0 keyboard to do this(https://xkbcommon.org/doc/current/group__components.html#gad92b9334170316926595fbb5d634a181), it looks like this is what foot does as well

[rockorager]

we are sending the shifted key and we need to get the unshifted one

Ah yep, that is correct.