diff --git a/app/src/main/java/info/papdt/blackblub/ui/MainActivity.java b/app/src/main/java/info/papdt/blackblub/ui/MainActivity.java index 9d4f923..525cfac 100644 --- a/app/src/main/java/info/papdt/blackblub/ui/MainActivity.java +++ b/app/src/main/java/info/papdt/blackblub/ui/MainActivity.java @@ -227,9 +227,8 @@ private void initSchedulerRow() { mSchedulerRow = findViewById(R.id.scheduler_row); mSchedulerIcon = findViewById(R.id.scheduler_icon); mSchedulerStatus = findViewById(R.id.tv_scheduler_status); - Button settingsButton = findViewById(R.id.btn_scheduler_settings); - settingsButton.setOnClickListener(v -> { + mSchedulerRow.setOnClickListener(v -> { if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) { PowerManager pm = getSystemService(PowerManager.class); if (pm != null && !pm.isIgnoringBatteryOptimizations(getPackageName())) { @@ -245,7 +244,6 @@ private void initSchedulerRow() { } showSchedulerDialog(); }); - mSchedulerRow.setOnClickListener(v -> settingsButton.performClick()); updateSchedulerRow(); } @@ -303,29 +301,27 @@ private void updateSchedulerRow() { private void initAdvancedModeRow() { mAdvancedModeRow = findViewById(R.id.advanced_mode_row); - mAdvancedModeText = findViewById(R.id.advanced_mode_text); - ImageButton settingsButton = findViewById(R.id.btn_advanced_mode_settings); + mAdvancedModeText = findViewById(R.id.tv_mode_status); + + mAdvancedModeRow.setOnClickListener(v -> showAdvancedModeDialog()); - settingsButton.setOnClickListener(v -> showAdvancedModeDialog()); if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { - settingsButton.setImageResource(R.drawable.ic_help_outline_black_24dp); - settingsButton.setOnClickListener(v -> { - // Show explanation + // Show explanation + mAdvancedModeRow.setOnClickListener(o -> new AlertDialog.Builder(this) - .setTitle(R.string.mode_android_oreo_explanation_dialog_title) - .setMessage(R.string.mode_android_oreo_explanation_dialog_message) - .setNeutralButton(R.string.mode_android_oreo_explanation_read_more, - (d, w) -> startActivity( - new Intent(Intent.ACTION_VIEW, Uri.parse( - getString( - R.string.mode_android_oreo_explanation_url) - ))) - ) - .setPositiveButton(android.R.string.ok, (d, w) -> {}) - .show(); - }); + .setTitle(R.string.mode_android_oreo_explanation_dialog_title) + .setMessage(R.string.mode_android_oreo_explanation_dialog_message) + .setNeutralButton(R.string.mode_android_oreo_explanation_read_more, + (d, w) -> startActivity( + new Intent(Intent.ACTION_VIEW, Uri.parse( + getString( + R.string.mode_android_oreo_explanation_url) + ))) + ) + .setPositiveButton(android.R.string.ok, (d, w) -> {}) + .show() + ); } - mAdvancedModeRow.setOnClickListener(v -> settingsButton.performClick()); updateAdvancedModeRow(); } @@ -382,9 +378,9 @@ private void showAdvancedModeDialog() { mSettings.setAdvancedMode(adapter.getItem(which).getModeId()); updateAdvancedModeRow(); // Restart service - mToggle.performClick(); - mToggle.postDelayed(() -> mToggle.performClick(), 800); - dialog.dismiss(); + mToggle.performClick(); + mToggle.postDelayed(() -> mToggle.performClick(), 800); + dialog.dismiss(); }) .setNegativeButton(android.R.string.cancel, null) .show(); diff --git a/app/src/main/res/layout/include_advanced_mode_row.xml b/app/src/main/res/layout/include_advanced_mode_row.xml index 465f5c1..c305a14 100644 --- a/app/src/main/res/layout/include_advanced_mode_row.xml +++ b/app/src/main/res/layout/include_advanced_mode_row.xml @@ -9,7 +9,6 @@ android:paddingEnd="16dp" android:paddingTop="16dp" android:paddingBottom="16dp" - android:gravity="center_vertical" android:clickable="true" android:focusable="true" android:background="?android:attr/selectableItemBackground" @@ -23,24 +22,28 @@ android:src="@drawable/ic_developer_board_black_24dp" android:tint="?attr/icon_tint"/> - + android:layout_weight="1" + android:orientation="vertical"> - + + + + + \ No newline at end of file diff --git a/app/src/main/res/layout/include_more_settings_row.xml b/app/src/main/res/layout/include_more_settings_row.xml index 01b6b87..7b4845a 100644 --- a/app/src/main/res/layout/include_more_settings_row.xml +++ b/app/src/main/res/layout/include_more_settings_row.xml @@ -1,18 +1,18 @@ - + android:tint="?attr/icon_tint" /> + android:textAppearance="@android:style/TextAppearance.Material.Body2" /> + android:tint="?attr/icon_tint" /> \ No newline at end of file diff --git a/app/src/main/res/layout/include_scheduler_row.xml b/app/src/main/res/layout/include_scheduler_row.xml index 51223a4..01d7a9f 100644 --- a/app/src/main/res/layout/include_scheduler_row.xml +++ b/app/src/main/res/layout/include_scheduler_row.xml @@ -1,17 +1,17 @@ - + android:tint="?attr/icon_tint" /> + android:textAppearance="@android:style/TextAppearance.Material.Body2" /> - -