FreeBSD support

[Martinfx]

Hi,
I tried compile skia, part of Friction on FreeBSD.

-- Build files have been written to: /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build
===>  Building for friction-1.0.0
[  0% 1/443] cd /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine && /usr/local/bin/cmake -Dcfgdir= -P /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/tmp/Engine-mkdirs.cmake && /usr/local/bin/cmake -E touch /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src/Engine-stamp/Engine-mkdir
[  0% 2/443] cd /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src && : && /usr/local/bin/cmake -E touch /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src/Engine-stamp/Engine-download
[  0% 3/443] cd /home/maxfx/Documents/FreeBSD-Ports/friction/work/friction-1.0.0-rc.2/src/engine/skia && true
[  0% 4/443] cd /home/maxfx/Documents/FreeBSD-Ports/friction/work/friction-1.0.0-rc.2/src/engine/skia && : && /usr/local/bin/cmake -E touch /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src/Engine-stamp/Engine-patch
[  0% 5/443] cd /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/skia && /usr/local/bin/gn gen --root=/home/maxfx/Documents/FreeBSD-Ports/friction/work/friction-1.0.0-rc.2/src/engine/skia /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/skia "--args=ar=\"/usr/bin/llvm-ar\" cc=\"/usr/bin/cc\" cxx=\"/usr/bin/c++\" skia_use_egl=true is_component_build=true extra_cflags=[\"-Wno-error\", \"-Wno-psabi\"] is_official_build=true is_debug=false skia_use_wuffs=false skia_enable_pdf=false skia_enable_skottie=false skia_enable_tools=false skia_use_dng_sdk=false skia_use_system_expat=true skia_use_system_libjpeg_turbo=true skia_use_system_libpng=true skia_use_system_libwebp=true skia_use_system_icu=true skia_use_system_harfbuzz=true skia_use_system_freetype2=true" && /usr/local/bin/cmake -E touch /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src/Engine-stamp/Engine-configure
ERROR at //BUILD.gn:895:3: Unknown function.
  set_sources_assignment_filter([])
  ^----------------------------
FAILED: [code=1] src/engine/Engine-prefix/src/Engine-stamp/Engine-configure /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src/Engine-stamp/Engine-configure 
cd /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/skia && /usr/local/bin/gn gen --root=/home/maxfx/Documents/FreeBSD-Ports/friction/work/friction-1.0.0-rc.2/src/engine/skia /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/skia "--args=ar=\"/usr/bin/llvm-ar\" cc=\"/usr/bin/cc\" cxx=\"/usr/bin/c++\" skia_use_egl=true is_component_build=true extra_cflags=[\"-Wno-error\", \"-Wno-psabi\"] is_official_build=true is_debug=false skia_use_wuffs=false skia_enable_pdf=false skia_enable_skottie=false skia_enable_tools=false skia_use_dng_sdk=false skia_use_system_expat=true skia_use_system_libjpeg_turbo=true skia_use_system_libpng=true skia_use_system_libwebp=true skia_use_system_icu=true skia_use_system_harfbuzz=true skia_use_system_freetype2=true" && /usr/local/bin/cmake -E touch /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src/Engine-stamp/Engine-configure
ninja: build stopped: subcommand failed.

[rodlie]

We only support gn included with our skia fork.

Use main as it includes several fixes for building skia.

Note that FreeBSD is not supported and will not build (src/app will fail).

EDIT: It may build, but it will not work properly.

[Martinfx]

We only support gn included with our skia fork.

Use main as it includes several fixes for building skia.

Note that FreeBSD is not supported and will not build (src/app will fail).

EDIT: It may build, but it will not work properly.

I wrote patches for FreeBSD and should work on FreeBSD.

[rodlie]

I wrote patches for FreeBSD and should work on FreeBSD.

Ok, let me know how it works out (or have other questions) 👍

The most important part is https://github.com/friction2d/friction/blob/main/src/app/memorychecker.cpp as we need to know used and available RAM.

EDIT: If you don't want to use main check https://github.com/friction2d/skia/blob/m83f/CMakeLists.txt for changes related to gn.

[Martinfx]

I wrote patches for FreeBSD and should work on FreeBSD.

Ok, let me know how it works out (or have other questions) 👍

The most important part is https://github.com/friction2d/friction/blob/main/src/app/memorychecker.cpp as we need to know used and available RAM.

EDIT: If you don't want to use main check https://github.com/friction2d/skia/blob/m83f/CMakeLists.txt for changes related to gn.

Hi,
this is problem in skia in main branch.

Done. Made 87 targets from 44 files in 116ms
[  0% 4/442] cd /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/skia && ninja -j32 && /usr/local/bin/cmake -E touch /home/maxfx/Documents/FreeBSD-Ports/friction/work/.build/src/engine/Engine-prefix/src/Engine-stamp/Engine-build
[ 37% 7/8] compile ../../../../friction-1.0.0-rc.2/src/engine/skia/experimental/sktext/src/LogicalRun.cpp
FAILED: [code=1] obj/experimental/sktext/src/libsktext.LogicalRun.o 
/usr/bin/c++ -MD -MF obj/experimental/sktext/src/libsktext.LogicalRun.o.d -DNDEBUG -DSK_GL -DSK_CODEC_DECODES_JPEG -DSK_ENCODE_JPEG -DSK_CODEC_DECODES_PNG -DSK_ENCODE_PNG -DSK_CODEC_DECODES_WEBP -DSK_ENCODE_WEBP -DSK_XML -DSKIA_DLL -DSK_ENABLE_SKSL -DSK_ENABLE_PRECOMPILE -DSK_GANESH -DSKSHAPER_DLL -DSK_SHAPER_HARFBUZZ_AVAILABLE -DSK_UNICODE_AVAILABLE -DSK_UNICODE_ICU_IMPLEMENTATION -DSKUNICODE_DLL -I../../../../friction-1.0.0-rc.2/src/engine/skia/experimental/sktext/include -I../../../../friction-1.0.0-rc.2/src/engine/skia -I../../../../friction-1.0.0-rc.2/src/engine/skia/modules/skshaper/include -I../../../../friction-1.0.0-rc.2/src/engine/skia/modules/skunicode/include -Wno-attributes -ffp-contract=off -fstrict-aliasing -fPIC -fvisibility=hidden -O3 -fdata-sections -ffunction-sections -Wno-error -Wno-psabi -I/usr/local/include -I/usr/local/include/harfbuzz -std=c++17 -fvisibility-inlines-hidden -fno-exceptions -fno-rtti -c ../../../../friction-1.0.0-rc.2/src/engine/skia/experimental/sktext/src/LogicalRun.cpp -o obj/experimental/sktext/src/libsktext.LogicalRun.o
In file included from ../../../../friction-1.0.0-rc.2/src/engine/skia/experimental/sktext/src/LogicalRun.cpp:3:
In file included from ../../../../friction-1.0.0-rc.2/src/engine/skia/experimental/sktext/src/LogicalRun.h:5:
../../../../friction-1.0.0-rc.2/src/engine/skia/experimental/sktext/include/Types.h:114:19: error: no member named 'leftToRight' in 'Range<T>'
  114 |         if (this->leftToRight()) {
      |             ~~~~  ^