From a684a88678e8f56b606be5623ca560ead544ec65 Mon Sep 17 00:00:00 2001
From: mmmmcoffee <50842195+mmmmcoffee@users.noreply.github.com>
Date: Fri, 15 Dec 2023 13:29:45 -0500
Subject: [PATCH] Operator precedence fix

Comparison operator has higher precedence than bitwise operator. This caused the packer to fail on some exes (Mimikatz - failed to load function from cabinet.dll for example).
---
 stub/src/main.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/stub/src/main.cpp b/stub/src/main.cpp
index 4bc465f..fc41170 100644
--- a/stub/src/main.cpp
+++ b/stub/src/main.cpp
@@ -135,7 +135,7 @@ void load_imports(std::uint8_t *image) {
 
          // if the top-most bit is set, this is a function ordinal.
          // otherwise, it's an import by name.
-         if (lookup_address & IMAGE_ORDINAL_FLAG64 != 0)
+         if ((lookup_address & IMAGE_ORDINAL_FLAG64) != 0)
          {
             // get the function ordinal by masking the lower 32-bits of the lookup address.
             function = GetProcAddress(dll_import,
@@ -178,7 +178,7 @@ void relocate(std::uint8_t *image) {
    // then this image probably isn't prepared for relocating.
    auto nt_header = get_nt_headers(image);
 
-   if (nt_header->OptionalHeader.DllCharacteristics & IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE == 0)
+   if ((nt_header->OptionalHeader.DllCharacteristics & IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE) == 0)
    {
       std::cerr << "Error: image cannot be relocated." << std::endl;
       ExitProcess(7);