chore: update display-notification to v3#47
Open
mikejancar wants to merge 1 commit intoforwardemail:masterfrom
Open
chore: update display-notification to v3#47mikejancar wants to merge 1 commit intoforwardemail:masterfrom
mikejancar wants to merge 1 commit intoforwardemail:masterfrom
Conversation
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Author
|
Is there anything else that is needed before this PR can be reviewed? I believe that I have followed all of the guidelines, but I may have missed something. |
|
Looks pretty straight forward to me. |
|
cc: @titanism @niftylettuce I think this is ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Changes made
display-notificationfrom2.0.0to3.0.0requirestatement to be dynamic to align with the new version ofdisplay-notificationReason for the change
Some security scanners list the
0.10.0version of theexecapackage as being vulnerable to a command injection attack. Theexecapackage is a direct dependency of therun-applescriptpackage which is a direct dependency ofdisplay-notification. This update upgradesrun-applescriptto a^5.0.0version which takesexecaup to a^5.0.0version.