Add analog buttons adapter

[matej2005]

Hi i wanted to use this library in my project that uses 1602 LCD Keypad Shield, but i didnt found way how to use its buttons for navigation with this library.
The shield use one analog pin: A0 for buttons. Each button is connected trough resistor and have different value.

I think it would be nice to have support for this shield. I made my own adapter but i think it will need some additional work (easy way of changing buttons values inside main sketch). If i have time, i will try to make PR

My code:

#pragma once

#include "./InputInterface.h"

#define btn_val_RIGHT 0
#define btn_val_UP 100
#define btn_val_DOWN 250
#define btn_val_LEFT 400
#define btn_val_SELECT 600

class AnalogButtonAdapter : public InputInterface {
  private:
    uint8_t pinNumber; 

  public:    AnalogButtonAdapter(LcdMenu* menu, uint8_t pinNumber)
     : InputInterface(menu), pinNumber(pinNumber) {
    }

    uint8_t observe() override {
        int16_t ar = analogRead(pinNumber);
        if (btn_val_RIGHT >= (ar - 60) && btn_val_RIGHT <= (ar + 60)) menu->process(BACKSPACE);
        else if (btn_val_LEFT >= (ar - 60) && btn_val_LEFT <= (ar + 60)) menu->process(BACK);
        else if (btn_val_UP >= (ar - 60) && btn_val_UP <= (ar + 60)) menu->process(UP);
        else if (btn_val_DOWN >= (ar - 60) && btn_val_DOWN <= (ar + 60)) menu->process(DOWN);
        else if (btn_val_SELECT >= (ar - 60) && btn_val_SELECT <= (ar + 60)) menu->process(ENTER);
    	return ar;
    }
};

Sorry if my english is bad, its not my first language.

[forntoh]

Hi @matej2005, looks like something we can add to the library, are you experienced with git? If so, you can create a PR and I will review it.

[matej2005]

I have some experience with git, but only worked on my personal projects. I cloned the repo and made some changes. I will try to finish them tomorrow. I will also made basic example for that shield. But, I'm not entirely sure how to make PR, should i create my fork and contribute from there?

[forntoh]

You can follow this guide

[matej2005]

Hi, i made PR but i have some questions

1. How to tag the PR with "feature" ?
2. Should i create "functionality test"? In test folder i don´t see any tests for adapters

[forntoh]

Nice, I have seen it.

1. by adding a label (usually on the right section)
2. It's not necessary, but a nice to have if you got the time to try.

[matej2005]

I see labels, but I think I don´t have permissions. I cant edit it.