Tray icon missing after switch to libappindicator

[wjt]

Recent versions of Dropbox (not yet merged) proclaim loudly that they require libappindicator for tray icon support. OK!

https://help.dropbox.com/installs/dropbox-desktop-app-for-linux

But when I add it to the manifest, the icon is:

This is presumably because the icon name is set to dropboxstatus-logo with the theme path set to a sandboxed path:

(
  {
    "AttentionAccessibleDesc": <"">,
    "AttentionIconName": <"">,
    "Category": <"ApplicationStatus">,
    "IconAccessibleDesc": <"">,
    "IconName": <"dropboxstatus-logo">,
    "IconThemePath": <"/app/extra/.dropbox-dist/dropbox-lnx.x86_64-223.4.4909/images">,
    "Id": <"dropbox-client-7">,
    "Menu": <objectpath "/org/ayatana/NotificationItem/dropbox_client_7/Menu">,
    "Status": <"Active">,
    "Title": <"dropbox">,
    "XAyatanaLabel": <"">,
    "XAyatanaLabelGuide": <"">,
    "XAyatanaOrderingIndex": <uint32 0>
  },
)

Not too surprising since libappindicator is not sandbox-aware...

[wjt]

It should be relatively easy, famous last words, to patch libappindicator to replace the sandbox path in IconThemePath with the path outside the sandbox.

[wjt]

I merged #368 which adds libappindicator (avoiding the launch-time warning about it being required). The menu works better than the old one did, but at the cost of the icon being broken. I think it's still an improvement...

[andreacasini]

I would agree if the Dropbox icon didn't have status or notifications that are not useless.
I agree that the menu works better, but I will have to install the native package now because I need those notifications and status updates.

[wjt]

The choice was to accept the update with this regression or to stop updating this wrapper. Help is welcome with patching libappindicator to be sandbox aware.