From 791a0c266ae647aa97d42c5017ee11401cc1c801 Mon Sep 17 00:00:00 2001 From: XanGrab <60899653+XanGrab@users.noreply.github.com> Date: Tue, 20 Jan 2026 13:19:05 -0600 Subject: [PATCH 1/2] fixing preemptive logging of task completion --- Assets/_Modules/Analytics/AnalyticsService.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/Assets/_Modules/Analytics/AnalyticsService.cs b/Assets/_Modules/Analytics/AnalyticsService.cs index be3168bc6..e15f26321 100644 --- a/Assets/_Modules/Analytics/AnalyticsService.cs +++ b/Assets/_Modules/Analytics/AnalyticsService.cs @@ -339,7 +339,6 @@ private void UpdateJobInfo(StringHash32 id) { var task = tasks[i]; ref var taskData = ref m_GameState.task_list[i]; taskData.task_id = task.IdString; - // taskData.task_description = Loc.Find(task.LabelId); taskData.is_complete = Save.Jobs.IsTaskComplete(task.Id); } } @@ -595,8 +594,7 @@ private void LogSelectLanguage(FourCC langCode) { } } - private void SetCurrentJob(StringHash32 jobId) - { + private void SetCurrentJob(StringHash32 jobId) { m_CurrentJobHash = jobId; m_PreviousJobName = m_GameState.job_id; @@ -604,8 +602,7 @@ private void SetCurrentJob(StringHash32 jobId) RefreshGameState(); } - private void LogAcceptJob(StringHash32 jobId) - { + private void LogAcceptJob(StringHash32 jobId) { RefreshGameState(); using(var e = m_Log.NewEvent("accept_job")) { } @@ -726,11 +723,11 @@ private void FinalFinalSurveyTriggerCheck(SceneBinding s, object c) { private void LogCompleteTask(StringHash32 jobId, StringHash32 inTaskId){ string taskId = Assets.Job(jobId).Task(inTaskId).IdString; - UpdateJobTaskCompletion(); RefreshGameState(); using(var e = m_Log.NewEvent("complete_task")) { e.Param("task_id", taskId); } + UpdateJobTaskCompletion(); } private void LogBeginDive(string inTargetScene) From a06d7c547d820155f7efc71b265ee91be043c03f Mon Sep 17 00:00:00 2001 From: Autumn Date: Thu, 22 Jan 2026 10:06:39 -0600 Subject: [PATCH 2/2] * incremented client log version --- Assets/_Modules/Analytics/AnalyticsService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Assets/_Modules/Analytics/AnalyticsService.cs b/Assets/_Modules/Analytics/AnalyticsService.cs index e15f26321..822bb1c0e 100644 --- a/Assets/_Modules/Analytics/AnalyticsService.cs +++ b/Assets/_Modules/Analytics/AnalyticsService.cs @@ -34,7 +34,7 @@ namespace Aqua public partial class AnalyticsService : ServiceBehaviour, IDebuggable { private const string NoActiveJobId = "no-active-job"; - private const int ClientLogVersion = 5; + private const int ClientLogVersion = 6; static private readonly string[] FactTypeStringTable = Enum.GetNames(typeof(BFTypeId));