-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Issue Description
The test function in test_score2.py has an incorrect name that doesn't match what it's testing.
Problem
- tests/test_score2.py:17 - Function is named
test_phenoagebut it's testing the SCORE2 algorithm
Current Code
def test_phenoage(filename, expected):
# Get the actual fixture value using request.getfixturevalue
age, pred_risk, pred_risk_category = compute.cardiovascular_risk(OUT_FILEPATH / filename)
...Expected Fix
def test_score2(filename, expected):
# Get the actual fixture value using request.getfixturevalue
age, pred_risk, pred_risk_category = compute.cardiovascular_risk(OUT_FILEPATH / filename)
...Impact
This is a simple naming issue but should be fixed for code clarity and consistency.
Related
- PR feat: Implement SCORE2 cardiovascular risk assessment algorithm #2: feat: Implement SCORE2 cardiovascular risk assessment algorithm
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working