From 6f047180eb9fb7db1c3b2044e3670fd3057041d6 Mon Sep 17 00:00:00 2001 From: Ben Gourley Date: Tue, 5 Jan 2021 15:44:42 +0000 Subject: [PATCH] Bump "promise" to ^8.0.3 to match React Native MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit React Native 0.63 (and by extension Expo SDK 39-40) bumped its dependency on "promise" to be ^8.0.3 ¹ This repo depends on promise@^7.1.1 which has no valid overlapping versions. This module "fbjs" is depended on by "metro", which in turn is depended on by RN/Expo projects. This means that on a standard RN/Expo project, two versions of "promise" get installed, making it impossible to obtain a reference to the same version that React Native is using², and thus impossible to detect unhandled promise rejections – and for example report them to Bugsnag. ¹ https://github.com/facebook/react-native/commit/b23efc526446cad53adc3de7465fd8be7309d84e ² https://github.com/bugsnag/bugsnag-js/blob/eb6e05f350f5acf496c9e3dfd341c9061c400c1f/packages/plugin-react-native-unhandled-rejection/rejection-handler.js#L5 --- packages/fbjs/package.json | 2 +- packages/fbjs/yarn.lock | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/fbjs/package.json b/packages/fbjs/package.json index 49c04d65..5d2d6ce3 100644 --- a/packages/fbjs/package.json +++ b/packages/fbjs/package.json @@ -67,7 +67,7 @@ "fbjs-css-vars": "^1.0.0", "loose-envify": "^1.0.0", "object-assign": "^4.1.0", - "promise": "^7.1.1", + "promise": "^8.0.3", "setimmediate": "^1.0.5", "ua-parser-js": "^0.7.18" }, diff --git a/packages/fbjs/yarn.lock b/packages/fbjs/yarn.lock index 463d425a..a0b023b7 100644 --- a/packages/fbjs/yarn.lock +++ b/packages/fbjs/yarn.lock @@ -696,7 +696,7 @@ arrify@^1.0.0, arrify@^1.0.1: resolved "https://registry.yarnpkg.com/arrify/-/arrify-1.0.1.tgz#898508da2226f380df904728456849c1501a4b0d" integrity sha1-iYUI2iIm84DfkEcoRWhJwVAaSw0= -asap@~2.0.3: +asap@~2.0.6: version "2.0.6" resolved "https://registry.yarnpkg.com/asap/-/asap-2.0.6.tgz#e50347611d7e690943208bbdafebcbc2fb866d46" integrity sha1-5QNHYR1+aQlDIIu9r+vLwvuGbUY= @@ -1871,7 +1871,7 @@ fbjs-css-vars@^1.0.0: integrity sha512-IM+v/C40MNZWqsLErc32e0TyIk/NhkkQZL0QmjBh6zi1eXv0/GeVKmKmueQX7nn9SXQBQbTUcB8zuexIF3/88w== "fbjs-scripts@file:../fbjs-scripts": - version "2.0.0" + version "3.0.0" dependencies: "@babel/core" "^7.0.0" ansi-colors "^1.0.1" @@ -4191,12 +4191,12 @@ process-nextick-args@~2.0.0: resolved "https://registry.yarnpkg.com/process-nextick-args/-/process-nextick-args-2.0.0.tgz#a37d732f4271b4ab1ad070d35508e8290788ffaa" integrity sha512-MtEC1TqN0EU5nephaJ4rAtThHtC86dNN9qCuEhtshvpVBkAW5ZO7BASN9REnF9eoXGcRub+pFuKEpOHE+HbEMw== -promise@^7.1.1: - version "7.3.1" - resolved "https://registry.yarnpkg.com/promise/-/promise-7.3.1.tgz#064b72602b18f90f29192b8b1bc418ffd1ebd3bf" - integrity sha512-nolQXZ/4L+bP/UGlkfaIujX9BKxGwmQ9OT4mOt5yvy8iK1h3wqTEJCijzGANTCCl9nWjY41juyAn2K3Q1hLLTg== +promise@^8.0.3: + version "8.1.0" + resolved "https://registry.yarnpkg.com/promise/-/promise-8.1.0.tgz#697c25c3dfe7435dd79fcd58c38a135888eaf05e" + integrity sha512-W04AqnILOL/sPRXziNicCjSNRruLAuIHEOVBazepu0545DDNGYHz7ar9ZgZ1fMU8/MA4mVxp5rkBWRi6OXIy3Q== dependencies: - asap "~2.0.3" + asap "~2.0.6" prompts@^0.1.9: version "0.1.14"