fuseSynchronizeFile should take `fh` as a parameter

[matil019]

Nice to meet you.

I'm studying this package by writing an "identity" filesystem whose callbacks just calls corresponding system calls.

I've stumbled upon implementing fuseSynchronizeFile, whose type is FuseOperations fh -> FilePath -> SyncType -> IO Errno. I believe it is supposed to implement fsync(2), which takes a file descriptor. However I can't implement it because it doesn't take fh as a parameter like fuseRead and fuseWrite do.

I think fuseSynchronizeFile should have a type FuseOperations fh -> FilePath -> fh -> SyncType -> IO Errno. I'm ready to write a PR.

[m15k]

Thank you, please put into a PR.

…

On Sun, Apr 19, 2020 at 10:06 AM matil019 ***@***.***> wrote: Nice to meet you. I'm studying this package by writing an "identity" filesystem whose callbacks just calls corresponding system calls. I've stumbled upon implementing fuseSynchronizeFile, whose type is FuseOperations fh -> FilePath -> SyncType -> IO Errno. I believe it is supposed to implement fsync(2), which takes a file descriptor. However I can't implement it because it doesn't take fh as a parameter like fuseRead and fuseWrite do. I think fuseSynchronizeFile should have a type FuseOperations fh -> FilePath -> fh -> SyncType -> IO Errno. I'm ready to write a PR. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5CBPMMAEJ7VFVWAXKPL3RNMHOTANCNFSM4ML2LYPA> .

[matil019]

Thank you.

It turned out that the callbacks for directories (fuseOpenDirectory, fuseReadDirectory, fuseReleaseDirectory and fuseSynchronizeDirectory) also need handles. I'm going to add another type variable to FuseOperations for directory handles.

So it would look like:

data FuseOperations fh dh = FuseOperations
  { ...
  , fuseSynchronizeFile :: FilePath -> fh -> SyncType -> IO Errno
  , fuseOpenDirectory :: FilePath -> IO (Either Errno dh)
  , fuseReadDirectory :: FilePath -> dh -> IO (Either Errno [(FilePath, FileStat)])
  , etc...
  }

Added dh. In my use case, dh would correspond to DIR *.

[plredmond]

I'm also writing a passthru implementation and came to the same conclusion. Thanks for doing PR #12 @matil019!