puppi does not differentiate between ERROR and WARNING regarding exit-codes

[k9ert]

It seems that puppi returns 0 for OK and 1 for WARNING AND ERROR.

Didn't thought about that sideeffect at this commit:
https://github.com/hybris/puppi/commit/a6aeb58172be2575ca58c88720a7d8a98fb1a129

However, wouldn't it be a good idea that puppi returns 2 for ERROR? That would be the "nagios-convention" and would solve my issue that i have now: The autorun returns as successfull but is error because of my above change.

Any thoughts?

[alvagante]

Well true, that would be better.
Generally during a deploy warnings are due to puppi checks failing, so you could, as workaround, disable puppi checks in a deploy (with run_checks => false in the puppi::project::* define)

[alvagante]

(incidentally this would require a revert of that commit)