conversion fails with .notdef ENCODING -1 entries

[x37v]

I'll preface this by saying I don't really know anything about BDF. I'm trying to convert some of these fonts: https://github.com/farsil/ibmfonts to use in my embedded graphics based project.

EgBdfOutput::new(font: Font) expects all glyphs to have encoding entries but the parser encodes None if the ENCODING entry isn't a positive integer

this bdf spec indicates that encoding can be negative:

3 File Format 9
ENCODING integer (integer)
ENCODING is followed by a positive integer representing the Adobe Stan-
dard Encoding value. If the character is not in the Adobe Standard Encoding,
ENCODING is followed by –1 and optionally by another integer specifying
the glyph index for the non-standard encoding.

and all of the fonts that I've tried to parse from that repo have this entry as the last character in the font:

STARTCHAR .notdef
ENCODING -1
SWIDTH 500 0
DWIDTH 8 0
BBX 8 16 0 -4
BITMAP
FF
FF
83
39
39
F3
E7
E7
E7
FF
E7
E7
FF
FF
FF
FF
ENDCHAR

since I don't really know what i'm doing, I don't know what the implication of just removing that entry from the font before doing the conversion, or trying to skip that glyph would be.

[rfuest]

I've modified the parser a bit to handle this case more gracefully. The way encodings are handled is still a bit of a mess and needs to be cleaned up further, but with the changes in #38 the fonts should work now:

[x37v]

I just pulled the latest dea42bedf133117ad731d04a57efef4ac7ebd29f and trying to convert one of these fonts still fails, a little more gracefully though.

xnor@xnor-m3-macbook-12160 eg-font-converter % cargo run -- --rust foo.rs --data foo.data --png foo.png ~/local/src/ibmfonts/bdf/icl8x16u.bdf foo
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running `/Users/xnor/local/src/bdf/target/debug/eg-font-converter --rust foo.rs --data foo.data --png foo.png /Users/xnor/local/src/ibmfonts/bdf/icl8x16u.bdf foo`
Error: invalid encoding

should I expect this to work? As a workaround, is it reasonable to hand edit the bdf and remove this entry?

[rfuest]

Sorry, I only tried the viewer and didn't check the converter, I'll take another look.

[rfuest]

Please try it again, #41 should have fixed this. I hadn't noticed the issue in my tests because I had always converted only a subset of the font and never tried to include all glyphs. By adding a parameter like --mapping ASCII to the converter converter call it would have worked even without the latest PR.

[x37v]

conversion works, thanks @rfuest