From f29507be0e2e34fca1fc58d7128adebb6b6be08b Mon Sep 17 00:00:00 2001 From: Noah Gregory Date: Sun, 1 Feb 2026 16:12:15 -0500 Subject: [PATCH 1/5] fix: override docusarus style to keep button outlines --- src/css/custom.scss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/css/custom.scss b/src/css/custom.scss index e2e2d13c6..f88f36c42 100644 --- a/src/css/custom.scss +++ b/src/css/custom.scss @@ -201,7 +201,11 @@ html { } .button { - &--outline { + &--outline, + // Docusaurus adds its own focus styles which we need to + // override here to avoid losing the outline. + // ref: https://github.com/electron/website/issues/1001 + body:not(.navigation-with-keyboard) &--outline:focus { outline: 1px solid; color: var(--ifm-color-primary); &:hover { From 5177bbb07e67268736ac71c34955ca76878afb00 Mon Sep 17 00:00:00 2001 From: Noah Gregory Date: Sun, 1 Feb 2026 16:13:33 -0500 Subject: [PATCH 2/5] fix: add missing focus indicator to outlined buttons --- src/css/custom.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/css/custom.scss b/src/css/custom.scss index f88f36c42..90b69d847 100644 --- a/src/css/custom.scss +++ b/src/css/custom.scss @@ -211,6 +211,9 @@ html { &:hover { color: var(--ifm-color-primary-dark); } + &:focus-visible { + outline: 1.5px solid; + } } &--electron { From 457bfcaa8a0140e4a8cd9997fd34b9fef7718c70 Mon Sep 17 00:00:00 2001 From: Noah Gregory Date: Sun, 1 Feb 2026 16:18:41 -0500 Subject: [PATCH 3/5] refactor: use hover indicator for focus indicator --- src/css/custom.scss | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/css/custom.scss b/src/css/custom.scss index 90b69d847..6c2525517 100644 --- a/src/css/custom.scss +++ b/src/css/custom.scss @@ -208,12 +208,9 @@ html { body:not(.navigation-with-keyboard) &--outline:focus { outline: 1px solid; color: var(--ifm-color-primary); - &:hover { + &:hover, &:focus-visible { color: var(--ifm-color-primary-dark); } - &:focus-visible { - outline: 1.5px solid; - } } &--electron { From 3ee0578b26101661659947a8d5126826b3be1f94 Mon Sep 17 00:00:00 2001 From: David Sanders Date: Mon, 9 Feb 2026 15:08:01 -0800 Subject: [PATCH 4/5] chore: add comment referencing upstream PR --- src/css/custom.scss | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/css/custom.scss b/src/css/custom.scss index 6c2525517..ae15b1f15 100644 --- a/src/css/custom.scss +++ b/src/css/custom.scss @@ -203,8 +203,10 @@ html { .button { &--outline, // Docusaurus adds its own focus styles which we need to - // override here to avoid losing the outline. + // override here to avoid losing the outline. This can be + // removed when we pick up the upstream fix in Docusaurus. // ref: https://github.com/electron/website/issues/1001 + // ref: https://github.com/facebook/docusaurus/pull/11713 body:not(.navigation-with-keyboard) &--outline:focus { outline: 1px solid; color: var(--ifm-color-primary); From 492ce6af241e4cee2bdaf9ead41bbd3f48f58dd6 Mon Sep 17 00:00:00 2001 From: Noah Gregory Date: Mon, 9 Feb 2026 18:41:34 -0500 Subject: [PATCH 5/5] style: make linter happy --- src/css/custom.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/css/custom.scss b/src/css/custom.scss index ae15b1f15..5a76edccc 100644 --- a/src/css/custom.scss +++ b/src/css/custom.scss @@ -210,7 +210,8 @@ html { body:not(.navigation-with-keyboard) &--outline:focus { outline: 1px solid; color: var(--ifm-color-primary); - &:hover, &:focus-visible { + &:hover, + &:focus-visible { color: var(--ifm-color-primary-dark); } }