diff --git a/git_gc.py b/git_gc.py index 527adbe..719a4f2 100644 --- a/git_gc.py +++ b/git_gc.py @@ -6,7 +6,26 @@ tmp_dir = "extract" with tarfile.open(archive, mode="r:gz") as tar: - tar.extractall(tmp_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, tmp_dir) repo = git.Repo(os.path.join(tmp_dir, "app")) print(repo)