Skip to content

venv in install folder #77

@pardallio

Description

@pardallio

When building with ecbuild and exporting library headers, the install step takes especially long because it also installs the full fckit venv

if( ECBUILD_INSTALL_LIBRARY_HEADERS )
install( DIRECTORY ${VENV_PATH} DESTINATION . PATTERN "bin/*" PERMISSIONS ${install_permissions} )
endif()

It would be better to have a specific option for installing the venv by adding it on CMakelists.txt

ecbuild_add_option( FEATURE FCKIT_INSTALL_VENV
                    DEFAULT OFF
                    DESCRIPTION "Install Python virtual environment with fypp and a yaml parser"
                    CONDITION Python3_VERSION VERSION_GREATER_EQUAL 3.8 )

and change those lines in https://github.com/ecmwf/fckit/blob/42aef06cf245f9c75c85f85dcf3bcdb7c62d0ad3/cmake/fckit_install_venv.cmake to

if( HAVE_FCKIT_INSTALL_VENV )
       install( DIRECTORY ${VENV_PATH} DESTINATION . PATTERN "bin/*" PERMISSIONS ${install_permissions} )
    endif()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions