provide --arch-dir when creating bundle

[pardallio]

At the moment you can specify a bundle file at any given path but if it doesn't have an arch folder by its side. then the resulting bundle source directory gains a broken symlink instead of a symlink to an arch folder.

ecbundle/ecbundle/create.py

Line 71 in 412dfa1

symlink_force(os.path.dirname(bundle.file()) + "/arch", src_dir + "/arch")

If an --arch-dir could be provided to ecbundle create, this would help solve that issue.

This issue arises later when building because ecbundle build looks for archs in the folders src_dir + "/arch" and getcwd()

ecbundle/ecbundle/build.py

Line 396 in 412dfa1

arch_dirs = [src_dir + "/arch", getcwd()]

So if --arch-dir could be passed to ecbundle build and added to the arch_dirs list this would also solve the issue

[pardallio]

this is the error message I get

Traceback (most recent call last):
  File "/etc/ecmwf/nfs/dh2_home_b/prt2342/.local/bin/ecbundle-build", line 167, in <module>
    sys.exit(main())
  File "/etc/ecmwf/nfs/dh2_home_b/prt2342/.local/bin/ecbundle-build", line 164, in main
    build.build()
  File "/home/prt2342/.local/lib/python3.10/site-packages/ecbundle/build.py", line 596, in build
    backup_dir = self.backup_scripts()
  File "/home/prt2342/.local/lib/python3.10/site-packages/ecbundle/build.py", line 582, in backup_scripts
    copyfile(readlink(build_dir + "/" + f), backup_dir + "/" + f)
  File "/usr/local/apps/python3/3.10.10-01/lib/python3.10/shutil.py", line 254, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/ec/res4/scratch/prt2342/davai/build/dv-0002-atos_bologna@prt2342/source/arch/ecmwf/hpc2020/intel/2023.2.0/hpcx-openmpi/2.9.0/env.sh'
 Command failed: Command '['/ec/res4/scratch/prt2342/davai/build/dv-0002-atos_bologna@prt2342/IAL-bundle/ial-bundle', 'build', '--build-dir', '/ec/res4/scratch/prt2342/davai/build/dv-0002-atos_bologna@prt2342/bundle.intel_2023.2.0_hpcx-openmpi_2.9.0.dp', '--arch', '/ec/res4/scratch/prt2342/davai/build/dv-0002-atos_bologna@prt2342/IAL-bundle/arch/ecmwf/hpc2020/intel/2023.2.0/hpcx-openmpi/2.9.0', '--ninja', '-j64', '--src-dir', '/ec/res4/scratch/prt2342/davai/build/dv-0002-atos_bologna@prt2342/source', '--clean', '--reconfigure']' returned non-zero exit status 1.

[wdeconinck]

Hi @pardallio that sounds like a good solution.