From 61b167105c5f7b10845b8b675ad4ff5708516a3e Mon Sep 17 00:00:00 2001 From: sbAsma Date: Wed, 4 Feb 2026 13:54:27 +0100 Subject: [PATCH 1/7] changed model path to shared dir path --- src/weathergen/model/model_interface.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/weathergen/model/model_interface.py b/src/weathergen/model/model_interface.py index 23334749b..38079d411 100644 --- a/src/weathergen/model/model_interface.py +++ b/src/weathergen/model/model_interface.py @@ -21,7 +21,7 @@ ) from torch.distributed.tensor import distribute_tensor -from weathergen.common.config import Config, merge_configs +from weathergen.common.config import Config, merge_configs, _get_shared_wg_path from weathergen.model.attention import ( MultiCrossAttentionHeadVarlen, MultiCrossAttentionHeadVarlenSlicedQ, @@ -173,7 +173,7 @@ def load_model(cf, model, device, run_id: str, mini_epoch=-1): mini_epoch : The mini_epoch to load. Default (-1) is the latest mini_epoch """ - path_run = Path(cf.model_path) / run_id + path_run = _get_shared_wg_path() / "models" / run_id mini_epoch_id = ( f"chkpt{mini_epoch:05d}" if mini_epoch != -1 and mini_epoch is not None else "latest" ) From fcdd3607f1d35fd44d89e8522495b785491e7121 Mon Sep 17 00:00:00 2001 From: sbAsma Date: Wed, 4 Feb 2026 14:31:45 +0100 Subject: [PATCH 2/7] removed unused Path --- src/weathergen/model/model_interface.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/weathergen/model/model_interface.py b/src/weathergen/model/model_interface.py index 38079d411..38c27f871 100644 --- a/src/weathergen/model/model_interface.py +++ b/src/weathergen/model/model_interface.py @@ -11,7 +11,6 @@ import itertools import logging -from pathlib import Path import omegaconf import torch From 23c37c802c8f86471b67570778c1c801fd204572 Mon Sep 17 00:00:00 2001 From: sbAsma Date: Wed, 4 Feb 2026 14:34:44 +0100 Subject: [PATCH 3/7] added ruffing request --- src/weathergen/model/model_interface.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/weathergen/model/model_interface.py b/src/weathergen/model/model_interface.py index 38c27f871..578878f4a 100644 --- a/src/weathergen/model/model_interface.py +++ b/src/weathergen/model/model_interface.py @@ -15,12 +15,12 @@ import omegaconf import torch from torch.distributed.fsdp import ( - MixedPrecisionPolicy, fully_shard, + MixedPrecisionPolicy, ) from torch.distributed.tensor import distribute_tensor -from weathergen.common.config import Config, merge_configs, _get_shared_wg_path +from weathergen.common.config import _get_shared_wg_path, Config, merge_configs from weathergen.model.attention import ( MultiCrossAttentionHeadVarlen, MultiCrossAttentionHeadVarlenSlicedQ, From a969539b71612317c27382d4a12cbe3327b14f79 Mon Sep 17 00:00:00 2001 From: sbAsma Date: Fri, 6 Feb 2026 13:26:25 +0100 Subject: [PATCH 4/7] fixed path in load_run_config --- packages/common/src/weathergen/common/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/common/src/weathergen/common/config.py b/packages/common/src/weathergen/common/config.py index 794f829c6..8c3b593f9 100644 --- a/packages/common/src/weathergen/common/config.py +++ b/packages/common/src/weathergen/common/config.py @@ -232,7 +232,7 @@ def load_run_config(run_id: str, mini_epoch: int | None, model_path: str | None) if model_path is None: path = get_path_model(run_id=run_id) else: - path = Path(model_path) / run_id + path = _get_shared_wg_path() / "models" / run_id fname = path / _get_model_config_file_read_name(run_id, mini_epoch) assert fname.exists(), ( From 7f9692b658eac4c3141b295b4130bdc12f655501 Mon Sep 17 00:00:00 2001 From: sbAsma Date: Fri, 6 Feb 2026 13:29:04 +0100 Subject: [PATCH 5/7] added ruff fix --- src/weathergen/model/model_interface.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/weathergen/model/model_interface.py b/src/weathergen/model/model_interface.py index 827f45d89..02b64787b 100644 --- a/src/weathergen/model/model_interface.py +++ b/src/weathergen/model/model_interface.py @@ -15,12 +15,12 @@ import omegaconf import torch from torch.distributed.fsdp import ( - fully_shard, MixedPrecisionPolicy, + fully_shard, ) from torch.distributed.tensor import distribute_tensor -from weathergen.common.config import _get_shared_wg_path, Config, merge_configs +from weathergen.common.config import Config, _get_shared_wg_path, merge_configs from weathergen.model.attention import ( MultiCrossAttentionHeadVarlen, MultiCrossAttentionHeadVarlenSlicedQ, From ba1a595860658d436eb91df7ab2655ab89f1fac0 Mon Sep 17 00:00:00 2001 From: sbAsma Date: Thu, 12 Feb 2026 03:45:34 +0100 Subject: [PATCH 6/7] reverted change and added logging --- packages/common/src/weathergen/common/config.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/common/src/weathergen/common/config.py b/packages/common/src/weathergen/common/config.py index 8c3b593f9..1a57725db 100644 --- a/packages/common/src/weathergen/common/config.py +++ b/packages/common/src/weathergen/common/config.py @@ -231,8 +231,10 @@ def load_run_config(run_id: str, mini_epoch: int | None, model_path: str | None) # Load model config here. In case model_path is not provided, get it from private conf if model_path is None: path = get_path_model(run_id=run_id) + _logger.info(f"Loading config from default model_path: {path}") else: - path = _get_shared_wg_path() / "models" / run_id + path = Path(model_path) / run_id + _logger.info(f"Loading config from provided model_path: {path}") fname = path / _get_model_config_file_read_name(run_id, mini_epoch) assert fname.exists(), ( From 2382bbddbd2408baad444d4021f5e1ff39fd4bc0 Mon Sep 17 00:00:00 2001 From: sbAsma Date: Thu, 12 Feb 2026 03:47:38 +0100 Subject: [PATCH 7/7] used implemented method for model path --- src/weathergen/model/model_interface.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/weathergen/model/model_interface.py b/src/weathergen/model/model_interface.py index 02b64787b..4a0339984 100644 --- a/src/weathergen/model/model_interface.py +++ b/src/weathergen/model/model_interface.py @@ -20,7 +20,7 @@ ) from torch.distributed.tensor import distribute_tensor -from weathergen.common.config import Config, _get_shared_wg_path, merge_configs +from weathergen.common.config import Config, get_path_model, merge_configs from weathergen.model.attention import ( MultiCrossAttentionHeadVarlen, MultiCrossAttentionHeadVarlenSlicedQ, @@ -178,7 +178,7 @@ def load_model(cf, model, device, run_id: str, mini_epoch=-1): mini_epoch : The mini_epoch to load. Default (-1) is the latest mini_epoch """ - path_run = _get_shared_wg_path() / "models" / run_id + path_run = get_path_model(run_id=run_id) mini_epoch_id = ( f"chkpt{mini_epoch:05d}" if mini_epoch != -1 and mini_epoch is not None else "latest" )