🐛 Can't find the subclass features for TDCSR & TCE Twilight Cleric

[SltCKira]

Describe the bug

I have been having this problem with using only 2024 rules with classes from TDCSR & Twilight Domain from TCE where the software couldn't find the subclass features and in the case of twilight domain the subclass itself.

I have been using this config file :

config.json
ttrpg-convert.out.txt

Expected Behavior

The subclasses getting their subclass features the same way you would get them using the 2014 rules in the config file.

TTRPG CLI Version

399-Snapshot

Which Operating Systems have you experienced this on?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

[jboehm77]

I also experience these messages in my output. However I've checked the subclass files that get generated and they don't appear to be missing the features that are mentioned in the warnings. Can you confirm that content isn't getting generated for you?

[drob0009]

On a fresh run for me with I got:

Subclass subclass|twilight domain|cleric|phb|tce not found for {@subclassfeature Blessed Strikes|Cleric|PHB|Twilight|TCE|8|TCE} in book|book-tce

and the output block for twilight cleric is in fact missing the Blessed Strikes section.

[jboehm77]

Keep in mind if you're using 2024 rules, Clerics get Blessed Strikes through their base class and not their subclass. So the Blessed Strikes subclass feature not appearing in the files wouldn't be a bug in that scenario.

[jboehm77]

As of 26b2c0b I only observe this issue specifically for the Twilight Cleric. No TDCSR subclasses throw the warning anymore.

[ebullient]

It's possibly because they aren't there anymore (unless you re-added TDCSR from homebrew?)

[jboehm77]

Yeah I made sure they were included as homebrew and that the subclasses weren't missing any features.

[jboehm77]

I've determined that the TDCSR warnings are now just failing silently. The crux of the issue here seems to be that the tool is attempting to link features that are mapped to the old base classes, which is fine unless you're using a setup defaulting to 2024 classes. It probably doesn't have a check for homebrew subclasses for these sorts of links, so they end up getting generated even though they aren't resolvable (e.g. in juggernaut barbarian, there's a link [Thunderous Blows](/compendium/classes/barbarian-phb-path-of-the-juggernaut-taldoreicampaignsettingreborn.md#Thunderous%20Blows%20(Level%203)) that's broken because it's pointing to barbarian-phb instead of barbarian-xphb). There is likely a link in TCE pointing to the Twilight Cleric's Blessed Strikes feature that doesn't apply to the 2024 version of the class which overrides that subclass feature, hence the warning.

The fix here would then be to somehow catch these links pointing to classes from a different edition and redirect them, or in the case of deprecated subclass features like in Twilight Cleric, do nothing?

Either way, I'm not sure this issue should be closed, given this information.

[ebullient]

I should already be checking for those relationships (I thought), and dropping them if they don't apply, but there are so many corner cases here that getting it right is nigh impossible (which is why I have all of the information in the logs about what is getting kept vs. dropped). That _phb_ link should only exist if the PHB is an included source. There may be a corner case here if the default source has changed..