Xattr not passed correctly to OSX?

[sepiroth887]

Hi,

I am working on a Ramdisk implementation using fuse4j. So far almost everything works quite nicely.

listing xattributes in terminal via ls -l@ shows some weird behaviour. Find below a printout of the console part :

-rw-r--r--@ 1 tobiashaag staff 346 29 Mar 16:44 sdfgsdfg.rtf
com.apple.quarantine 23
-CDEF000000 -1

if i run ls -l@ again this is the result :

-rw-r--r--@ 1 tobiashaag staff 346 29 Mar 16:44 sdfgsdfg.rtf
com.apple.quarantine 23
-1
-1

seems some arbitrary memory locations are read, i.e the buffer for the attribute name in the listxattr() method seems to be the culprit.

Let me know if its just an implementation issue on my end or whether another fix is needed.

Thanks and great work !

Tobi

[sepiroth887]

some further prodding revealed that the xattr name size as calculated by XAttrSizeSetter is not exactly the size of the name under some circumstances which means that the buffer is to big and random memory locations are read after the last nil terminator.

I have fixed this issue on my fork as well and could make another pull request if you like but it really is a one-line change:

Filesystem3ToFuseFSAdapter.java:470

replace: size+= (int) ((float)xattrName * enc......
with : size += xattrName.getBytes("UTF-8").length+1

.getBytes() can throw an exception so surround with try catch.

cheers,

Tobi