From 92c27df0340941ba29d368fd52c50872fd5055bf Mon Sep 17 00:00:00 2001 From: Philipp Jahn Date: Sat, 29 Nov 2025 18:01:42 +0100 Subject: [PATCH] fixed buffers in tests writing to expected value slice --- primitives_test.go | 15 ++++++++++----- simple_test.go | 9 ++++++--- strings_test.go | 6 ++++-- 3 files changed, 20 insertions(+), 10 deletions(-) diff --git a/primitives_test.go b/primitives_test.go index 8856c45..8f9500e 100644 --- a/primitives_test.go +++ b/primitives_test.go @@ -28,7 +28,8 @@ func TestUInt(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if n, err := ReadUInt(buff); err != nil { t.Fatal(err) } else if n != test.numb { @@ -82,7 +83,8 @@ func TestByteStringLen(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if n, err := ReadByteStringLen(buff); err != nil { t.Fatal(err) } else if n != test.len { @@ -116,7 +118,8 @@ func TestTextStringLen(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if n, err := ReadTextStringLen(buff); err != nil { t.Fatal(err) } else if n != test.len { @@ -149,7 +152,8 @@ func TestArrayLen(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if n, err := ReadArrayLength(buff); err != nil { t.Fatal(err) } else if n != test.len { @@ -182,7 +186,8 @@ func TestMapPairLen(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if n, err := ReadMapPairLength(buff); err != nil { t.Fatal(err) } else if n != test.len { diff --git a/simple_test.go b/simple_test.go index 64260ea..e78b638 100644 --- a/simple_test.go +++ b/simple_test.go @@ -17,7 +17,8 @@ func TestBoolean(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if b, err := ReadBoolean(buff); err != nil { t.Fatal(err) } else if b != test.b { @@ -47,7 +48,8 @@ func TestFloat32(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if f, err := ReadFloat32(buff); err != nil { t.Fatal(err) } else if f != test.f { @@ -78,7 +80,8 @@ func TestFloat64(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.data) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.data) if f, err := ReadFloat64(buff); err != nil { t.Fatal(err) } else if f != test.f { diff --git a/strings_test.go b/strings_test.go index 5f93421..bea51e1 100644 --- a/strings_test.go +++ b/strings_test.go @@ -26,7 +26,8 @@ func TestByteString(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.cbor) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.cbor) if data, err := ReadByteString(buff); err != nil { t.Fatal(err) } else if !reflect.DeepEqual(data, test.data) { @@ -122,7 +123,8 @@ func TestReadTextString(t *testing.T) { for _, test := range tests { // Read - buff := bytes.NewBuffer(test.cbor) + buff := &bytes.Buffer{} + _, _ = buff.Write(test.cbor) if data, err := ReadTextString(buff); err != nil { t.Fatal(err) } else if data != test.data {