From 8aa11ad47d83f210f7e01f87aad24e8ab8dc2639 Mon Sep 17 00:00:00 2001 From: Jeffery Chen Fan Date: Mon, 21 Sep 2015 00:53:36 +0800 Subject: [PATCH] as the sender of mail handler is invalid, fix this use default sender address < trapperkeeper@localhost> ERROR:root:Callback Failed: (501, ': sender address must contain a domain', 'trapperkeeper') Traceback (most recent call last): File "build/bdist.linux-x86_64/egg/trapperkeeper/callbacks.py", line 43, in __call__ self._call(*args, **kwargs) File "build/bdist.linux-x86_64/egg/trapperkeeper/callbacks.py", line 171, in _call self._send_mail(handler, trap, duplicate) File "build/bdist.linux-x86_64/egg/trapperkeeper/callbacks.py", line 72, in _send_mail subject, self.template_env, ctxt) File "build/bdist.linux-x86_64/egg/trapperkeeper/utils.py", line 127, in send_trap_email smtp.sendmail(sender, recipients, msg.as_string()) File "/usr/lib/python2.7/smtplib.py", line 731, in sendmail raise SMTPSenderRefused(code, resp, from_addr) SMTPSenderRefused: (501, ': sender address must contain a domain', 'trapperkeeper') --- trapperkeeper/callbacks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trapperkeeper/callbacks.py b/trapperkeeper/callbacks.py index 22f667c..c8dedc0 100644 --- a/trapperkeeper/callbacks.py +++ b/trapperkeeper/callbacks.py @@ -64,7 +64,7 @@ def _send_mail(self, handler, trap, is_duplicate): ctxt = dict(trap=trap, dest_host=self.hostname) try: stats.incr("mail_sent_attempted", 1) - send_trap_email(recipients, "trapperkeeper", + send_trap_email(recipients, "trapperkeeper@localhost", subject, self.template_env, ctxt) stats.incr("mail_sent_successful", 1) except socket.error as err: