From 6504f38ebe7e0c24c5f3802ed492daf2aad00309 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 20:58:01 +0300
Subject: [PATCH 01/98] RED

---
 tdd_intro/homework/01_leap_year/test.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index 4f186c8b..5e457262 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -13,3 +13,11 @@ If your language provides a method in the standard library that does this look-u
 */
 
 #include <gtest/gtest.h>
+
+
+
+
+TEST(LeapYear, DevidedBy4)
+{
+    ASSERT_TRUE(LeapYear(4));
+}

From 1fba6cee2919b17fac1614f642e1fc95f8090511 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:00:54 +0300
Subject: [PATCH 02/98] RED

---
 tdd_intro/homework/01_leap_year/test.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index 5e457262..c8e11e76 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -16,7 +16,6 @@ If your language provides a method in the standard library that does this look-u
 
 
 
-
 TEST(LeapYear, DevidedBy4)
 {
     ASSERT_TRUE(LeapYear(4));

From c035067f6b7b6f3e2136a9528864e5685506cfae Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:07:15 +0300
Subject: [PATCH 03/98] Green

---
 tdd_intro/homework/01_leap_year/test.cpp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index c8e11e76..9c8a77bb 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -14,7 +14,13 @@ If your language provides a method in the standard library that does this look-u
 
 #include <gtest/gtest.h>
 
-
+bool LeapYear(int year)
+{
+    if (year%4 == 0)
+    {
+        return true;
+    }
+}
 
 TEST(LeapYear, DevidedBy4)
 {

From b7958867fb7b6883f71df9091e4189bad479ea0d Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:14:42 +0300
Subject: [PATCH 04/98] Red

---
 tdd_intro/homework/01_leap_year/test.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index 9c8a77bb..693796f0 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -20,9 +20,15 @@ bool LeapYear(int year)
     {
         return true;
     }
+    return false;
 }
 
 TEST(LeapYear, DevidedBy4)
 {
     ASSERT_TRUE(LeapYear(4));
 }
+
+TEST(LeapYear, DevidedBy100)
+{
+    ASSERT_FALSE(LeapYear(100));
+}

From 553eac29dd0ad0953ca2ee04aa8e9bffb119b0aa Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:15:39 +0300
Subject: [PATCH 05/98] Green

---
 tdd_intro/homework/01_leap_year/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index 693796f0..f986a8cd 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -16,6 +16,10 @@ If your language provides a method in the standard library that does this look-u
 
 bool LeapYear(int year)
 {
+    if (year%100 == 0)
+    {
+        return false;
+    }
     if (year%4 == 0)
     {
         return true;

From 6e72467fac2f530a4c9d1de212409fec6e1f438e Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:17:15 +0300
Subject: [PATCH 06/98] Red

---
 tdd_intro/homework/01_leap_year/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index f986a8cd..9ca987c2 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -36,3 +36,8 @@ TEST(LeapYear, DevidedBy100)
 {
     ASSERT_FALSE(LeapYear(100));
 }
+
+TEST(LeapYear, DevidedBy400)
+{
+    ASSERT_TRUE(LeapYear(400));
+}

From 03397ddbe6618046fedca06287b69808cf50705a Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:18:27 +0300
Subject: [PATCH 07/98] Green

---
 tdd_intro/homework/01_leap_year/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index 9ca987c2..436c9b13 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -16,6 +16,10 @@ If your language provides a method in the standard library that does this look-u
 
 bool LeapYear(int year)
 {
+    if (year%400 == 0)
+    {
+        return true;
+    }
     if (year%100 == 0)
     {
         return false;

From 35d5e67675b3eed09006f146361b9fb444e7c42c Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:21:17 +0300
Subject: [PATCH 08/98] Green

---
 tdd_intro/homework/01_leap_year/test.cpp | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index 436c9b13..6b243f52 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -45,3 +45,13 @@ TEST(LeapYear, DevidedBy400)
 {
     ASSERT_TRUE(LeapYear(400));
 }
+
+TEST(LeapYear, RandomYearsTest)
+{
+    ASSERT_TRUE(LeapYear(2000));
+    ASSERT_FALSE(LeapYear(1000));
+    ASSERT_TRUE(LeapYear(1996));
+    ASSERT_FALSE(LeapYear(1997));
+    ASSERT_TRUE(LeapYear(2020));
+    ASSERT_FALSE(LeapYear(2018));
+}

From c823ffb6e5c99f911504914a2a09221b522fd818 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Tue, 2 Oct 2018 21:22:26 +0300
Subject: [PATCH 09/98] Green

---
 tdd_intro/homework/01_leap_year/test.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tdd_intro/homework/01_leap_year/test.cpp b/tdd_intro/homework/01_leap_year/test.cpp
index 6b243f52..9f60fafd 100644
--- a/tdd_intro/homework/01_leap_year/test.cpp
+++ b/tdd_intro/homework/01_leap_year/test.cpp
@@ -54,4 +54,6 @@ TEST(LeapYear, RandomYearsTest)
     ASSERT_FALSE(LeapYear(1997));
     ASSERT_TRUE(LeapYear(2020));
     ASSERT_FALSE(LeapYear(2018));
+    ASSERT_TRUE(LeapYear(-2000));
+    ASSERT_FALSE(LeapYear(-1000));
 }

From 1161ec0f440dcae85c8b0c60ac3d59fa34801307 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:01:32 +0300
Subject: [PATCH 10/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index 17503028..0f7b983f 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -16,3 +16,11 @@ The last place in a ternary number is the 1's place. The second to last is the 3
 
 If your language provides a method in the standard library to perform the conversion, pretend it doesn't exist and implement it yourself.
 */
+
+#include <gtest/gtest.h>
+
+
+TEST(TernaryNumbers, EmptyString)
+{
+    ASSERT_EQ(0, DemicalView(""));
+}

From 20c6e9d92eecf5e1c2ccb846743b8c081c88082d Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:18:21 +0300
Subject: [PATCH 11/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index 0f7b983f..c5123bed 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -19,6 +19,10 @@ If your language provides a method in the standard library to perform the conver
 
 #include <gtest/gtest.h>
 
+int DemicalView(std::string str)
+{
+    return 0;
+}
 
 TEST(TernaryNumbers, EmptyString)
 {

From 5a8042ed03e7acb85bad01dac4938b93d4887600 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:20:23 +0300
Subject: [PATCH 12/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index c5123bed..081a6554 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -28,3 +28,8 @@ TEST(TernaryNumbers, EmptyString)
 {
     ASSERT_EQ(0, DemicalView(""));
 }
+
+TEST(TernaryNumbers, EqualOne)
+{
+    ASSERT_EQ(1, DemicalView("1"));
+}

From 86ac94c65cf03721bd2fe3450035e3a6690e9533 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:22:25 +0300
Subject: [PATCH 13/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index 081a6554..c68f93f1 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -21,6 +21,10 @@ If your language provides a method in the standard library to perform the conver
 
 int DemicalView(std::string str)
 {
+    if (str == "1")
+    {
+        return 1;
+    }
     return 0;
 }
 

From d3940b85f12e0d44bad0f5a984ea042752916377 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:23:18 +0300
Subject: [PATCH 14/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index c68f93f1..50e53d79 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -37,3 +37,8 @@ TEST(TernaryNumbers, EqualOne)
 {
     ASSERT_EQ(1, DemicalView("1"));
 }
+
+TEST(TernaryNumbers, EqualTwo)
+{
+    ASSERT_EQ(2, DemicalView("2"));
+}

From 37b3eca7bc71fd4ea94fc6601db57b8b9c823de6 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:25:07 +0300
Subject: [PATCH 15/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index 50e53d79..e6abe59e 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -25,6 +25,15 @@ int DemicalView(std::string str)
     {
         return 1;
     }
+    if (str == "2")
+    {
+        return 2;
+    }
+    if (str == "0")
+    {
+        return 0;
+    }
+
     return 0;
 }
 

From 420c40f7905d0e700edc16a232564b257007feb5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:27:38 +0300
Subject: [PATCH 16/98] Refactored Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index e6abe59e..96be080f 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -21,19 +21,10 @@ If your language provides a method in the standard library to perform the conver
 
 int DemicalView(std::string str)
 {
-    if (str == "1")
+    if (str == "1" || str == "2" || str == "3")
     {
-        return 1;
+        return std::stoi( str );
     }
-    if (str == "2")
-    {
-        return 2;
-    }
-    if (str == "0")
-    {
-        return 0;
-    }
-
     return 0;
 }
 

From bce290fe7908731cd674dbbab01eb8e7ff52ddac Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:29:20 +0300
Subject: [PATCH 17/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index 96be080f..386ed64b 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -42,3 +42,8 @@ TEST(TernaryNumbers, EqualTwo)
 {
     ASSERT_EQ(2, DemicalView("2"));
 }
+
+TEST(TernaryNumbers, TwoCharString)
+{
+    ASSERT_EQ(1, DemicalView("01"));
+}

From d7cec8e51322ad7035ad0228fc6c477573f9bb9b Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:53:00 +0300
Subject: [PATCH 18/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 .../homework/02_ternary_numbers/test.cpp      | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index 386ed64b..d9afaa21 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -19,13 +19,26 @@ If your language provides a method in the standard library to perform the conver
 
 #include <gtest/gtest.h>
 
-int DemicalView(std::string str)
+int OneSignDemicalView(const std::string& oneSign)
 {
-    if (str == "1" || str == "2" || str == "3")
+    if (oneSign == "1" || oneSign == "2" || oneSign == "0")
     {
-        return std::stoi( str );
+
+        return std::stoi( oneSign );
     }
-    return 0;
+    return -1;
+}
+
+int DemicalView(const std::string& str)
+{
+    if (str.empty())
+    {
+        return 0;
+    }
+    int answer = 0;
+    answer += OneSignDemicalView(str.substr(str.size() - 1 , 1));
+
+    return (answer > 0)? answer : 0;
 }
 
 TEST(TernaryNumbers, EmptyString)
@@ -43,7 +56,7 @@ TEST(TernaryNumbers, EqualTwo)
     ASSERT_EQ(2, DemicalView("2"));
 }
 
-TEST(TernaryNumbers, TwoCharString)
+TEST(TernaryNumbers, TwoSignString)
 {
     ASSERT_EQ(1, DemicalView("01"));
 }

From 826c85ee20ba0672bea63dad63da9820bf1411e5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 14:53:58 +0300
Subject: [PATCH 19/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index d9afaa21..f9444b83 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -36,6 +36,7 @@ int DemicalView(const std::string& str)
         return 0;
     }
     int answer = 0;
+
     answer += OneSignDemicalView(str.substr(str.size() - 1 , 1));
 
     return (answer > 0)? answer : 0;
@@ -56,7 +57,12 @@ TEST(TernaryNumbers, EqualTwo)
     ASSERT_EQ(2, DemicalView("2"));
 }
 
-TEST(TernaryNumbers, TwoSignString)
+TEST(TernaryNumbers, TwoSignString01)
 {
     ASSERT_EQ(1, DemicalView("01"));
 }
+
+TEST(TernaryNumbers, TwoSignString11)
+{
+    ASSERT_EQ(4, DemicalView("11"));
+}

From dba60a2602eea7bf8c3b6156955fab9a43d914b9 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 15:02:11 +0300
Subject: [PATCH 20/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index f9444b83..d530018c 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -36,10 +36,11 @@ int DemicalView(const std::string& str)
         return 0;
     }
     int answer = 0;
-
-    answer += OneSignDemicalView(str.substr(str.size() - 1 , 1));
-
-    return (answer > 0)? answer : 0;
+    for(size_t i = 1; i <= str.size(); ++i)
+    {
+        answer += OneSignDemicalView(str.substr(str.size() - i , 1)) * pow(3, i - 1) ;
+    }
+    return (answer > 0) ? answer : 0;
 }
 
 TEST(TernaryNumbers, EmptyString)
@@ -62,6 +63,7 @@ TEST(TernaryNumbers, TwoSignString01)
     ASSERT_EQ(1, DemicalView("01"));
 }
 
+
 TEST(TernaryNumbers, TwoSignString11)
 {
     ASSERT_EQ(4, DemicalView("11"));

From 8a30a05e2932c10cc3322c5327ee4ae95cc812e9 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 10 Oct 2018 15:03:11 +0300
Subject: [PATCH 21/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/02_ternary_numbers/test.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tdd_intro/homework/02_ternary_numbers/test.cpp b/tdd_intro/homework/02_ternary_numbers/test.cpp
index d530018c..8ab93634 100644
--- a/tdd_intro/homework/02_ternary_numbers/test.cpp
+++ b/tdd_intro/homework/02_ternary_numbers/test.cpp
@@ -68,3 +68,9 @@ TEST(TernaryNumbers, TwoSignString11)
 {
     ASSERT_EQ(4, DemicalView("11"));
 }
+
+
+TEST(TernaryNumbers, SpecifcationTest)
+{
+    ASSERT_EQ(302, DemicalView("102012"));
+}

From 9ebf07fba3b1be8e53fb9ae7bff0ee84cbef025f Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 09:53:53 +0300
Subject: [PATCH 22/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index cb4b28cb..6b45b100 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -194,3 +194,28 @@ const Display s_display123456789 = { "    _  _     _  _  _  _  _ ",
                                      "  | _| _||_||_ |_   ||_||_|",
                                      "  ||_  _|  | _||_|  ||_| _|"
 };
+
+// parse 1 number 0-9
+//  right numbers
+//  wrong numbers
+
+// parse line
+//  more than 27 symbols in string
+//  less than 27 symbols in string
+//  27 symbols in string
+
+// parse several structs
+
+
+
+//  assumptions:
+//   one function, take vector of Display and return vector of int
+//   second function, take 1 Display and return one int.
+//   third function, take 1 Digit and return one int.
+// No infirmation about wrong entry*
+
+
+TEST(Bank, NumberZero)
+{
+    ASSERT_EQ(0, ZipNumberParser(s_digit0));
+}

From 19f4597d8213da8396d3f2d58a1f9a6da220260b Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 09:55:37 +0300
Subject: [PATCH 23/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 6b45b100..a934041a 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -215,6 +215,13 @@ const Display s_display123456789 = { "    _  _     _  _  _  _  _ ",
 // No infirmation about wrong entry*
 
 
+int ZipNumberParser(const Digit& digit)
+{
+    return 0;
+}
+
+
+
 TEST(Bank, NumberZero)
 {
     ASSERT_EQ(0, ZipNumberParser(s_digit0));

From ac52868b6d05d2ff8d71630c13f9bdf56b3d6fba Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 09:57:16 +0300
Subject: [PATCH 24/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index a934041a..0a670e9f 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -226,3 +226,8 @@ TEST(Bank, NumberZero)
 {
     ASSERT_EQ(0, ZipNumberParser(s_digit0));
 }
+
+TEST(Bank, NumberOne)
+{
+    ASSERT_EQ(1, ZipNumberParser(s_digit1));
+}

From e2af60ab5befd947511f5abe431b68ec694f9b85 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:02:07 +0300
Subject: [PATCH 25/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 0a670e9f..abc2320d 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -212,12 +212,19 @@ const Display s_display123456789 = { "    _  _     _  _  _  _  _ ",
 //   one function, take vector of Display and return vector of int
 //   second function, take 1 Display and return one int.
 //   third function, take 1 Digit and return one int.
-// No infirmation about wrong entry*
+// No information about wrong entry*
 
 
 int ZipNumberParser(const Digit& digit)
 {
-    return 0;
+    if(digit.lines[0] == s_digit0.lines[0] && digit.lines[1] == s_digit0.lines[1] && digit.lines[2] == s_digit0.lines[2])
+    {
+        return 0;
+    }
+    if(digit.lines[0] == s_digit1.lines[0] && digit.lines[1] == s_digit1.lines[1] && digit.lines[2] == s_digit1.lines[2])
+    {
+        return 1;
+    }
 }
 
 

From ff3a01feda8d796ff0cbbea373ac65a46bbb34be Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:05:11 +0300
Subject: [PATCH 26/98] REFACTORING Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index abc2320d..0c251fc9 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -214,14 +214,18 @@ const Display s_display123456789 = { "    _  _     _  _  _  _  _ ",
 //   third function, take 1 Digit and return one int.
 // No information about wrong entry*
 
+bool CompareDigits(const Digit& left, const Digit& right)
+{
+    return left.lines[0] == right.lines[0] && left.lines[1] == right.lines[1] && left.lines[2] == right.lines[2];
+}
 
 int ZipNumberParser(const Digit& digit)
 {
-    if(digit.lines[0] == s_digit0.lines[0] && digit.lines[1] == s_digit0.lines[1] && digit.lines[2] == s_digit0.lines[2])
+    if( CompareDigits(digit, s_digit0) )
     {
         return 0;
     }
-    if(digit.lines[0] == s_digit1.lines[0] && digit.lines[1] == s_digit1.lines[1] && digit.lines[2] == s_digit1.lines[2])
+    if( CompareDigits(digit, s_digit1) )
     {
         return 1;
     }

From 42618c4e3fd661a8146750c99f223631478e469a Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:14:38 +0300
Subject: [PATCH 27/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 0c251fc9..cf1edc5e 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -86,6 +86,7 @@ Example input and output
 */
 #include <gtest/gtest.h>
 #include <string>
+#include <vector>
 
 const unsigned short g_linesInDigit = 3;
 struct Digit
@@ -242,3 +243,8 @@ TEST(Bank, NumberOne)
 {
     ASSERT_EQ(1, ZipNumberParser(s_digit1));
 }
+
+TEST(Bank, NumberThree)
+{
+    ASSERT_EQ(3, ZipNumberParser(s_digit3));
+}

From 2bba6aa8cdca6c1a442e7a574765a8fa0545b206 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:15:17 +0300
Subject: [PATCH 28/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index cf1edc5e..4c57cbdf 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -230,6 +230,10 @@ int ZipNumberParser(const Digit& digit)
     {
         return 1;
     }
+    if( CompareDigits(digit, s_digit3) )
+    {
+        return 3;
+    }
 }
 
 

From a2bfbbc2daa09c5c944bc992ed8c3c4da86a7990 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:29:27 +0300
Subject: [PATCH 29/98] REFACTORED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 30 ++++++++++++++++---------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 4c57cbdf..078ea226 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -87,6 +87,7 @@ Example input and output
 #include <gtest/gtest.h>
 #include <string>
 #include <vector>
+#include <iterator>
 
 const unsigned short g_linesInDigit = 3;
 struct Digit
@@ -222,18 +223,27 @@ bool CompareDigits(const Digit& left, const Digit& right)
 
 int ZipNumberParser(const Digit& digit)
 {
-    if( CompareDigits(digit, s_digit0) )
+    std::vector<Digit> allNumbers;
+    allNumbers.reserve(10);
+    allNumbers.push_back(s_digit0);
+    allNumbers.push_back(s_digit1);
+    allNumbers.push_back(s_digit2);
+    allNumbers.push_back(s_digit3);
+    allNumbers.push_back(s_digit4);
+    allNumbers.push_back(s_digit5);
+    allNumbers.push_back(s_digit6);
+    allNumbers.push_back(s_digit7);
+    allNumbers.push_back(s_digit8);
+    allNumbers.push_back(s_digit9);
+
+    for (int i = 0; i < allNumbers.size(); ++i)
     {
-        return 0;
-    }
-    if( CompareDigits(digit, s_digit1) )
-    {
-        return 1;
-    }
-    if( CompareDigits(digit, s_digit3) )
-    {
-        return 3;
+        if ( CompareDigits(digit, allNumbers[i]) )
+        {
+            return i;
+        }
     }
+    return -1;
 }
 
 

From 7682935c4631e0d50d67da2730ac50533d99176f Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:32:42 +0300
Subject: [PATCH 30/98] GREEN wrongNumber Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 078ea226..0a1df499 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -141,6 +141,10 @@ const Digit s_digit9 = { " _ ",
                          "|_|",
                          " _|"
                        };
+const Digit s_noDigit = { " _ ",
+                          "|_|",
+                          " _ "
+                        };
 
 const Display s_displayAll0 = { " _  _  _  _  _  _  _  _  _ ",
                                 "| || || || || || || || || |",
@@ -262,3 +266,8 @@ TEST(Bank, NumberThree)
 {
     ASSERT_EQ(3, ZipNumberParser(s_digit3));
 }
+
+TEST(Bank, WrongNumber)
+{
+    ASSERT_EQ(-1, ZipNumberParser(s_noDigit));
+}

From 02f2d9cba203f854a0d128f9c77d5b39149883c5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:34:37 +0300
Subject: [PATCH 31/98] GREEN EmptyDigit Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 0a1df499..d02ba0bd 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -271,3 +271,9 @@ TEST(Bank, WrongNumber)
 {
     ASSERT_EQ(-1, ZipNumberParser(s_noDigit));
 }
+
+TEST(Bank, EmptyDigit)
+{
+    Digit emptyDigit{"", "", ""};
+    ASSERT_EQ(-1, ZipNumberParser(emptyDigit));
+}

From 9c8e7874140ed24227a40c320960695ac7fead30 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:37:37 +0300
Subject: [PATCH 32/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index d02ba0bd..c2d903b8 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -216,7 +216,7 @@ const Display s_display123456789 = { "    _  _     _  _  _  _  _ ",
 
 //  assumptions:
 //   one function, take vector of Display and return vector of int
-//   second function, take 1 Display and return one int.
+//   second function, take 1 Display and return one string with 9 digit.
 //   third function, take 1 Digit and return one int.
 // No information about wrong entry*
 
@@ -277,3 +277,8 @@ TEST(Bank, EmptyDigit)
     Digit emptyDigit{"", "", ""};
     ASSERT_EQ(-1, ZipNumberParser(emptyDigit));
 }
+
+TEST(Bank, LineOfZero)
+{
+    ASSERT_EQ("000000000", ZipLineParser(s_displayAll0));
+}

From d2109260688cdb764af8f36b6a53730b56b5c9f7 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:39:02 +0300
Subject: [PATCH 33/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index c2d903b8..e4528000 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -250,6 +250,10 @@ int ZipNumberParser(const Digit& digit)
     return -1;
 }
 
+std::string ZipLineParser(const Display& display)
+{
+    return "000000000";
+}
 
 
 TEST(Bank, NumberZero)

From 6b116930f50d3830cfea098283b2c42805f75745 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:40:48 +0300
Subject: [PATCH 34/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index e4528000..15739637 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -286,3 +286,8 @@ TEST(Bank, LineOfZero)
 {
     ASSERT_EQ("000000000", ZipLineParser(s_displayAll0));
 }
+
+TEST(Bank, LineOfOne)
+{
+    ASSERT_EQ("111111111", ZipLineParser(s_displayAll1));
+}

From 77c0cc5f2752d1003bf1cfe659a916db885dc0fd Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:48:44 +0300
Subject: [PATCH 35/98] RED Change test. So large step. Signed-off-by:
 Alexander Potapov <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 15739637..f44f77eb 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -278,7 +278,7 @@ TEST(Bank, WrongNumber)
 
 TEST(Bank, EmptyDigit)
 {
-    Digit emptyDigit{"", "", ""};
+    const Digit emptyDigit{"", "", ""};
     ASSERT_EQ(-1, ZipNumberParser(emptyDigit));
 }
 
@@ -287,7 +287,8 @@ TEST(Bank, LineOfZero)
     ASSERT_EQ("000000000", ZipLineParser(s_displayAll0));
 }
 
-TEST(Bank, LineOfOne)
+TEST(Bank, emptyDisplay)
 {
-    ASSERT_EQ("111111111", ZipLineParser(s_displayAll1));
+    Display emptyDisplay{"", "", ""};
+    ASSERT_EQ("-1", ZipLineParser(emptyDisplay));
 }

From 1dba3c5ba3e05b964fe53d003ffcf0f885e7d8d5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:50:40 +0300
Subject: [PATCH 36/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index f44f77eb..51ffc586 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -252,6 +252,10 @@ int ZipNumberParser(const Digit& digit)
 
 std::string ZipLineParser(const Display& display)
 {
+    if (display.lines[0].size() != 27 || display.lines[1].size() != 27 || display.lines[2].size() != 27)
+    {
+        return "-1";
+    }
     return "000000000";
 }
 

From cd01843d9e711295b3365a77fa27ea226628714f Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:52:50 +0300
Subject: [PATCH 37/98] GREEN largeDisplay Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 51ffc586..6b3ae258 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -296,3 +296,11 @@ TEST(Bank, emptyDisplay)
     Display emptyDisplay{"", "", ""};
     ASSERT_EQ("-1", ZipLineParser(emptyDisplay));
 }
+
+TEST(Bank, largeDisplay)
+{
+    Display largeDisplay{"______________________________",
+                         "___________________________",
+                         "___________________________"};
+    ASSERT_EQ("-1", ZipLineParser(largeDisplay));
+}

From 0ff6185171051a87beb763bc1497ba51ce324bc5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 10:54:58 +0300
Subject: [PATCH 38/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 6b3ae258..79e889cd 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -204,6 +204,7 @@ const Display s_display123456789 = { "    _  _     _  _  _  _  _ ",
 // parse 1 number 0-9
 //  right numbers
 //  wrong numbers
+//  empty digit
 
 // parse line
 //  more than 27 symbols in string
@@ -304,3 +305,7 @@ TEST(Bank, largeDisplay)
                          "___________________________"};
     ASSERT_EQ("-1", ZipLineParser(largeDisplay));
 }
+TEST(Bank, LineOf1)
+{
+    ASSERT_EQ("111111111", ZipLineParser(s_displayAll1));
+}

From 379997a37a0a8666adf13113c40a7bc4026d2dc6 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:05:46 +0300
Subject: [PATCH 39/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 79e889cd..74f1e907 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -257,6 +257,10 @@ std::string ZipLineParser(const Display& display)
     {
         return "-1";
     }
+    if (display.lines[0] == s_displayAll1.lines[0] && display.lines[1] == s_displayAll1.lines[1] && display.lines[2] == s_displayAll1.lines[2] )
+    {
+        return "111111111";
+    }
     return "000000000";
 }
 

From b4bcbf1e0561ebb644c155174a6179a033212faa Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:06:29 +0300
Subject: [PATCH 40/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 74f1e907..1515cb4c 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -313,3 +313,8 @@ TEST(Bank, LineOf1)
 {
     ASSERT_EQ("111111111", ZipLineParser(s_displayAll1));
 }
+
+TEST(Bank, LineOf2)
+{
+    ASSERT_EQ("222222222", ZipLineParser(s_displayAll2));
+}

From 8988a66b64ade595c13ee6f74c6ad54924e43be7 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:07:14 +0300
Subject: [PATCH 41/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 1515cb4c..af1c246d 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -261,6 +261,10 @@ std::string ZipLineParser(const Display& display)
     {
         return "111111111";
     }
+    if (display.lines[0] == s_displayAll2.lines[0] && display.lines[1] == s_displayAll2.lines[1] && display.lines[2] == s_displayAll2.lines[2] )
+    {
+        return "222222222";
+    }
     return "000000000";
 }
 

From 210e8a5fccab90396ea56d70d101a932727b6ae5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:24:21 +0300
Subject: [PATCH 42/98] REFACTORING Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index af1c246d..b00085ab 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -257,15 +257,23 @@ std::string ZipLineParser(const Display& display)
     {
         return "-1";
     }
-    if (display.lines[0] == s_displayAll1.lines[0] && display.lines[1] == s_displayAll1.lines[1] && display.lines[2] == s_displayAll1.lines[2] )
+    std::string answer="";
+    for(int i = 0; i < 27; i+=3)
     {
-        return "111111111";
-    }
-    if (display.lines[0] == s_displayAll2.lines[0] && display.lines[1] == s_displayAll2.lines[1] && display.lines[2] == s_displayAll2.lines[2] )
-    {
-        return "222222222";
+        Digit tempDigit{ std::string(display.lines[0].begin(),display.lines[0].begin()+3),
+                         std::string(display.lines[1].begin(),display.lines[1].begin()+3),
+                         std::string(display.lines[2].begin(),display.lines[2].begin()+3)};
+        int temp = ZipNumberParser(tempDigit);
+        if(temp == -1)
+        {
+            return "-1";
+        }
+        else
+        {
+            answer = answer + std::to_string(temp);
+        }
     }
-    return "000000000";
+    return answer;
 }
 
 

From f937abc77d3015ede76fb512520ee653de019f20 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:27:41 +0300
Subject: [PATCH 43/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index b00085ab..9ed254ab 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -330,3 +330,10 @@ TEST(Bank, LineOf2)
 {
     ASSERT_EQ("222222222", ZipLineParser(s_displayAll2));
 }
+
+TEST(Bank, Line123456789)
+{
+    ASSERT_EQ("123456789", ZipLineParser(s_display123456789));
+}
+
+

From 0de9281f761eeb5bc4c867f675d9ebbf5ac4b1d4 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:28:31 +0300
Subject: [PATCH 44/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 9ed254ab..24c466f0 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -260,9 +260,9 @@ std::string ZipLineParser(const Display& display)
     std::string answer="";
     for(int i = 0; i < 27; i+=3)
     {
-        Digit tempDigit{ std::string(display.lines[0].begin(),display.lines[0].begin()+3),
-                         std::string(display.lines[1].begin(),display.lines[1].begin()+3),
-                         std::string(display.lines[2].begin(),display.lines[2].begin()+3)};
+        Digit tempDigit{ std::string(display.lines[0].begin() + i,display.lines[0].begin()+3 + i),
+                         std::string(display.lines[1].begin() + i,display.lines[1].begin()+3 + i),
+                         std::string(display.lines[2].begin() + i,display.lines[2].begin()+3 + i)};
         int temp = ZipNumberParser(tempDigit);
         if(temp == -1)
         {

From 3e9433da608b9919f52c8d183804884981621b9d Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:32:43 +0300
Subject: [PATCH 45/98] GREEN wrongDisplay Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 24c466f0..81e25639 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -200,6 +200,10 @@ const Display s_display123456789 = { "    _  _     _  _  _  _  _ ",
                                      "  | _| _||_||_ |_   ||_||_|",
                                      "  ||_  _|  | _||_|  ||_| _|"
 };
+const Display s_wrongDisplay = { " _  _  _  _  _  _  _  _  _ ",
+                                 "|_||_||_||_||_||_||_||_||_|",
+                                 " _| _| _| _  _| _| _| _| _|"
+};
 
 // parse 1 number 0-9
 //  right numbers
@@ -336,4 +340,10 @@ TEST(Bank, Line123456789)
     ASSERT_EQ("123456789", ZipLineParser(s_display123456789));
 }
 
+TEST(Bank, WrongDispley)
+{
+    ASSERT_EQ("-1", ZipLineParser(s_wrongDisplay));
+}
+
+
 

From 523f777cda3af6cfd609ac930e3e62cd33d29e7f Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:35:48 +0300
Subject: [PATCH 46/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 81e25639..bc71b9ca 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -220,7 +220,7 @@ const Display s_wrongDisplay = { " _  _  _  _  _  _  _  _  _ ",
 
 
 //  assumptions:
-//   one function, take vector of Display and return vector of int
+//   one function, take vector of Display and return vector of string
 //   second function, take 1 Display and return one string with 9 digit.
 //   third function, take 1 Digit and return one int.
 // No information about wrong entry*
@@ -345,5 +345,16 @@ TEST(Bank, WrongDispley)
     ASSERT_EQ("-1", ZipLineParser(s_wrongDisplay));
 }
 
+TEST(Bank, TwoLines)
+{
+    std::vector<Display> linesOfDisplay;
+    linesOfDisplay.push_back(s_displayAll0);
+    linesOfDisplay.push_back(s_displayAll1);
+    std::vector<std::string> answer;
+    answer.push_back("000000000");
+    answer.push_back("111111111");
+    ASSERT_EQ(answer, ZipVectorParser(linesOfDisplay));
+}
+
 
 

From b3d10004e0fc1ff95f49b55fa4b22667da42625a Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:38:01 +0300
Subject: [PATCH 47/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index bc71b9ca..22095330 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -280,6 +280,14 @@ std::string ZipLineParser(const Display& display)
     return answer;
 }
 
+std::vector<std::string> ZipVectorParser(std::vector<Display> displays)
+{
+    std::vector<std::string> answer;
+    answer.push_back("000000000");
+    answer.push_back("111111111");
+    return answer;
+}
+
 
 TEST(Bank, NumberZero)
 {

From c7b98329a2d80d14485cbfaf4047844b4e8922a5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:39:43 +0300
Subject: [PATCH 48/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 22095330..ef1d3667 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -364,5 +364,18 @@ TEST(Bank, TwoLines)
     ASSERT_EQ(answer, ZipVectorParser(linesOfDisplay));
 }
 
+TEST(Bank, ThreeLines)
+{
+    std::vector<Display> linesOfDisplay;
+    linesOfDisplay.push_back(s_displayAll0);
+    linesOfDisplay.push_back(s_displayAll1);
+    linesOfDisplay.push_back(s_display123456789);
+    std::vector<std::string> answer;
+    answer.push_back("000000000");
+    answer.push_back("111111111");
+    answer.push_back("123456789");
+    ASSERT_EQ(answer, ZipVectorParser(linesOfDisplay));
+}
+
 
 

From ed19e6358bfd300de2f256dcf8090ea99fc4e1ce Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:46:05 +0300
Subject: [PATCH 49/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index ef1d3667..7faab400 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -283,8 +283,19 @@ std::string ZipLineParser(const Display& display)
 std::vector<std::string> ZipVectorParser(std::vector<Display> displays)
 {
     std::vector<std::string> answer;
-    answer.push_back("000000000");
-    answer.push_back("111111111");
+    if(displays.size() == 2)
+    {
+        answer.push_back("000000000");
+        answer.push_back("111111111");
+    }
+    else
+    {
+        answer.push_back("000000000");
+        answer.push_back("111111111");
+        answer.push_back("123456789");
+    }
+
+
     return answer;
 }
 

From b484a4b60f8f38a027f6f96bc00ce904cf9a2e20 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:47:42 +0300
Subject: [PATCH 50/98] REFACTORING Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 7faab400..2ec85bc8 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -283,19 +283,10 @@ std::string ZipLineParser(const Display& display)
 std::vector<std::string> ZipVectorParser(std::vector<Display> displays)
 {
     std::vector<std::string> answer;
-    if(displays.size() == 2)
+    for(auto disp:displays)
     {
-        answer.push_back("000000000");
-        answer.push_back("111111111");
+        answer.push_back(ZipLineParser(disp));
     }
-    else
-    {
-        answer.push_back("000000000");
-        answer.push_back("111111111");
-        answer.push_back("123456789");
-    }
-
-
     return answer;
 }
 

From f10a8dd7c47a0faa5d119d1298bc6ea010189d78 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 17 Oct 2018 11:49:23 +0300
Subject: [PATCH 51/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/03_bank_ocr/test.cpp | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/03_bank_ocr/test.cpp b/tdd_intro/homework/03_bank_ocr/test.cpp
index 2ec85bc8..06d3f3cc 100644
--- a/tdd_intro/homework/03_bank_ocr/test.cpp
+++ b/tdd_intro/homework/03_bank_ocr/test.cpp
@@ -379,5 +379,16 @@ TEST(Bank, ThreeLines)
     ASSERT_EQ(answer, ZipVectorParser(linesOfDisplay));
 }
 
-
+TEST(Bank, ThreeLinesWithWrongDisplay)
+{
+    std::vector<Display> linesOfDisplay;
+    linesOfDisplay.push_back(s_displayAll0);
+    linesOfDisplay.push_back(s_wrongDisplay);
+    linesOfDisplay.push_back(s_display123456789);
+    std::vector<std::string> answer;
+    answer.push_back("000000000");
+    answer.push_back("-1");
+    answer.push_back("123456789");
+    ASSERT_EQ(answer, ZipVectorParser(linesOfDisplay));
+}
 

From b833c67e22a00bfb6316fcfcc579a0bc7759edd7 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 17:18:30 +0300
Subject: [PATCH 52/98] The task. Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 105 ++++++++++++++----
 1 file changed, 82 insertions(+), 23 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 6b04a27c..0a87c44c 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -1,40 +1,99 @@
 /*
 Fake Weather Client
 
-You are going to develop a program that gets the statistics about weather in the cities using information from a certain server. Then the program calculates average values for collected statistics and generates a report.
-
-To communicate with the weather server you've already created the class WeatherServerClient, which gets the raw string from the server for the requested day or period of time. This class implements an interface IWeatherServerClient and actually communicates with the real server. You have to implement the parsing function for the raw responses via TDD, therefore, you need to create another IWeatherServerClient class with fake implementation, because interacting with real network is inacceptable within the unit tests.
-  
-The server answers with text of this format:
-    31.08.2018;03:00;20;181:5.1
-    31.08.2018;09:00;23;204:4.9
-    31.08.2018;15:00;33;193:4.3
-    31.08.2018;21:00;46;179:4.5
-    Where each line represents the time of the day and contains the next information: "<date>;<time>;<air_temperature_in_celsius>;<wind_direction_in_degrees>:<wind_speed>". Wind direction value may be in range from 0 to 359 inclusively, temperature may be negative.
-
-Your program should parse the answers from weather server and collect the average values of temperature, wind direction and speed for the given period of time. For the start, you have to implement the function which collect statistics for a single day for a given city. If you want to make your program more useful, implement the function which collects the statistics for the certain period of time.
+You are going to develop a program that gets the statistics about weather in the current city using information from a certain server.
+The goal is to calculate statistics using the data from weather server.
+
+To communicate with the weather server you have to implement interface IWeatherServer,
+which provides the raw string from the real server for the requested day and time.
+
+The real server (i.e. "weather.com") gets the requests in this format:
+"<date>;<time>", for example:
+"31.08.2018;03:00"
+
+The server answers on requests with string like this:
+"20;181;5.1"
+This string contains the weather for the requested time and means next:
+"<air_temperature_in_celsius>;<wind_direction_in_degrees>:<wind_speed>".
+Wind direction value may be in range from 0 to 359 inclusively, temperature may be negative.
+
+The task:
+1. Implement fake server, because interacting with real network is inacceptable within the unit tests.
+To do this, you need to use real server responses.
+Fortunately, you've collected some results for the several dates from the weather server. Each line means "<request>" : "<response>":
+
+"31.08.2018;03:00" : "20;181;5.1"
+"31.08.2018;09:00" : "23;204;4.9"
+"31.08.2018;15:00" : "33;193;4.3"
+"31.08.2018;21:00" : "26;179;4.5"
+
+"01.09.2018;03:00" : "19;176;4.2"
+"01.09.2018;09:00" : "22;131;4.1"
+"01.09.2018;15:00" : "31;109;4.0"
+"01.09.2018;21:00" : "24;127;4.1"
+
+"02.09.2018;03:00" : "21;158;3.8"
+"02.09.2018;09:00" : "25;201;3.5"
+"02.09.2018;15:00" : "34;258;3.7"
+"02.09.2018;21:00" : "27;299;4.0"
+
+IMPORTANT:
+* Server returns empty string if request is invalid.
+* Real server stores weather only for times 03:00, 09:00, 15:00 and 21:00 for every date. Do not use other hours in a day.
 */
 
 #include <gtest/gtest.h>
 #include <gmock/gmock.h>
 #include <string>
 
-class IWeatherServerClient
+struct Weather
+{
+    short temperature = 0;
+    unsigned short windDirection = 0;
+    double windSpeed = 0;
+    bool operator==(const Weather& right)
+    {
+        return temperature == right.temperature &&
+               windDirection == right.windDirection &&
+               std::abs(windSpeed - right.windSpeed) < 0.01;
+    }
+};
+
+class IWeatherServer
 {
 public:
-    virtual ~IWeatherServerClient() { }
-    // Returns raw statistics for the given day
-    std::string GetWeather(const std::string& city, const std::string& date);
-    // Returns raw statistics for the given period of time
-    std::string GetWeather(const std::string& city, const std::string& startDate, const std::string& endDate);
+    virtual ~IWeatherServer() { }
+    // Returns raw response with weather for the given day and time in request
+    virtual std::string GetWeather(const std::string& request) = 0;
 };
 
-// Stage 1: Get the average weather statistics for the single day
-struct Average
+
+class IWeatherClient
 {
-    // Your fields goes here
+public:
+    virtual ~IWeatherClient() { }
+    virtual double GetAverageTemperature(IWeatherServer& server, const std::string& date) = 0;
+    virtual double GetMinimumTemperature(IWeatherServer& server, const std::string& date) = 0;
+    virtual double GetMaximumTemperature(IWeatherServer& server, const std::string& date) = 0;
+    virtual double GetAverageWindDirection(IWeatherServer& server, const std::string& date) = 0;
+    virtual double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date) = 0;
 };
 
-// Stage 2 (optional): Get the average weather statistics for the given period of time
-using Averages = std::map<std::string, Average>; // <date, Average>
+/* Tests list:
+ * Parcer
+ * Parse string 20;181:5.1
+ * Parse string 20;181:7.1
+ * Parse string 20;182:7.2
+ * Parse string 21;183:7.3
+ * Parse string 22;184:7.4
+
+   Client
+   GetAverageTemperature
+   GetMinimumTemperature
+   GetMaximumTemperature
+
+
+   GetAverageWindDirection
+   GetMaximumWindSpeed
 
+  */

From 264875f01725868d981bc4bf492144993b3aa5e7 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 17:26:09 +0300
Subject: [PATCH 53/98] Fake Server Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 34 +++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 0a87c44c..508daf4f 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -97,3 +97,37 @@ class IWeatherClient
    GetMaximumWindSpeed
 
   */
+
+class FakeServer : public IWeatherServer
+{
+public:
+    FakeServer()
+    {
+        m_answers["31.08.2018;03:00"] = "20;181;5.1";
+        m_answers["31.08.2018;09:00"] = "23;204;4.9";
+        m_answers["31.08.2018;15:00"] = "33;193;4.3";
+        m_answers["31.08.2018;21:00"] = "26;179;4.5";
+
+        m_answers["01.09.2018;03:00"] = "19;176;4.2";
+        m_answers["01.09.2018;09:00"] = "22;131;4.1";
+        m_answers["01.09.2018;15:00"] = "31;109;4.0";
+        m_answers["01.09.2018;21:00"] = "24;127;4.1";
+
+        m_answers["02.09.2018;03:00"] = "21;158;3.8";
+        m_answers["02.09.2018;09:00"] = "25;201;3.5";
+        m_answers["02.09.2018;15:00"] = "34;258;3.7";
+        m_answers["02.09.2018;21:00"] = "27;299;4.0";
+    }
+    std::string GetWeather(const std::string& request)
+    {
+        std::string answer = "";
+        auto it = m_answers.find(request);
+        if(it != m_answers.end())
+        {
+            answer = m_answers[request];
+        }
+        return answer;
+    }
+private:
+    std::map<std::string, std::string> m_answers;
+};

From 92e1fb5a5e040cafbf477ab4bc80e5f0c2ee09e5 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 17:33:00 +0300
Subject: [PATCH 54/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 508daf4f..5d0847f1 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -131,3 +131,12 @@ class FakeServer : public IWeatherServer
 private:
     std::map<std::string, std::string> m_answers;
 };
+
+
+
+TEST (Weather, AverageTemperature_31_08 )
+{
+    double average = (20 + 23 + 33 + 26)/4. ;
+    WeatherClient wClient;
+    ASSERT_QE(average, wClient.GetAverageTemperature("31.08.2018"));
+}

From 906b7c911a600c93b3cc113122c49a02e3a8e74c Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 17:39:09 +0300
Subject: [PATCH 55/98] Red edit interface Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 5d0847f1..ede84aaf 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -132,11 +132,12 @@ class FakeServer : public IWeatherServer
     std::map<std::string, std::string> m_answers;
 };
 
+FakeServer g_fakeServer;
 
 
 TEST (Weather, AverageTemperature_31_08 )
 {
     double average = (20 + 23 + 33 + 26)/4. ;
     WeatherClient wClient;
-    ASSERT_QE(average, wClient.GetAverageTemperature("31.08.2018"));
+    ASSERT_QE(average, wClient.GetAverageTemperature(g_fakeServer, "31.08.2018"));
 }

From 2503a05cf9e87b4e276114e0d6197e232d47fdde Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 17:49:48 +0300
Subject: [PATCH 56/98] GREEN/ I have to declare all function, because have
 error: cannot construct abstract class Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 30 ++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index ede84aaf..220535f6 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -134,10 +134,38 @@ class FakeServer : public IWeatherServer
 
 FakeServer g_fakeServer;
 
+class WeatherClient: public IWeatherClient
+{
+public:
+    WeatherClient()
+    {}
+
+    double GetAverageTemperature(IWeatherServer& server, const std::string& date)
+    {
+        return (20 + 23 + 33 + 26)/4. ;
+    }
+    double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
+    {
+        return 0;
+    }
+    double GetMaximumTemperature(IWeatherServer& server, const std::string& date)
+    {
+        return 0;
+    }
+    double GetAverageWindDirection(IWeatherServer& server, const std::string& date)
+    {
+        return 0;
+    }
+    double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
+    {
+        return 0;
+    }
+};
+
 
 TEST (Weather, AverageTemperature_31_08 )
 {
     double average = (20 + 23 + 33 + 26)/4. ;
     WeatherClient wClient;
-    ASSERT_QE(average, wClient.GetAverageTemperature(g_fakeServer, "31.08.2018"));
+    ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "31.08.2018"));
 }

From f59e47634a96f04502f2daa633d9576c80548832 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 17:54:55 +0300
Subject: [PATCH 57/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 220535f6..871b868b 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -169,3 +169,10 @@ TEST (Weather, AverageTemperature_31_08 )
     WeatherClient wClient;
     ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "31.08.2018"));
 }
+
+TEST (Weather, AverageTemperature_01_09 )
+{
+    double average = (19 + 22 + 31 + 24)/4. ;
+    WeatherClient wClient;
+    ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "01.09.2018"));
+}

From 3731e3698faf6eb5f830f16688ce8b15c60f3a64 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 17:57:08 +0300
Subject: [PATCH 58/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 871b868b..97597e9b 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -142,7 +142,16 @@ class WeatherClient: public IWeatherClient
 
     double GetAverageTemperature(IWeatherServer& server, const std::string& date)
     {
-        return (20 + 23 + 33 + 26)/4. ;
+        double answer = 0;
+        if( date == "31.08.2018")
+        {
+            answer = (20 + 23 + 33 + 26)/4.;
+        }
+        else
+        {
+            answer = (19 + 22 + 31 + 24)/4.;
+        }
+        return answer ;
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
     {

From 21538a610bb5aa443a9136bbaa194429c8aee84f Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 18:00:24 +0300
Subject: [PATCH 59/98] RED Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 97597e9b..05bf2771 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -185,3 +185,10 @@ TEST (Weather, AverageTemperature_01_09 )
     WeatherClient wClient;
     ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "01.09.2018"));
 }
+
+TEST (Weather, AverageTemperature_02_09 )
+{
+    double average = (21 + 25 + 34 + 27)/4. ;
+    WeatherClient wClient;
+    ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "02.09.2018"));
+}

From 0e39ff85a6d39ada791125ee264be33b5a468920 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 18:01:27 +0300
Subject: [PATCH 60/98] GREEN Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 05bf2771..ddef7103 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -147,10 +147,14 @@ class WeatherClient: public IWeatherClient
         {
             answer = (20 + 23 + 33 + 26)/4.;
         }
-        else
+        if( date == "01.09.2018")
         {
             answer = (19 + 22 + 31 + 24)/4.;
         }
+        if( date == "02.09.2018")
+        {
+            answer = (21 + 25 + 34 + 27)/4. ;
+        }
         return answer ;
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)

From 8fa4f0f1468d03dda89709d64bde4e9df944b28a Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 18:26:59 +0300
Subject: [PATCH 61/98] Refactoring Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 33 +++++++++++--------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index ddef7103..e3b6b4ef 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -142,20 +142,7 @@ class WeatherClient: public IWeatherClient
 
     double GetAverageTemperature(IWeatherServer& server, const std::string& date)
     {
-        double answer = 0;
-        if( date == "31.08.2018")
-        {
-            answer = (20 + 23 + 33 + 26)/4.;
-        }
-        if( date == "01.09.2018")
-        {
-            answer = (19 + 22 + 31 + 24)/4.;
-        }
-        if( date == "02.09.2018")
-        {
-            answer = (21 + 25 + 34 + 27)/4. ;
-        }
-        return answer ;
+        return GetServerResponce(server, date);
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
     {
@@ -173,6 +160,24 @@ class WeatherClient: public IWeatherClient
     {
         return 0;
     }
+private:
+    double GetServerResponce(IWeatherServer& server, const std::string& date)
+    {
+        double answer = 0;
+        if( date == "31.08.2018")
+        {
+            answer = (20 + 23 + 33 + 26)/4.;
+        }
+        if( date == "01.09.2018")
+        {
+            answer = (19 + 22 + 31 + 24)/4.;
+        }
+        if( date == "02.09.2018")
+        {
+            answer = (21 + 25 + 34 + 27)/4. ;
+        }
+        return answer ;
+    }
 };
 
 

From eda379cd58364d2bc98baac358818fc8e7189795 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:04:45 +0300
Subject: [PATCH 62/98] Refactoring Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index e3b6b4ef..3fa8b61e 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -142,7 +142,8 @@ class WeatherClient: public IWeatherClient
 
     double GetAverageTemperature(IWeatherServer& server, const std::string& date)
     {
-        return GetServerResponce(server, date);
+        std::string strAnswer =  GetTemperature(date);
+        return atof(strAnswer.c_str());
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
     {
@@ -161,20 +162,20 @@ class WeatherClient: public IWeatherClient
         return 0;
     }
 private:
-    double GetServerResponce(IWeatherServer& server, const std::string& date)
+    std::string GetTemperature (const std::string& date)
     {
-        double answer = 0;
+        std::string answer = "";
         if( date == "31.08.2018")
         {
-            answer = (20 + 23 + 33 + 26)/4.;
+            answer = "25.5";
         }
         if( date == "01.09.2018")
         {
-            answer = (19 + 22 + 31 + 24)/4.;
+            answer = "24";
         }
         if( date == "02.09.2018")
         {
-            answer = (21 + 25 + 34 + 27)/4. ;
+            answer = "26.75" ;
         }
         return answer ;
     }
@@ -201,3 +202,4 @@ TEST (Weather, AverageTemperature_02_09 )
     WeatherClient wClient;
     ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "02.09.2018"));
 }
+

From bfec61632b2855da2b16b07350733adae937b18e Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:19:16 +0300
Subject: [PATCH 63/98] Refactoring, I think it is wrong big step, but i cant
 find another way. Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 29 ++++++++-----------
 1 file changed, 12 insertions(+), 17 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 3fa8b61e..8302e5c6 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -142,8 +142,16 @@ class WeatherClient: public IWeatherClient
 
     double GetAverageTemperature(IWeatherServer& server, const std::string& date)
     {
-        std::string strAnswer =  GetTemperature(date);
-        return atof(strAnswer.c_str());
+        double answer = 0;
+        std::string at3 =  GetTemperatureAtTime(server, date, ";03:00");
+        std::string at9 =  GetTemperatureAtTime(server, date, ";09:00");
+        std::string at15 = GetTemperatureAtTime(server, date, ";15:00");
+        std::string at21 = GetTemperatureAtTime(server, date, ";21:00");
+        if (!at3.empty() && !at9.empty() && !at15.empty() && !at21.empty())
+        {
+            answer = ( atof(at3.c_str()) + atof(at9.c_str()) + atof(at15.c_str()) + atof(at21.c_str()) )/4;
+        }
+        return answer;
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
     {
@@ -162,22 +170,9 @@ class WeatherClient: public IWeatherClient
         return 0;
     }
 private:
-    std::string GetTemperature (const std::string& date)
+    std::string GetTemperatureAtTime (IWeatherServer& server, const std::string& date, const std::string& time)
     {
-        std::string answer = "";
-        if( date == "31.08.2018")
-        {
-            answer = "25.5";
-        }
-        if( date == "01.09.2018")
-        {
-            answer = "24";
-        }
-        if( date == "02.09.2018")
-        {
-            answer = "26.75" ;
-        }
-        return answer ;
+        return server.GetWeather(date + time); ;
     }
 };
 

From 7ef4e676a622f496cc7d92a500b264315ab3a488 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:30:02 +0300
Subject: [PATCH 64/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 8302e5c6..8e919086 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -134,6 +134,8 @@ class FakeServer : public IWeatherServer
 
 FakeServer g_fakeServer;
 
+
+
 class WeatherClient: public IWeatherClient
 {
 public:
@@ -172,7 +174,7 @@ class WeatherClient: public IWeatherClient
 private:
     std::string GetTemperatureAtTime (IWeatherServer& server, const std::string& date, const std::string& time)
     {
-        return server.GetWeather(date + time); ;
+        return server.GetWeather(date + time);
     }
 };
 
@@ -198,3 +200,7 @@ TEST (Weather, AverageTemperature_02_09 )
     ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "02.09.2018"));
 }
 
+TEST (Weather, ParseTemp)
+{
+    ASSERT_EQ("21", ParceTemperature("20;181;5.1"));
+}

From 9870c19e79c3afbfb8e4e0fb5bbae6db97a5e95b Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:31:58 +0300
Subject: [PATCH 65/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 8e919086..b2dd993d 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -134,7 +134,10 @@ class FakeServer : public IWeatherServer
 
 FakeServer g_fakeServer;
 
-
+std::string ParseTemperature(std::string text)
+{
+    return "21";
+}
 
 class WeatherClient: public IWeatherClient
 {
@@ -202,5 +205,5 @@ TEST (Weather, AverageTemperature_02_09 )
 
 TEST (Weather, ParseTemp)
 {
-    ASSERT_EQ("21", ParceTemperature("20;181;5.1"));
+    ASSERT_EQ("21", ParseTemperature("20;181;5.1"));
 }

From 9ebcbc219862cff367d81f5e34a749fd56a4b1c9 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:32:59 +0300
Subject: [PATCH 66/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index b2dd993d..9ee61b6e 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -203,7 +203,12 @@ TEST (Weather, AverageTemperature_02_09 )
     ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "02.09.2018"));
 }
 
-TEST (Weather, ParseTemp)
+TEST (Weather, ParseTemp21)
 {
-    ASSERT_EQ("21", ParseTemperature("20;181;5.1"));
+    ASSERT_EQ("21", ParseTemperature("21;181;5.1"));
+}
+
+TEST (Weather, ParseTemp20)
+{
+    ASSERT_EQ("20", ParseTemperature("20;181;5.1"));
 }

From 0967608dd22976e32ab538f4c25bb766679b3541 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:34:45 +0300
Subject: [PATCH 67/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 9ee61b6e..7b8337e6 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -136,7 +136,15 @@ FakeServer g_fakeServer;
 
 std::string ParseTemperature(std::string text)
 {
-    return "21";
+    if (text == "21;181;5.1")
+    {
+        return "21";
+    }
+    if (text == "20;181;5.1")
+    {
+        return "20";
+    }
+    return "";
 }
 
 class WeatherClient: public IWeatherClient

From c0abb999afb25bd3a2df113be4e25b25bad76fe8 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:39:29 +0300
Subject: [PATCH 68/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 7b8337e6..343b5e33 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -136,15 +136,8 @@ FakeServer g_fakeServer;
 
 std::string ParseTemperature(std::string text)
 {
-    if (text == "21;181;5.1")
-    {
-        return "21";
-    }
-    if (text == "20;181;5.1")
-    {
-        return "20";
-    }
-    return "";
+    std::size_t pos = text.find(";");      // position of "live" in str
+    return text.substr (0, pos);
 }
 
 class WeatherClient: public IWeatherClient
@@ -220,3 +213,4 @@ TEST (Weather, ParseTemp20)
 {
     ASSERT_EQ("20", ParseTemperature("20;181;5.1"));
 }
+

From 2071d91c3cf624ec3ac620fbcea07e704fb50305 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:39:49 +0300
Subject: [PATCH 69/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 343b5e33..d91610a7 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -214,3 +214,7 @@ TEST (Weather, ParseTemp20)
     ASSERT_EQ("20", ParseTemperature("20;181;5.1"));
 }
 
+TEST (Weather, ParseWindDir181)
+{
+    ASSERT_EQ("181", ParseWindDir("20;181;5.1"));
+}

From fda31f55f58cf1330542facda80bc2189f2e6cec Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:41:23 +0300
Subject: [PATCH 70/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index d91610a7..001ffe6a 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -136,10 +136,15 @@ FakeServer g_fakeServer;
 
 std::string ParseTemperature(std::string text)
 {
-    std::size_t pos = text.find(";");      // position of "live" in str
+    std::size_t pos = text.find(";");
     return text.substr (0, pos);
 }
 
+std::string ParseWindDir(std::string text)
+{
+    return "181";
+}
+
 class WeatherClient: public IWeatherClient
 {
 public:

From 313b2443101193ecb1b1ebf156f76edcec895068 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:42:12 +0300
Subject: [PATCH 71/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 001ffe6a..d34bfdc2 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -223,3 +223,8 @@ TEST (Weather, ParseWindDir181)
 {
     ASSERT_EQ("181", ParseWindDir("20;181;5.1"));
 }
+
+TEST (Weather, ParseWindDir20)
+{
+    ASSERT_EQ("20", ParseWindDir("20;20;5.1"));
+}

From 86df82c2d5d2c5214db27be04f1c86847fe7d152 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:53:54 +0300
Subject: [PATCH 72/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index d34bfdc2..9e0c8a92 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -142,7 +142,9 @@ std::string ParseTemperature(std::string text)
 
 std::string ParseWindDir(std::string text)
 {
-    return "181";
+    std::size_t startPos = text.find(";");
+    std::size_t size = text.substr(startPos + 1).find(";");
+    return text.substr(startPos + 1, size);
 }
 
 class WeatherClient: public IWeatherClient

From c7f172d7c832609be563afd4ea01e80f03f0d401 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:55:56 +0300
Subject: [PATCH 73/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 9e0c8a92..621a3bc6 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -230,3 +230,8 @@ TEST (Weather, ParseWindDir20)
 {
     ASSERT_EQ("20", ParseWindDir("20;20;5.1"));
 }
+
+TEST (Weather, ParseWindSpeed5_1)
+{
+    ASSERT_EQ("5.1", ParseWindSpeed("20;20;5.1"));
+}

From 486eb495b9016ef2de56402dcceb6d7cda3c80ae Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:57:06 +0300
Subject: [PATCH 74/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 621a3bc6..fc241eb9 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -147,6 +147,11 @@ std::string ParseWindDir(std::string text)
     return text.substr(startPos + 1, size);
 }
 
+std::string ParseWindSpeed(std::string text)
+{
+    return "5.1";
+}
+
 class WeatherClient: public IWeatherClient
 {
 public:

From 53c1358216a862cc667699a919bb39585fc617f1 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 19:58:21 +0300
Subject: [PATCH 75/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index fc241eb9..5154dc07 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -240,3 +240,8 @@ TEST (Weather, ParseWindSpeed5_1)
 {
     ASSERT_EQ("5.1", ParseWindSpeed("20;20;5.1"));
 }
+
+TEST (Weather, ParseWindSpeed5)
+{
+    ASSERT_EQ("5", ParseWindSpeed("20;20;5"));
+}

From 13a931a07e64e9161db1fb2558a7e6a2ae02f04b Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:02:11 +0300
Subject: [PATCH 76/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 5154dc07..4a9d3c3e 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -149,7 +149,9 @@ std::string ParseWindDir(std::string text)
 
 std::string ParseWindSpeed(std::string text)
 {
-    return "5.1";
+    std::size_t startPos = text.find(";");
+    std::size_t size = text.substr(startPos + 1).find(";");
+    return text.substr(startPos + size + 2);
 }
 
 class WeatherClient: public IWeatherClient

From 27f874e55735d12d3590d8b99a617f12d2b8a097 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:07:55 +0300
Subject: [PATCH 77/98] Refactoring/ But I deleted some tests, because
 functions became to private member Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 79 +++++++------------
 1 file changed, 28 insertions(+), 51 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 4a9d3c3e..ac25221f 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -134,26 +134,6 @@ class FakeServer : public IWeatherServer
 
 FakeServer g_fakeServer;
 
-std::string ParseTemperature(std::string text)
-{
-    std::size_t pos = text.find(";");
-    return text.substr (0, pos);
-}
-
-std::string ParseWindDir(std::string text)
-{
-    std::size_t startPos = text.find(";");
-    std::size_t size = text.substr(startPos + 1).find(";");
-    return text.substr(startPos + 1, size);
-}
-
-std::string ParseWindSpeed(std::string text)
-{
-    std::size_t startPos = text.find(";");
-    std::size_t size = text.substr(startPos + 1).find(";");
-    return text.substr(startPos + size + 2);
-}
-
 class WeatherClient: public IWeatherClient
 {
 public:
@@ -192,7 +172,34 @@ class WeatherClient: public IWeatherClient
 private:
     std::string GetTemperatureAtTime (IWeatherServer& server, const std::string& date, const std::string& time)
     {
-        return server.GetWeather(date + time);
+        std::string response = server.GetWeather(date + time);
+        if (response.empty())
+        {
+            return "";
+        }
+        else
+        {
+            return ParseTemperature(response);
+        }
+    }
+    std::string ParseTemperature(std::string text)
+    {
+        std::size_t pos = text.find(";");
+        return text.substr (0, pos);
+    }
+
+    std::string ParseWindDir(std::string text)
+    {
+        std::size_t startPos = text.find(";");
+        std::size_t size = text.substr(startPos + 1).find(";");
+        return text.substr(startPos + 1, size);
+    }
+
+    std::string ParseWindSpeed(std::string text)
+    {
+        std::size_t startPos = text.find(";");
+        std::size_t size = text.substr(startPos + 1).find(";");
+        return text.substr(startPos + size + 2);
     }
 };
 
@@ -217,33 +224,3 @@ TEST (Weather, AverageTemperature_02_09 )
     WeatherClient wClient;
     ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "02.09.2018"));
 }
-
-TEST (Weather, ParseTemp21)
-{
-    ASSERT_EQ("21", ParseTemperature("21;181;5.1"));
-}
-
-TEST (Weather, ParseTemp20)
-{
-    ASSERT_EQ("20", ParseTemperature("20;181;5.1"));
-}
-
-TEST (Weather, ParseWindDir181)
-{
-    ASSERT_EQ("181", ParseWindDir("20;181;5.1"));
-}
-
-TEST (Weather, ParseWindDir20)
-{
-    ASSERT_EQ("20", ParseWindDir("20;20;5.1"));
-}
-
-TEST (Weather, ParseWindSpeed5_1)
-{
-    ASSERT_EQ("5.1", ParseWindSpeed("20;20;5.1"));
-}
-
-TEST (Weather, ParseWindSpeed5)
-{
-    ASSERT_EQ("5", ParseWindSpeed("20;20;5"));
-}

From bc3911f75e98563d35dba19a2487060a09454638 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:10:35 +0300
Subject: [PATCH 78/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index ac25221f..ced1bba1 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -224,3 +224,10 @@ TEST (Weather, AverageTemperature_02_09 )
     WeatherClient wClient;
     ASSERT_EQ(average, wClient.GetAverageTemperature(g_fakeServer, "02.09.2018"));
 }
+
+TEST (Weather, MinTemperature_01_09 )
+{
+    double min = 19;
+    WeatherClient wClient;
+    ASSERT_EQ(min, wClient.GetMinimumTemperature(g_fakeServer, "01.09.2018"));
+}

From 0036771c38797514cb1c80f53f925b3342ba9afa Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:11:09 +0300
Subject: [PATCH 79/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index ced1bba1..ab04c00a 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -155,7 +155,7 @@ class WeatherClient: public IWeatherClient
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
     {
-        return 0;
+        return 19;
     }
     double GetMaximumTemperature(IWeatherServer& server, const std::string& date)
     {

From a5690264e427da993f6cd79bdb0ec4b4427b53c9 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:11:48 +0300
Subject: [PATCH 80/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index ab04c00a..b37a5c9b 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -231,3 +231,10 @@ TEST (Weather, MinTemperature_01_09 )
     WeatherClient wClient;
     ASSERT_EQ(min, wClient.GetMinimumTemperature(g_fakeServer, "01.09.2018"));
 }
+
+TEST (Weather, MinTemperature_02_09 )
+{
+    double min = 21;
+    WeatherClient wClient;
+    ASSERT_EQ(min, wClient.GetMinimumTemperature(g_fakeServer, "02.09.2018"));
+}

From ef675901deba7a6794f1fe0caecac672c077fea4 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:17:56 +0300
Subject: [PATCH 81/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index b37a5c9b..cd64b744 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -155,7 +155,14 @@ class WeatherClient: public IWeatherClient
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
     {
-        return 19;
+        if (date == "01.09.2018")
+        {
+            return 19;
+        }
+        if (date == "02.09.2018")
+        {
+            return 21;
+        }
     }
     double GetMaximumTemperature(IWeatherServer& server, const std::string& date)
     {

From 118bce02e742d920b7d44562f475390a367cd7e6 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:19:06 +0300
Subject: [PATCH 82/98] Refactoring Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index cd64b744..31458bdb 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -155,14 +155,19 @@ class WeatherClient: public IWeatherClient
     }
     double GetMinimumTemperature(IWeatherServer& server, const std::string& date)
     {
-        if (date == "01.09.2018")
-        {
-            return 19;
-        }
-        if (date == "02.09.2018")
+        double answer = 0;
+        std::string at3 =  GetTemperatureAtTime(server, date, ";03:00");
+        std::string at9 =  GetTemperatureAtTime(server, date, ";09:00");
+        std::string at15 = GetTemperatureAtTime(server, date, ";15:00");
+        std::string at21 = GetTemperatureAtTime(server, date, ";21:00");
+        if (!at3.empty() && !at9.empty() && !at15.empty() && !at21.empty())
         {
-            return 21;
+            answer = std::min(atof(at3.c_str()), atof(at9.c_str()));
+            answer = std::min(answer, atof(at15.c_str()));
+            answer = std::min(answer, atof(at21.c_str()));
         }
+        return answer;
+
     }
     double GetMaximumTemperature(IWeatherServer& server, const std::string& date)
     {

From c3da9ec6375afdcf9a0dca1f37471e0e361de257 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:20:12 +0300
Subject: [PATCH 83/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 31458bdb..2a1d94e2 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -250,3 +250,10 @@ TEST (Weather, MinTemperature_02_09 )
     WeatherClient wClient;
     ASSERT_EQ(min, wClient.GetMinimumTemperature(g_fakeServer, "02.09.2018"));
 }
+
+TEST (Weather, MaxTemperature_1_09 )
+{
+    double max = 31;
+    WeatherClient wClient;
+    ASSERT_EQ(max, wClient.GetMinimumTemperature(g_fakeServer, "02.09.2018"));
+}

From 61ce693e839f8c91596a459f18b434715d11ded9 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:21:03 +0300
Subject: [PATCH 84/98] Red fix mistake Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 2a1d94e2..7b4c2e3b 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -255,5 +255,5 @@ TEST (Weather, MaxTemperature_1_09 )
 {
     double max = 31;
     WeatherClient wClient;
-    ASSERT_EQ(max, wClient.GetMinimumTemperature(g_fakeServer, "02.09.2018"));
+    ASSERT_EQ(max, wClient.GetMinimumTemperature(g_fakeServer, "01.09.2018"));
 }

From 41b10043743632f2160ea45866956d0d9f0716b7 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:21:52 +0300
Subject: [PATCH 85/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 7b4c2e3b..4ec8772c 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -171,7 +171,7 @@ class WeatherClient: public IWeatherClient
     }
     double GetMaximumTemperature(IWeatherServer& server, const std::string& date)
     {
-        return 0;
+        return 31;
     }
     double GetAverageWindDirection(IWeatherServer& server, const std::string& date)
     {
@@ -255,5 +255,5 @@ TEST (Weather, MaxTemperature_1_09 )
 {
     double max = 31;
     WeatherClient wClient;
-    ASSERT_EQ(max, wClient.GetMinimumTemperature(g_fakeServer, "01.09.2018"));
+    ASSERT_EQ(max, wClient.GetMaximumTemperature(g_fakeServer, "01.09.2018"));
 }

From 7dc797a40b3d32c436938bf3a087aff2461403e2 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:22:35 +0300
Subject: [PATCH 86/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 4ec8772c..bf9a096e 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -257,3 +257,10 @@ TEST (Weather, MaxTemperature_1_09 )
     WeatherClient wClient;
     ASSERT_EQ(max, wClient.GetMaximumTemperature(g_fakeServer, "01.09.2018"));
 }
+
+TEST (Weather, MaxTemperature_2_09 )
+{
+    double max = 34;
+    WeatherClient wClient;
+    ASSERT_EQ(max, wClient.GetMaximumTemperature(g_fakeServer, "02.09.2018"));
+}

From ca9643946c1b5f6b87498deaa34077835b94da24 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:24:49 +0300
Subject: [PATCH 87/98] Green Large, but evident step. Signed-off-by: Alexander
 Potapov <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index bf9a096e..99fdceff 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -167,11 +167,21 @@ class WeatherClient: public IWeatherClient
             answer = std::min(answer, atof(at21.c_str()));
         }
         return answer;
-
     }
     double GetMaximumTemperature(IWeatherServer& server, const std::string& date)
     {
-        return 31;
+        double answer = 0;
+        std::string at3 =  GetTemperatureAtTime(server, date, ";03:00");
+        std::string at9 =  GetTemperatureAtTime(server, date, ";09:00");
+        std::string at15 = GetTemperatureAtTime(server, date, ";15:00");
+        std::string at21 = GetTemperatureAtTime(server, date, ";21:00");
+        if (!at3.empty() && !at9.empty() && !at15.empty() && !at21.empty())
+        {
+            answer = std::max(atof(at3.c_str()), atof(at9.c_str()));
+            answer = std::max(answer, atof(at15.c_str()));
+            answer = std::max(answer, atof(at21.c_str()));
+        }
+        return answer;
     }
     double GetAverageWindDirection(IWeatherServer& server, const std::string& date)
     {

From 6a416da1ecec0b4b05c7e3528c2ad782fda74f1c Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:27:16 +0300
Subject: [PATCH 88/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 99fdceff..0d10d5d5 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -274,3 +274,10 @@ TEST (Weather, MaxTemperature_2_09 )
     WeatherClient wClient;
     ASSERT_EQ(max, wClient.GetMaximumTemperature(g_fakeServer, "02.09.2018"));
 }
+
+TEST (Weather, AverageWindDir_01_09 )
+{
+    double average = (131 + 109 + 127 + 176)/4. ;
+    WeatherClient wClient;
+    ASSERT_EQ(average, wClient.GetAverageWindDirection(g_fakeServer, "01.09.2018"));
+}

From 4ed5ef49cd767d2dc918fb8cc6e23673c54996be Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:27:57 +0300
Subject: [PATCH 89/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 0d10d5d5..5731a894 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -185,7 +185,7 @@ class WeatherClient: public IWeatherClient
     }
     double GetAverageWindDirection(IWeatherServer& server, const std::string& date)
     {
-        return 0;
+        return 135.75;
     }
     double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
     {

From f846de9d6b5466779d9c519114b5fb2281664f16 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:29:17 +0300
Subject: [PATCH 90/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 5731a894..657c4654 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -281,3 +281,10 @@ TEST (Weather, AverageWindDir_01_09 )
     WeatherClient wClient;
     ASSERT_EQ(average, wClient.GetAverageWindDirection(g_fakeServer, "01.09.2018"));
 }
+
+TEST (Weather, AverageWindDir_02_09 )
+{
+    double average = (158 + 201 + 258 + 299)/4. ;
+    WeatherClient wClient;
+    ASSERT_EQ(average, wClient.GetAverageWindDirection(g_fakeServer, "02.09.2018"));
+}

From d2727dd57a7abf5b6a65b7d08a158d077b1b08a3 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:31:17 +0300
Subject: [PATCH 91/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 657c4654..8be5e0c1 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -185,7 +185,15 @@ class WeatherClient: public IWeatherClient
     }
     double GetAverageWindDirection(IWeatherServer& server, const std::string& date)
     {
-        return 135.75;
+        if (date == "01.09.2018")
+        {
+            return 135.75;
+        }
+        if (date == "02.09.2018")
+        {
+            return 229;
+        }
+        return 0;
     }
     double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
     {

From 5a48673f5ea8d7c04eb62e964dd2a56c0a311217 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:33:34 +0300
Subject: [PATCH 92/98] Refactoring / large step, but we have analogy.
 Signed-off-by: Alexander Potapov <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 8be5e0c1..24596fce 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -212,6 +212,18 @@ class WeatherClient: public IWeatherClient
             return ParseTemperature(response);
         }
     }
+    std::string GetWindAtTime (IWeatherServer& server, const std::string& date, const std::string& time)
+    {
+        std::string response = server.GetWeather(date + time);
+        if (response.empty())
+        {
+            return "";
+        }
+        else
+        {
+            return ParseWindDir(response);
+        }
+    }
     std::string ParseTemperature(std::string text)
     {
         std::size_t pos = text.find(";");

From cbe04fb74675e205b6e72b08e650a04f14282481 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:35:20 +0300
Subject: [PATCH 93/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 24596fce..f19d4ab6 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -308,3 +308,10 @@ TEST (Weather, AverageWindDir_02_09 )
     WeatherClient wClient;
     ASSERT_EQ(average, wClient.GetAverageWindDirection(g_fakeServer, "02.09.2018"));
 }
+
+TEST (Weather, MaximumWindSpeed_01_09 )
+{
+    double max = 4.2;
+    WeatherClient wClient;
+    ASSERT_EQ(max, wClient.GetMaximumWindSpeed(g_fakeServer, "01.09.2018"));
+}

From f26e2298b96dace80e613d94c550af65675a17c2 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:36:07 +0300
Subject: [PATCH 94/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index f19d4ab6..c3dc3c91 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -197,7 +197,7 @@ class WeatherClient: public IWeatherClient
     }
     double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
     {
-        return 0;
+        return 4.2;
     }
 private:
     std::string GetTemperatureAtTime (IWeatherServer& server, const std::string& date, const std::string& time)

From c4ec2629faed3dc40af0ff84225f065f48e49c1f Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:36:59 +0300
Subject: [PATCH 95/98] Red Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index c3dc3c91..fd415205 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -315,3 +315,10 @@ TEST (Weather, MaximumWindSpeed_01_09 )
     WeatherClient wClient;
     ASSERT_EQ(max, wClient.GetMaximumWindSpeed(g_fakeServer, "01.09.2018"));
 }
+
+TEST (Weather, MaximumWindSpeed_02_09 )
+{
+    double max = 4.0;
+    WeatherClient wClient;
+    ASSERT_EQ(max, wClient.GetMaximumWindSpeed(g_fakeServer, "02.09.2018"));
+}

From ba2af6282e3c365cb093f4cf9354e41a65e31299 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:38:01 +0300
Subject: [PATCH 96/98] Green Signed-off-by: Alexander Potapov
 <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index fd415205..ad56fcbd 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -197,7 +197,14 @@ class WeatherClient: public IWeatherClient
     }
     double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
     {
-        return 4.2;
+        if (date == "01.09.2018")
+        {
+            return 4.2;
+        }
+        if (date == "02.09.2018")
+        {
+            return 4.0;
+        }
     }
 private:
     std::string GetTemperatureAtTime (IWeatherServer& server, const std::string& date, const std::string& time)

From a3afa6be8eaedbe681090f826e688ed3b122c227 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:41:03 +0300
Subject: [PATCH 97/98] Refactoring/ use analogy Signed-off-by: Alexander
 Potapov <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 29 ++++++++++++++-----
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index ad56fcbd..27036024 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -185,15 +185,16 @@ class WeatherClient: public IWeatherClient
     }
     double GetAverageWindDirection(IWeatherServer& server, const std::string& date)
     {
-        if (date == "01.09.2018")
-        {
-            return 135.75;
-        }
-        if (date == "02.09.2018")
+        double answer = 0;
+        std::string at3 =  GetWindDirAtTime(server, date, ";03:00");
+        std::string at9 =  GetWindDirAtTime(server, date, ";09:00");
+        std::string at15 = GetWindDirAtTime(server, date, ";15:00");
+        std::string at21 = GetWindDirAtTime(server, date, ";21:00");
+        if (!at3.empty() && !at9.empty() && !at15.empty() && !at21.empty())
         {
-            return 229;
+            answer = ( atof(at3.c_str()) + atof(at9.c_str()) + atof(at15.c_str()) + atof(at21.c_str()) )/4;
         }
-        return 0;
+        return answer;
     }
     double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
     {
@@ -219,7 +220,7 @@ class WeatherClient: public IWeatherClient
             return ParseTemperature(response);
         }
     }
-    std::string GetWindAtTime (IWeatherServer& server, const std::string& date, const std::string& time)
+    std::string GetWindDirAtTime (IWeatherServer& server, const std::string& date, const std::string& time)
     {
         std::string response = server.GetWeather(date + time);
         if (response.empty())
@@ -231,6 +232,18 @@ class WeatherClient: public IWeatherClient
             return ParseWindDir(response);
         }
     }
+    std::string GetWindSpeedAtTime (IWeatherServer& server, const std::string& date, const std::string& time)
+    {
+        std::string response = server.GetWeather(date + time);
+        if (response.empty())
+        {
+            return "";
+        }
+        else
+        {
+            return ParseWindSpeed(response);
+        }
+    }
     std::string ParseTemperature(std::string text)
     {
         std::size_t pos = text.find(";");

From afce7c7a59f1d1ab9a1c58cc8ac3af83e3974819 Mon Sep 17 00:00:00 2001
From: Alexander Potapov <potapov.alexander@dev.local>
Date: Wed, 24 Oct 2018 20:44:15 +0300
Subject: [PATCH 98/98] Refactoring/  have analogy Signed-off-by: Alexander
 Potapov <potapov.alexander@dev.local>

---
 tdd_intro/homework/04_weather_client/test.cpp | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/tdd_intro/homework/04_weather_client/test.cpp b/tdd_intro/homework/04_weather_client/test.cpp
index 27036024..6bb01810 100644
--- a/tdd_intro/homework/04_weather_client/test.cpp
+++ b/tdd_intro/homework/04_weather_client/test.cpp
@@ -198,14 +198,18 @@ class WeatherClient: public IWeatherClient
     }
     double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
     {
-        if (date == "01.09.2018")
-        {
-            return 4.2;
-        }
-        if (date == "02.09.2018")
+        double answer = 0;
+        std::string at3 =  GetWindSpeedAtTime(server, date, ";03:00");
+        std::string at9 =  GetWindSpeedAtTime(server, date, ";09:00");
+        std::string at15 = GetWindSpeedAtTime(server, date, ";15:00");
+        std::string at21 = GetWindSpeedAtTime(server, date, ";21:00");
+        if (!at3.empty() && !at9.empty() && !at15.empty() && !at21.empty())
         {
-            return 4.0;
+            answer = std::max(atof(at3.c_str()), atof(at9.c_str()));
+            answer = std::max(answer, atof(at15.c_str()));
+            answer = std::max(answer, atof(at21.c_str()));
         }
+        return answer;
     }
 private:
     std::string GetTemperatureAtTime (IWeatherServer& server, const std::string& date, const std::string& time)