fix(jsx): avoid making type param lists ambiguous when trailingCommas is never#751
Open
xandris wants to merge 1 commit intodprint:mainfrom
Open
fix(jsx): avoid making type param lists ambiguous when trailingCommas is never#751xandris wants to merge 1 commit intodprint:mainfrom
xandris wants to merge 1 commit intodprint:mainfrom
Conversation
Neither function expressions nor function declarations are ambiguous:
```typescript
// These parse correctly even in TSX
function foo<T>() { }
const foo = function<T>() {}
```
Only arrow functions are ambiguous. The presence of the `function` or `class` keywords is enough for the TypeScript parser to disambiguate.
The guards against this were in place but deactivated by `trailingCommas: never`. Change it to always check before applying the preferred style.
See: dprint#636
Signed-off-by: Alexandra Parker <alex.iris.parker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this is the first Rust I've ever read/written. I'd like to fix #636. The guards against mangling type parameter lists were in place but deactivated by
trailingCommas: never. Change it to always check before applying the preferred style.I noticed it checked for
function<T>as well, but in my testing neither function expressions nor declarations are ambiguous:The presence of the
functionorclasskeywords seems to be enough for the TypeScript parser to disambiguate.Thank you, dprint and its plugins are such a delight.