feat: remove unnecessary escape sequences in strings#497
Open
shannonrothe wants to merge 1 commit intodprint:mainfrom
Open
feat: remove unnecessary escape sequences in strings#497shannonrothe wants to merge 1 commit intodprint:mainfrom
shannonrothe wants to merge 1 commit intodprint:mainfrom
Conversation
dsherret
requested changes
Mar 20, 2023
Member
dsherret
left a comment
There was a problem hiding this comment.
Thanks! This seems very nice to have. However, when testing out what prettier does, it maintains escapes for numbers since "\5" !== "5". If we merge this I want to be absolute sure we can actually do this. It might be good to write a script in javascript that goes through all the character possibilities and finds all the scenarios where a character is not equal to itself escaped.
Member
|
I was just thinking more about this and actually I think we should change this to only occur when the char is also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix ensures any unnecessary escape sequences in a string literal are omitted. It is largely based off the rules set out here. I've modified
remove_needless_quote_backslashesto incorporate the additional "rules", whereby previously it only cared about escaped quotes depending on the type of string literal.I'm pretty heavily relying on a few new test cases + ensuring existing tests didn't break, so there's a chance I might miss some edge cases