Added support for typeLiteral.separatorKind.multiLine: newLine#471
Open
DoctorGester wants to merge 1 commit intodprint:mainfrom
Open
Added support for typeLiteral.separatorKind.multiLine: newLine#471DoctorGester wants to merge 1 commit intodprint:mainfrom
typeLiteral.separatorKind.multiLine: newLine#471DoctorGester wants to merge 1 commit intodprint:mainfrom
Conversation
Member
|
Hey @DoctorGester, I'm sorry, but this was discussed and closed in #454 For example, this is already possible when not using semi-colons like so: https://dprint.dev/playground/#code/C4TwDgpgBAKhDOwoF4oG8CwAoKurAWAC4pEAnASwDsBzAbmzygHtgALCMkqgVwFsARpwZYAvkA/config/N4WAUABBBEA2CWA7ApgdXgEwC4AtoC4IAOABgBpwpokNlEt1s9CAmCyGAZ2QFt4BhAPaxBiTgRgBDTvGjgAvuCA/language/typescript Are you wanting to use semi-colons, but here to not use semi-colons? |
Author
|
Hi, @dsherret yep exactly, I wanted semicolons in the rest of the code, but not in types since types are less ambiguous in general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
newLineseparator specifically for multiline type literals. If not specified, it will fallback to whatever is specified intypeLiteral.separatorKind(implemented poorly).