Weird escaping of WHERE clause values

[displaced]

Fetching model instances with a where parameter escapes values strangely.

For example, if you have '... where: { username: 'foo.bar'}' generates SQL of WHERE "username" = 'foo'.'bar'

Looks like the logic to escape schema.tablename is erroneously being applied to values.

[displaced]

mssql's selectQuery function is calling:

var sql = AbstractQueryGenerator.selectQuery.call(
        this, tableName, Utils._.omit(options, 'limit', 'offset'), factory
      )

have verified that the SQL returned from there is bad, so the problem's in AbstractQueryGenerator!

[displaced]

Problem is in AbstractQueryGenerator's hashToWhereConditions

[displaced]

nope - mssql's query-generator overrides AbstractQueryGenerator's hashToWhereConditions.

so that's better - the problem's in the mssql implementation still

[displaced]

Edited processAndEscapeValue in mssql's query-generator - now uses only SqlString.escape to escape values, rather than using both that and QueryGenerator.addQuotes