From edb46f0105d23bcb7e1cc842e609e0902afbbd4f Mon Sep 17 00:00:00 2001 From: Konstantin Date: Sat, 18 Oct 2025 01:22:35 +0000 Subject: [PATCH 1/2] add missing headers --- src/mdict_extern.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mdict_extern.cc b/src/mdict_extern.cc index f5d8370..6eb0d4e 100644 --- a/src/mdict_extern.cc +++ b/src/mdict_extern.cc @@ -11,7 +11,11 @@ #include #include #include - +#include +#include +#include +#include +#include #include "include/mdict.h" /** From 04653f44b76d6db16ac51a0362659049fe7b4d56 Mon Sep 17 00:00:00 2001 From: Konstantin Date: Sat, 18 Oct 2025 01:34:18 +0000 Subject: [PATCH 2/2] do not pass address --- src/mdict_extern.cc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/mdict_extern.cc b/src/mdict_extern.cc index 6eb0d4e..575480c 100644 --- a/src/mdict_extern.cc +++ b/src/mdict_extern.cc @@ -203,14 +203,9 @@ simple_key_item **mdict_keylist(void *dict, uint64_t *len) { constexpr bool elem_is_ptr = std::is_pointer_v; for (std::size_t i = 0; i < n; ++i) { - if constexpr (elem_is_ptr) { - // keylist holds pointer elements already - items[i] = make_item(keylist[i]); - } else { - // keylist holds elements by value; pass address - items[i] = make_item(&keylist[i]); - } - } + items[i] = make_item(keylist[i]); +} + return items; }