From 853f22f4fbc4a77f2ff7d21e177d48137bc31a58 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 12:09:31 +0200 Subject: [PATCH 1/9] Bump gh cache -> v3 --- .github/workflows/audit.yml | 2 +- .github/workflows/e2e.yml | 2 +- .github/workflows/fmt.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/prepare-dfx-assets.yml | 2 +- .github/workflows/publish.yml | 2 +- .github/workflows/unit.yml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml index cc0ff2a80b..ba4a9d280c 100644 --- a/.github/workflows/audit.yml +++ b/.github/workflows/audit.yml @@ -43,7 +43,7 @@ jobs: path: advisory-db ref: ${{ matrix.advisory-db-rev }} - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: | ~/.cargo/registry diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 688b8a54ad..f1b12c6734 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -43,7 +43,7 @@ jobs: run: | echo "RUSTFLAGS=--remap-path-prefix=${GITHUB_WORKSPACE}=/builds/dfinity" >> $GITHUB_ENV - name: Cache Cargo - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: | ~/.cargo/registry diff --git a/.github/workflows/fmt.yml b/.github/workflows/fmt.yml index e488824942..35cf9d44de 100644 --- a/.github/workflows/fmt.yml +++ b/.github/workflows/fmt.yml @@ -25,7 +25,7 @@ jobs: - uses: actions/checkout@v3 - name: Cache Cargo - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: | ~/.cargo/registry diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3ac6314268..f58093b59e 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -25,7 +25,7 @@ jobs: steps: - uses: actions/checkout@v3 - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: | ~/.cargo/registry diff --git a/.github/workflows/prepare-dfx-assets.yml b/.github/workflows/prepare-dfx-assets.yml index 0e42fe89eb..807b577795 100644 --- a/.github/workflows/prepare-dfx-assets.yml +++ b/.github/workflows/prepare-dfx-assets.yml @@ -28,7 +28,7 @@ jobs: os: [ ubuntu-latest, macos-latest ] steps: - uses: actions/checkout@v3 - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: | ~/.cargo/registry diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c2f6c756fc..4a6558cbc5 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -58,7 +58,7 @@ jobs: echo "SHA256_FILENAME=dfx-$GITHUB_REF_NAME-${{ matrix.name }}.tar.gz.sha256" >> $GITHUB_ENV - name: Cache Cargo - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: | ~/.cargo/registry diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml index 25f61c7e6e..cf7bb554a3 100644 --- a/.github/workflows/unit.yml +++ b/.github/workflows/unit.yml @@ -25,7 +25,7 @@ jobs: os: [ ubuntu-latest, macos-latest ] steps: - uses: actions/checkout@v3 - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: | ~/.cargo/registry From 862b630bca8d66be20d692ab177cb7ae774c8e76 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 12:11:08 +0200 Subject: [PATCH 2/9] Bump upload artifact --- .github/workflows/build-frontend-canister.yml | 2 +- .github/workflows/e2e.yml | 2 +- .github/workflows/publish.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-frontend-canister.yml b/.github/workflows/build-frontend-canister.yml index eb694a7d08..009e3aa600 100644 --- a/.github/workflows/build-frontend-canister.yml +++ b/.github/workflows/build-frontend-canister.yml @@ -27,7 +27,7 @@ jobs: run: | ./scripts/update-frontend-canister.sh - name: Artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: assetstorage path: ${{ github.workspace }}/src/distributed/assetstorage.wasm.gz diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index f1b12c6734..aa119b500e 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -68,7 +68,7 @@ jobs: strip dfx if: contains(matrix.os, 'ubuntu') - name: Upload Artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: dfx-${{ matrix.os }}-rs-${{ matrix.rust }} path: ${{ matrix.binary_path }}/dfx diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 4a6558cbc5..a0565acec4 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -119,7 +119,7 @@ jobs: - name: Upload Artifacts if: github.ref_type == 'tag' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: dfx-artifacts-${{ matrix.rust }}-${{ matrix.name }} path: | From 0ecc91d04d2f477c9ee5e27bda096d300bea334e Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 17:02:40 +0200 Subject: [PATCH 3/9] Replace set-output with https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter --- .github/workflows/audit.yml | 2 +- .github/workflows/e2e.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml index ba4a9d280c..646e0e523b 100644 --- a/.github/workflows/audit.yml +++ b/.github/workflows/audit.yml @@ -24,7 +24,7 @@ jobs: steps: - uses: actions/checkout@v3 - id: set-matrix - run: echo "::set-output name=matrix::$(scripts/workflows/audit-matrix.py)" + run: echo "name=matrix::$(scripts/workflows/audit-matrix.py)" >> $GITHUB_OUTPUT test: name: audit diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index aa119b500e..1733456d05 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -80,7 +80,7 @@ jobs: steps: - uses: actions/checkout@v3 - id: set-matrix - run: echo "::set-output name=matrix::$(scripts/workflows/e2e-matrix.py)" + run: echo "name=matrix::$(scripts/workflows/e2e-matrix.py)" >> $GITHUB_OUTPUT smoke: runs-on: ${{ matrix.os }} From 1b7606cae203fd49aad4af6f9de0aa046515898b Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 17:06:52 +0200 Subject: [PATCH 4/9] Use the same nix (v17) everywhere --- .github/workflows/consistent-sources.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/consistent-sources.yml b/.github/workflows/consistent-sources.yml index 28fbc9e22a..37451df426 100644 --- a/.github/workflows/consistent-sources.yml +++ b/.github/workflows/consistent-sources.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: cachix/install-nix-action@v13 + - uses: cachix/install-nix-action@d64e0553100205688c0fb2fa16edb0fc8663c590 # https://github.com/cachix/install-nix-action/releases/tag/v17 with: nix_path: nixpkgs=channel:nixos-21.05-small - name: Install dependencies From 931db717e9ecf5bb47a921fde8d40d9758a154a3 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 22:43:05 +0200 Subject: [PATCH 5/9] Update the GITHUB_OUTPUT commands --- .github/workflows/audit.yml | 2 +- .github/workflows/e2e.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml index 646e0e523b..0bcfb989d3 100644 --- a/.github/workflows/audit.yml +++ b/.github/workflows/audit.yml @@ -24,7 +24,7 @@ jobs: steps: - uses: actions/checkout@v3 - id: set-matrix - run: echo "name=matrix::$(scripts/workflows/audit-matrix.py)" >> $GITHUB_OUTPUT + run: echo "matrix=$(scripts/workflows/audit-matrix.py)" >> $GITHUB_OUTPUT test: name: audit diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 1733456d05..263031995c 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -80,7 +80,7 @@ jobs: steps: - uses: actions/checkout@v3 - id: set-matrix - run: echo "name=matrix::$(scripts/workflows/e2e-matrix.py)" >> $GITHUB_OUTPUT + run: echo "matrix=$(scripts/workflows/e2e-matrix.py)" >> $GITHUB_OUTPUT smoke: runs-on: ${{ matrix.os }} From e604aa099daaed49c99a1dfbc128aaaf3d571dd8 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 22:55:24 +0200 Subject: [PATCH 6/9] Bump install-nix-action to v18 --- .github/workflows/consistent-sources.yml | 2 +- .github/workflows/update-replica-version.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/consistent-sources.yml b/.github/workflows/consistent-sources.yml index 37451df426..346a83b151 100644 --- a/.github/workflows/consistent-sources.yml +++ b/.github/workflows/consistent-sources.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: cachix/install-nix-action@d64e0553100205688c0fb2fa16edb0fc8663c590 # https://github.com/cachix/install-nix-action/releases/tag/v17 + - uses: cachix/install-nix-action@v18 with: nix_path: nixpkgs=channel:nixos-21.05-small - name: Install dependencies diff --git a/.github/workflows/update-replica-version.yml b/.github/workflows/update-replica-version.yml index d31c87ef2e..4d6ff8ce79 100644 --- a/.github/workflows/update-replica-version.yml +++ b/.github/workflows/update-replica-version.yml @@ -44,7 +44,7 @@ jobs: grep -s "REPLICA_VERSION" $GITHUB_ENV - name: install Nix - uses: cachix/install-nix-action@d64e0553100205688c0fb2fa16edb0fc8663c590 # https://github.com/cachix/install-nix-action/releases/tag/v17 + uses: cachix/install-nix-action@v18 with: nix_path: nixpkgs=channel:nixos-unstable From 298f3578409fcffaa1c89c5445c899391b98e7c5 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 23:03:44 +0200 Subject: [PATCH 7/9] Bump conventional pr title --- .github/workflows/pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 49930f366e..1b331cd932 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -24,7 +24,7 @@ jobs: check: runs-on: ubuntu-latest steps: - - uses: dfinity/conventional-pr-title-action@v2.2.3 + - uses: dfinity/conventional-pr-title-action@v2.4.4 with: success-state: Title follows the specification. failure-state: Title does not follow the specification. From e7bbccd643c98df263d0f51da505df8dc4e9e8d9 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 23:18:25 +0200 Subject: [PATCH 8/9] Bump checkout --- .github/workflows/build-frontend-canister.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-frontend-canister.yml b/.github/workflows/build-frontend-canister.yml index 009e3aa600..98b8120c63 100644 --- a/.github/workflows/build-frontend-canister.yml +++ b/.github/workflows/build-frontend-canister.yml @@ -18,7 +18,7 @@ jobs: name: frontend-canister-up-to-date:required steps: - name: Check out the repo - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Set up run: | rustup target add wasm32-unknown-unknown From c3cb862d729c5dc2bc75e4cdd9d63477c4b87c65 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 17 Oct 2022 23:28:39 +0200 Subject: [PATCH 9/9] Bump download artifact --- .github/workflows/e2e.yml | 4 ++-- .github/workflows/publish.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 263031995c..a2cdb53af9 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -98,7 +98,7 @@ jobs: steps: - uses: actions/checkout@v3 - name: Download dfx binary - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: dfx-${{ matrix.os }}-rs-${{ matrix.rust }} path: /usr/local/bin @@ -131,7 +131,7 @@ jobs: steps: - uses: actions/checkout@v3 - name: Download dfx binary - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: dfx-${{ matrix.os }}-rs-${{ matrix.rust }} path: /usr/local/bin diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index a0565acec4..95773575ec 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -150,7 +150,7 @@ jobs: run: echo "VERSION=$GITHUB_REF_NAME" >> $GITHUB_ENV - name: Download Artifacts - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: dfx-artifacts-${{ matrix.rust }}-${{ matrix.name }}