From ab4d5fea91afc978278d7be1231a2414c5478c95 Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 20 Jan 2026 00:19:52 -0500 Subject: [PATCH 1/3] Add assetRegex option At some point in the recent past, I started getting installation errors when using this Feature: ``` nanolayer.installers.gh_release.resolvers.asset_resolver.AssetResolver.AssetResolverError: Too many matches found ``` The shellcheck v0.11.0 release added some assets a few weeks ago, which _could_ be the trigger that caused the above error: https://github.com/koalaman/shellcheck/releases/tag/v0.11.0 I've added a pretty basic regex filter on the asset name that should limits the matches to gzipped tar files. If there's a more appropriate regex to use, please let me know. I successfully tested this pattern locally by using the gh-release feature with the following configuration: ```json "ghcr.io/devcontainers-extra/features/gh-release:1": { "repo": "koalaman/shellcheck", "binaryNames": "shellcheck", "assetRegex": "shellcheck-.*.tar.gz$" }, ``` Signed-off-by: Jason Garber --- src/shellcheck/install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shellcheck/install.sh b/src/shellcheck/install.sh index 8dbf2ce1..816835f3 100755 --- a/src/shellcheck/install.sh +++ b/src/shellcheck/install.sh @@ -16,6 +16,6 @@ $nanolayer_location \ install \ devcontainer-feature \ "ghcr.io/devcontainers-extra/features/gh-release:1" \ - --option repo='koalaman/shellcheck' --option binaryNames='shellcheck' --option version="$VERSION" + --option repo='koalaman/shellcheck' --option binaryNames='shellcheck' --option version="$VERSION" --option assetRegex='shellcheck-.*.tar.gz$' echo 'Done!' From c7ef7deecb5224867c65e9750f5fd5e8bd753107 Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 20 Jan 2026 09:17:40 -0500 Subject: [PATCH 2/3] Use `tar.xz` instead of `tar.gz` shellcheck v0.11.0 introduced `tar.gz` files. Previous releases exclusively use `tar.xz`. Signed-off-by: Jason Garber --- src/shellcheck/install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shellcheck/install.sh b/src/shellcheck/install.sh index 816835f3..ecc24b3d 100755 --- a/src/shellcheck/install.sh +++ b/src/shellcheck/install.sh @@ -16,6 +16,6 @@ $nanolayer_location \ install \ devcontainer-feature \ "ghcr.io/devcontainers-extra/features/gh-release:1" \ - --option repo='koalaman/shellcheck' --option binaryNames='shellcheck' --option version="$VERSION" --option assetRegex='shellcheck-.*.tar.gz$' + --option repo='koalaman/shellcheck' --option binaryNames='shellcheck' --option version="$VERSION" --option assetRegex='shellcheck-.*.tar.xz$' echo 'Done!' From 83550b6063fef8a94026f66eefc7e8f57c4abaa3 Mon Sep 17 00:00:00 2001 From: Jason Garber Date: Tue, 20 Jan 2026 09:19:36 -0500 Subject: [PATCH 3/3] Bump shellcheck Feature version to v1.1.0 Signed-off-by: Jason Garber --- src/shellcheck/devcontainer-feature.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shellcheck/devcontainer-feature.json b/src/shellcheck/devcontainer-feature.json index 12b7cd58..821947f9 100644 --- a/src/shellcheck/devcontainer-feature.json +++ b/src/shellcheck/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "shellcheck", - "version": "1.0.0", + "version": "1.1.0", "name": "shellcheck (via Github Releases)", "documentationURL": "http://github.com/devcontainers-extra/features/tree/main/src/shellcheck", "description": "", @@ -15,4 +15,4 @@ } }, "installsAfter": [] -} \ No newline at end of file +}