From 650f5bf75b514b8ab8e699a0bd401c0d979a7301 Mon Sep 17 00:00:00 2001 From: belltalion Date: Thu, 16 Oct 2025 16:25:07 +0900 Subject: [PATCH 1/5] Fix input handleClear --- .changeset/ten-apples-check.md | 5 +++++ packages/components/src/components/Input/index.tsx | 7 ++++++- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/ten-apples-check.md diff --git a/.changeset/ten-apples-check.md b/.changeset/ten-apples-check.md new file mode 100644 index 00000000..5e0d8fd4 --- /dev/null +++ b/.changeset/ten-apples-check.md @@ -0,0 +1,5 @@ +--- +'@devup-ui/components': patch +--- + +Fix input hadnClear diff --git a/packages/components/src/components/Input/index.tsx b/packages/components/src/components/Input/index.tsx index 7b3bb013..c0ef5031 100644 --- a/packages/components/src/components/Input/index.tsx +++ b/packages/components/src/components/Input/index.tsx @@ -50,6 +50,7 @@ export function Input({ disabled, className, classNames, + readOnly, ref, onClear, ...props @@ -63,12 +64,16 @@ export function Input({ const handleClear = () => { setValue('') + onChangeProp?.({ + target: { value: '' }, + } as React.ChangeEvent) onClear?.() } const innerValue = valueProp ?? value - const clearButtonVisible = !!innerValue && !disabled && allowClear + const clearButtonVisible = + !!innerValue && !disabled && allowClear && !readOnly return ( Date: Thu, 16 Oct 2025 16:38:11 +0900 Subject: [PATCH 2/5] Fix input handleClear --- packages/components/src/components/Input/index.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/src/components/Input/index.tsx b/packages/components/src/components/Input/index.tsx index c0ef5031..ca7602da 100644 --- a/packages/components/src/components/Input/index.tsx +++ b/packages/components/src/components/Input/index.tsx @@ -194,6 +194,7 @@ export function ClearButton(props: ComponentProps<'button'>) { styleOrder={1} top="50%" transform="translateY(-50%)" + type="button" {...props} > Date: Thu, 16 Oct 2025 16:41:18 +0900 Subject: [PATCH 3/5] Fix input handleClear --- .../Input/__tests__/__snapshots__/index.browser.test.tsx.snap | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/components/src/components/Input/__tests__/__snapshots__/index.browser.test.tsx.snap b/packages/components/src/components/Input/__tests__/__snapshots__/index.browser.test.tsx.snap index 40c27c14..c9fc4d49 100644 --- a/packages/components/src/components/Input/__tests__/__snapshots__/index.browser.test.tsx.snap +++ b/packages/components/src/components/Input/__tests__/__snapshots__/index.browser.test.tsx.snap @@ -114,6 +114,7 @@ exports[`Input > should pass props to ClearButton component 1`] = `