Skip to content

UpuConsole: -o ignored if directory already exists #3

@russt

Description

@russt

This works okay:

$ mono /scm/p4proj/main/p4connect/UPU/UpuConsole.exe -o /tmp/foodir -i dist/P4Connect.unitypackage
Extracting dist/P4Connect.unitypackage to /tmp/foodir
Decompressed: P4Connect.unitypackage
Extracting /var/folders/lZ/lZCSnMPVHt4tXtOYjErkFE+++TI/-Tmp-/Upu/iyvrrmdy.ejr/P4Connect to /var/folders/lZ/lZCSnMPVHt4tXtOYjErkFE+++TI/-Tmp-/Upu/iyvrrmdy.ejr/content...
Creating directory /tmp/foodir/Assets/P4Connect/Editor...
Extracting file /tmp/foodir/Assets/P4Connect/Editor/libp4bridge.dylib...
Extracting file /tmp/foodir/Assets/P4Connect/Editor/PackageIcons.cs...
Extracting file /tmp/foodir/Assets/P4Connect/readme.txt...
Extracting file /tmp/foodir/Assets/P4Connect/Editor/Icons.pack...

However, if output directory already exists, UpuConsole confusingly ignores the -o argument, and unpacks to the default location with an incremented unpack count:

$ mono /scm/p4proj/main/p4connect/UPU/UpuConsole.exe -o /tmp/foodir -i dist/P4Connect.unitypackage
Extracting dist/P4Connect.unitypackage to /Volumes/tanami-ufs/p4proj/main/p4connect/dist/P4Connect.unitypackage_unpacked (2)
Decompressed: P4Connect.unitypackage
Extracting /var/folders/lZ/lZCSnMPVHt4tXtOYjErkFE+++TI/-Tmp-/Upu/sg7t3k6x.xky/P4Connect to /var/folders/lZ/lZCSnMPVHt4tXtOYjErkFE+++TI/-Tmp-/Upu/sg7t3k6x.xky/content...
Creating directory /Volumes/tanami-ufs/p4proj/main/p4connect/dist/P4Connect.unitypackage_unpacked (2)/Assets/P4Connect/Editor...
Extracting file /Volumes/tanami-ufs/p4proj/main/p4connect/dist/P4Connect.unitypackage_unpacked (2)/Assets/P4Connect/Editor/libp4bridge.dylib...
Extracting file /Volumes/tanami-ufs/p4proj/main/p4connect/dist/P4Connect.unitypackage_unpacked (2)/Assets/P4Connect/Editor/PackageIcons.cs...
Extracting file /Volumes/tanami-ufs/p4proj/main/p4connect/dist/P4Connect.unitypackage_unpacked (2)/Assets/P4Connect/readme.txt...
Extracting file /Volumes/tanami-ufs/p4proj/main/p4connect/dist/P4Connect.unitypackage_unpacked (2)/Assets/P4Connect/Editor/Icons.pack...

Would probably be better to unpack to:

/tmp/foodir (2)

to be consistent with the behaviour when the -o option is not specified.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions