Import Maps don't support package address targets with query parameters

[NicolaiSchmid]

Reproduce:

• Deno v1.23.3
• import_map.json:

{
  "imports": {
      "@mui/": "https://esm.sh/@mui/material@5.9.1/?alias=react:preact/compat,react/jsx-runtime:preact/compat/jsx-runtime&deps=preact@10.8.1"
  }
}

Deno then reports back with:

Package address targets must end with "/".

I couldn't find a current code snippet, but for version 1.9.1 I found this check, which doesn't account for esm.sh alias feature, because it just checks the last character of the value string.

If you have any further questions, please let me know

[kitsonk]

I am not sure what the spec says about handling query parameters in targets. If it is allowed, I suspect we need to change how we resolve specifiers to preserve the query paramaters.

[NicolaiSchmid]

It was mentioned as a solution/workaround here denoland/fresh#411 (comment) and is documented beneath the "Aliasing dependencies" headline directly on esm.sh

[ije]

use

{
  "imports": {
      "@mui/": "https://esm.sh/@mui/material@5.9.1&alias=react:preact/compat,react/jsx-runtime:preact/compat/jsx-runtime&deps=preact@10.8.1/"
  }
}

instead

[mb21]

From https://esm.sh/#docs :

Import maps supports trailing slash that can not work with URL search params friendly. To fix this issue, esm.sh provides a special format for import URL that allows you to use query params with trailing slash: change the query prefix ? to & and put it after the package version.

{
  "imports": {
    "react-dom": "https://esm.sh/react-dom@19.1.0?dev",
    "react-dom/": "https://esm.sh/react-dom@19.1.0&dev/"
  }
}