From 8595cd417fb6594cfa50e2514ac9d912dc1e7327 Mon Sep 17 00:00:00 2001 From: "George G. Davis" Date: Fri, 13 Jun 2025 16:22:43 -0400 Subject: [PATCH 1/2] devmem2: fix sprintf size_t format warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the following build warnings: $ aarch64-linux-gnu-gcc devmem2.c devmem2.c: In function ‘main’: devmem2.c:120:66: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=] 120 | sprintf(fmt_str, "Read at address 0x%%08lX (%%p): 0x%%0%dlX\n", 2*data_size); | ~^ ~~~~~~~~~~~ | | | | int size_t {aka long unsigned int} | %ld devmem2.c:148:74: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=] 148 | sprintf(fmt_str, "Write at address 0x%%08lX (%%p): 0x%%0%dlX, " | ~^ | | | int | %ld 149 | "readback 0x%%0%dlX\n", 2*data_size, 2*data_size); | ~~~~~~~~~~~ | | | size_t {aka long unsigned int} devmem2.c:148:34: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=] 148 | sprintf(fmt_str, "Write at address 0x%%08lX (%%p): 0x%%0%dlX, " | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 149 | "readback 0x%%0%dlX\n", 2*data_size, 2*data_size); | ~~~~~~~~~~~ | | | size_t {aka long unsigned int} devmem2.c:149:41: note: format string is defined here 149 | "readback 0x%%0%dlX\n", 2*data_size, 2*data_size); | ~^ | | | int | %ld Signed-off-by: George G. Davis --- devmem2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/devmem2.c b/devmem2.c index cc174ac..6b5e464 100644 --- a/devmem2.c +++ b/devmem2.c @@ -117,7 +117,7 @@ int main(int argc, char **argv) { fprintf(stderr, "Illegal data type '%c'.\n", access_type); exit(2); } - sprintf(fmt_str, "Read at address 0x%%08lX (%%p): 0x%%0%dlX\n", 2*data_size); + sprintf(fmt_str, "Read at address 0x%%08lX (%%p): 0x%%0%zulX\n", 2*data_size); printf(fmt_str, (unsigned long)target, virt_addr, read_result); fflush(stdout); @@ -145,8 +145,8 @@ int main(int argc, char **argv) { read_result = *((uint64_t *) virt_addr); break; } - sprintf(fmt_str, "Write at address 0x%%08lX (%%p): 0x%%0%dlX, " - "readback 0x%%0%dlX\n", 2*data_size, 2*data_size); + sprintf(fmt_str, "Write at address 0x%%08lX (%%p): 0x%%0%zulX, " + "readback 0x%%0%zulX\n", 2*data_size, 2*data_size); printf(fmt_str, (unsigned long)target, virt_addr, write_val, read_result); fflush(stdout); From fed84473f0401aa8e6f0e0679fc6f0dd50aa8d2c Mon Sep 17 00:00:00 2001 From: "George G. Davis" Date: Fri, 13 Jun 2025 17:12:51 -0400 Subject: [PATCH 2/2] devmem2: fix -Wunused-parameter warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the following build warning: $ aarch64-linux-gnu-gcc -Wunused-parameter devmem2.c devmem2.c: In function ‘fixup_addr’: devmem2.c:160:51: warning: unused parameter ‘size’ [-Wunused-parameter] 160 | static inline void *fixup_addr(void *addr, size_t size) | ~~~~~~~^~~~ Signed-off-by: George G. Davis --- devmem2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/devmem2.c b/devmem2.c index 6b5e464..4ef7665 100644 --- a/devmem2.c +++ b/devmem2.c @@ -163,6 +163,8 @@ static inline void *fixup_addr(void *addr, size_t size) unsigned long aligned_addr = (unsigned long)addr; aligned_addr &= ~(size - 1); addr = (void *)aligned_addr; +#else + (void)(size); #endif return addr; }