[BUG] Unintended stock app uninstallations

[juandvasquezp]

Yeah so, I was happy using my Rish functionality and happy because it was merged, when I came across an issue.

As it turns out, some patches deliberately change the pkg name of some apps, usually google apps patches like com.google.android.apps.photos to something like app.revanced.android.photos, and com.google.android.youtube to app.rvx.android.youtube or app.revanced.android.youtube depending on the source.

So, right now the rish.sh checks for the stock app signatures and prompts for its uninstallation, which is not ideal, because installations will fail if there's a real signature mismatch or downgrade. And if the user wants to keep both stock and patched apps, rish will uninstall stock thinking that that will solve the problem when in reality it won't.

It should be an easy fix, just to use the pkg name of the patched apk for signature verification and uninstallations, instead of using PKG_NAME. I shall look into it when I have time... this wednesday or this weekend. 👍

Also, in the version selection screen, it shows the stock app installed version, because getInstalledVersion() looks for the stock app version. I don't know if that's the intended use (because su checks for that version), or if we should look for the patched app version.

[decipher3114]

This requires a thorough testing. For now, I'll revert the commit. I would request you to think about all the edge cases and re-open the PR.

[Graywizard888]

any updates regarding this feature ?