From d1b32d365c2d9cf38c146631943e0c15d2e63ddb Mon Sep 17 00:00:00 2001 From: Yan <61414485+yanthomasdev@users.noreply.github.com> Date: Mon, 9 Feb 2026 19:03:25 -0300 Subject: [PATCH 1/3] fix(a11y): aria-labels Co-authored-by: kewitham --- .../src/components/Collection/ViewStyleControl.js | 2 ++ .../components/Editor/EditorControlPane/EditorControl.js | 1 + .../src/components/MediaLibrary/MediaLibraryHeader.js | 2 +- .../decap-cms-core/src/components/UI/SettingsDropdown.js | 2 +- packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js | 2 +- packages/decap-cms-widget-datetime/src/DateTimeControl.js | 7 ++++--- .../src/MarkdownControl/Toolbar.js | 6 +++++- 7 files changed, 15 insertions(+), 7 deletions(-) diff --git a/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js b/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js index b38ca5b8c1a2..6cf337404c6c 100644 --- a/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js +++ b/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js @@ -32,12 +32,14 @@ function ViewStyleControl({ viewStyle, onChangeViewStyle }) { return ( onChangeViewStyle(VIEW_STYLE_LIST)} > onChangeViewStyle(VIEW_STYLE_GRID)} > diff --git a/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js b/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js index 0a99468ac887..042ce340c64c 100644 --- a/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js +++ b/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js @@ -245,6 +245,7 @@ class EditorControl extends React.Component { {({ css, cx }) => ( - + {title} diff --git a/packages/decap-cms-core/src/components/UI/SettingsDropdown.js b/packages/decap-cms-core/src/components/UI/SettingsDropdown.js index 06979bc86073..5b000d021aac 100644 --- a/packages/decap-cms-core/src/components/UI/SettingsDropdown.js +++ b/packages/decap-cms-core/src/components/UI/SettingsDropdown.js @@ -81,7 +81,7 @@ function SettingsDropdown({ displayUrl, isTestRepo, imageUrl, onLogoutClick, t } dropdownWidth="100px" dropdownPosition="right" renderButton={() => ( - + )} diff --git a/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js b/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js index 2340a26b7607..c67b95d02f65 100644 --- a/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js +++ b/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js @@ -118,7 +118,7 @@ class ObjectWidgetTopBar extends React.Component { return ( - + {heading} diff --git a/packages/decap-cms-widget-datetime/src/DateTimeControl.js b/packages/decap-cms-widget-datetime/src/DateTimeControl.js index bd74ed5cf30b..8e8e9264a24e 100644 --- a/packages/decap-cms-widget-datetime/src/DateTimeControl.js +++ b/packages/decap-cms-widget-datetime/src/DateTimeControl.js @@ -12,7 +12,7 @@ dayjs.extend(customParseFormat); dayjs.extend(localizedFormat); dayjs.extend(utc); -function Buttons({ t, handleChange, getNow }) { +function Buttons({ t, fieldName, handleChange, getNow }) { return (
); diff --git a/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js b/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js index 6f405729184d..251611a67537 100644 --- a/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js +++ b/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js @@ -281,7 +281,11 @@ export default class Toolbar extends React.Component { {t('editor.editorWidgets.markdown.richText')} - + {t('editor.editorWidgets.markdown.markdown')} From 4b2ab63d80fdc04df0f4266ca558f20fc24b499a Mon Sep 17 00:00:00 2001 From: Yan <61414485+yanthomasdev@users.noreply.github.com> Date: Tue, 10 Feb 2026 10:16:25 -0300 Subject: [PATCH 2/3] feat: add aria-label i18n --- .../Collection/CollectionControls.js | 2 +- .../components/Collection/ViewStyleControl.js | 6 +++--- .../Editor/EditorControlPane/EditorControl.js | 2 +- .../MediaLibrary/MediaLibraryHeader.js | 4 ++-- .../MediaLibrary/MediaLibraryTop.js | 1 + .../src/components/UI/SettingsDropdown.js | 2 +- packages/decap-cms-locales/src/en/index.js | 14 +++++++++++++ .../src/ObjectWidgetTopBar.js | 12 +++++++++-- .../src/DateTimeControl.js | 21 +++++++++++++++---- .../src/MarkdownControl/Toolbar.js | 12 +++++++---- 10 files changed, 58 insertions(+), 18 deletions(-) diff --git a/packages/decap-cms-core/src/components/Collection/CollectionControls.js b/packages/decap-cms-core/src/components/Collection/CollectionControls.js index afd9758ae1ea..5b15508d609c 100644 --- a/packages/decap-cms-core/src/components/Collection/CollectionControls.js +++ b/packages/decap-cms-core/src/components/Collection/CollectionControls.js @@ -36,7 +36,7 @@ function CollectionControls({ }) { return ( - + {viewGroups.length > 0 && ( )} diff --git a/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js b/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js index 6cf337404c6c..f8218887d787 100644 --- a/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js +++ b/packages/decap-cms-core/src/components/Collection/ViewStyleControl.js @@ -28,18 +28,18 @@ const ViewControlsButton = styled.button` } `; -function ViewStyleControl({ viewStyle, onChangeViewStyle }) { +function ViewStyleControl({ viewStyle, onChangeViewStyle, t }) { return ( onChangeViewStyle(VIEW_STYLE_LIST)} > onChangeViewStyle(VIEW_STYLE_GRID)} > diff --git a/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js b/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js index 042ce340c64c..14290381ee80 100644 --- a/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js +++ b/packages/decap-cms-core/src/components/Editor/EditorControlPane/EditorControl.js @@ -245,7 +245,7 @@ class EditorControl extends React.Component { {({ css, cx }) => ( props.isPrivate && colors.textFieldBorder}; `; -function MediaLibraryHeader({ onClose, title, isPrivate }) { +function MediaLibraryHeader({ onClose, title, isPrivate, t }) { return (
- + {title} diff --git a/packages/decap-cms-core/src/components/MediaLibrary/MediaLibraryTop.js b/packages/decap-cms-core/src/components/MediaLibrary/MediaLibraryTop.js index 00b3ed06ac05..524b779a4008 100644 --- a/packages/decap-cms-core/src/components/MediaLibrary/MediaLibraryTop.js +++ b/packages/decap-cms-core/src/components/MediaLibrary/MediaLibraryTop.js @@ -70,6 +70,7 @@ function MediaLibraryTop({ : t('mediaLibrary.mediaLibraryModal.mediaAssets') }`} isPrivate={privateUpload} + t={t} /> ( - + )} diff --git a/packages/decap-cms-locales/src/en/index.js b/packages/decap-cms-locales/src/en/index.js index b41cd36de2fd..2e6c7b26b01f 100644 --- a/packages/decap-cms-locales/src/en/index.js +++ b/packages/decap-cms-locales/src/en/index.js @@ -43,6 +43,8 @@ const en = { collectionTop: { sortBy: 'Sort by', viewAs: 'View as', + viewAsList: 'List view option', + viewAsGrid: 'Grid view option', newButton: 'New %{collectionLabel}', ascending: 'Ascending', descending: 'Descending', @@ -74,6 +76,7 @@ const en = { editorControl: { field: { optional: 'optional', + widgetLabel: '%{widgetLabel} field', }, }, editorControlPane: { @@ -168,6 +171,10 @@ const en = { addComponent: 'Add Component', richText: 'Rich Text', markdown: 'Markdown', + toggleMode: { + rich: 'Toggle to rich text mode', + markdown: 'Toggle to markdown mode', + }, }, image: { choose: 'Choose an image', @@ -208,11 +215,16 @@ const en = { datetime: { now: 'Now', clear: 'Clear', + setToNow: 'Set %{fieldLabel} to now', }, list: { add: 'Add %{item}', addType: 'Add %{item}', }, + object: { + expand: 'Expand', + collapse: 'Collapse', + }, }, }, mediaLibrary: { @@ -230,6 +242,7 @@ const en = { }, mediaLibraryModal: { loading: 'Loading...', + close: 'Close', noResults: 'No results.', noAssetsFound: 'No assets found.', noImagesFound: 'No images found.', @@ -264,6 +277,7 @@ const en = { }, settingsDropdown: { logOut: 'Log Out', + account: 'Account options dropdown', }, toast: { onFailToLoadEntries: 'Failed to load entry: %{details}', diff --git a/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js b/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js index c67b95d02f65..062f42f39671 100644 --- a/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js +++ b/packages/decap-cms-ui-default/src/ObjectWidgetTopBar.js @@ -113,12 +113,20 @@ class ObjectWidgetTopBar extends React.Component { } render() { - const { onCollapseToggle, collapsed, heading = null } = this.props; + const { onCollapseToggle, collapsed, heading = null, t } = this.props; return ( - + {heading} diff --git a/packages/decap-cms-widget-datetime/src/DateTimeControl.js b/packages/decap-cms-widget-datetime/src/DateTimeControl.js index 8e8e9264a24e..c6057a3be8ae 100644 --- a/packages/decap-cms-widget-datetime/src/DateTimeControl.js +++ b/packages/decap-cms-widget-datetime/src/DateTimeControl.js @@ -22,7 +22,7 @@ function Buttons({ t, fieldName, handleChange, getNow }) { `} >
); diff --git a/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js b/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js index 251611a67537..a2e6fb6f2c17 100644 --- a/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js +++ b/packages/decap-cms-widget-markdown/src/MarkdownControl/Toolbar.js @@ -281,11 +281,15 @@ export default class Toolbar extends React.Component { {t('editor.editorWidgets.markdown.richText')} - + aria-label={ + rawMode + ? t('editor.editorWidgets.markdown.toggleMode.rich') + : t('editor.editorWidgets.markdown.toggleMode.markdown') + } + /> {t('editor.editorWidgets.markdown.markdown')} From 36766dc29ef39fb480d0ee6ebca7a6ac42dae5a3 Mon Sep 17 00:00:00 2001 From: Yan <61414485+yanthomasdev@users.noreply.github.com> Date: Tue, 10 Feb 2026 10:26:41 -0300 Subject: [PATCH 3/3] fix: failing tests --- .../src/__tests__/__snapshots__/ListControl.spec.js.snap | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/packages/decap-cms-widget-list/src/__tests__/__snapshots__/ListControl.spec.js.snap b/packages/decap-cms-widget-list/src/__tests__/__snapshots__/ListControl.spec.js.snap index fe50682ab40d..737b5a8a4821 100644 --- a/packages/decap-cms-widget-list/src/__tests__/__snapshots__/ListControl.spec.js.snap +++ b/packages/decap-cms-widget-list/src/__tests__/__snapshots__/ListControl.spec.js.snap @@ -162,6 +162,7 @@ exports[`ListControl should add to list when add button is clicked 1`] = ` class="emotion-3 emotion-4" >