feat(ci): add unit tests

Author: kevinlin09

tests/legacy/test_websocket_async_api.py

@@ -7,7 +7,7 @@
 from dashscope.protocol.websocket import WebsocketStreamingMode
 from tests.unit.base_test import BaseTestEnvironment
 from tests.unit.constants import TestTasks
-from tests.legacy.websocket_task_request import WebSocketRequest
+from tests.unit.websocket_task_request import WebSocketRequest
 
 # set mock server url.
 base_websocket_api_url = "ws://localhost:8080/ws/aigc/v1"

tests/legacy/test_websocket_parameters.py

@@ -9,7 +9,7 @@
     TEST_ENABLE_DATA_INSPECTION_REQUEST_ID,
     TestTasks,
 )
-from tests.legacy.websocket_task_request import WebSocketRequest
+from tests.unit.websocket_task_request import WebSocketRequest
 
 
 def pytest_generate_tests(metafunc):

tests/legacy/test_websocket_sync_api.py

@@ -5,7 +5,7 @@
 from dashscope.protocol.websocket import WebsocketStreamingMode
 from tests.unit.base_test import BaseTestEnvironment
 from tests.unit.constants import TestTasks
-from tests.legacy.websocket_task_request import WebSocketRequest
+from tests.unit.websocket_task_request import WebSocketRequest
 
 
 def pytest_generate_tests(metafunc):

tests/unit/mock_server.py

@@ -33,7 +33,7 @@
     list_fine_tune_handler,
 )
 from tests.unit.mock_sse import sse_response
-from tests.legacy.websocket_mock_server_task_handler import (
+from tests.unit.websocket_mock_server_task_handler import (
     WebSocketTaskProcessor,
 )
 

tests/legacy/test_http_deployments_api.py tests/unit/test_http_deployments_api.pytests/legacy/test_http_deployments_api.py renamed to tests/unit/test_http_deployments_api.py

@@ -9,6 +9,7 @@
 
 
 class TestDeploymentRequest(MockRequestBase):
+    # pylint: disable=unused-argument
     def test_create_deployment_tune_job(self, http_server):
         resp = Deployments.call(
             model="gpt",

tests/legacy/test_http_files_api.py tests/unit/test_http_files_api.pytests/legacy/test_http_files_api.py renamed to tests/unit/test_http_files_api.py

@@ -8,6 +8,7 @@
 
 
 class TestFileRequest(MockRequestBase):
+    # pylint: disable=unused-argument
     def test_upload_files(self, http_server):
         resp = Files.upload(
             file_path="tests/data/dogs.jpg",

tests/legacy/test_http_fine_tunes_api.py tests/unit/test_http_fine_tunes_api.pytests/legacy/test_http_fine_tunes_api.py renamed to tests/unit/test_http_fine_tunes_api.py

@@ -18,13 +18,16 @@ class TestFineTuneRequest(MockServerBase):
 
     @classmethod
     def setup_class(cls):
+        # pylint: disable=consider-using-with
         cls.case_data = json.load(
             open('tests/data/fine_tune.json', 'r', encoding='utf-8'),
         )
         super().setup_class()
 
     def test_create_fine_tune_job(self, mock_server: MockServer):
-        response_body = self.case_data['create_response']
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_body = self.case_data['create_response']  # type: ignore
         mock_server.responses.put(json.dumps(response_body))
         model = 'gpt'
         training_file_ids = 'training_001'
@@ -47,10 +50,19 @@ def test_create_fine_tune_job(self, mock_server: MockServer):
         assert req['body']['hyper_parameters'] == hyper_parameters
         assert resp.output.job_id == response_body['output']['job_id']
         assert resp.output.status == response_body['output']['status']
-        assert resp.output.hyper_parameters == {'learning_rate': '2e-5', 'n_epochs': 10, 'batch_size': 32}
+        expected_hyper_params = {
+            'learning_rate': '2e-5',
+            'n_epochs': 10,
+            'batch_size': 32,
+        }
+        assert resp.output.hyper_parameters == expected_hyper_params
 
     def test_create_fine_tune_job_with_files(self, mock_server: MockServer):
-        response_body = self.case_data['create_multi_files_response']
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_body = self.case_data[  # type: ignore
+            'create_multi_files_response'
+        ]
         mock_server.responses.put(json.dumps(response_body))
         model = 'gpt'
         training_file_ids = ['training_001', 'training_002']
@@ -75,10 +87,13 @@ def test_create_fine_tune_job_with_files(self, mock_server: MockServer):
         assert resp.output.status == response_body['output']['status']
         assert resp.output.training_file_ids == training_file_ids
         assert resp.output.validation_file_ids == validation_file_ids
-        assert resp.output.hyper_parameters == response_body['output']['hyper_parameters']
+        expected_hyper_params = response_body['output']['hyper_parameters']
+        assert resp.output.hyper_parameters == expected_hyper_params
 
     def test_list_fine_tune_job(self, mock_server: MockServer):
-        response_body = self.case_data['list_response']
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_body = self.case_data['list_response']  # type: ignore
         mock_server.responses.put(json.dumps(response_body))
         response = FineTunes.list(
             page_no=10,
@@ -90,7 +105,9 @@ def test_list_fine_tune_job(self, mock_server: MockServer):
         assert response.output.jobs[0].job_id == 'ft-202403261454-d8b4'
 
     def test_get_fine_tune_job(self, mock_server: MockServer):
-        response_body = self.case_data['query_response']
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_body = self.case_data['query_response']  # type: ignore
         mock_server.responses.put(json.dumps(response_body))
         job_id = str(uuid.uuid4())
         response = FineTunes.get(job_id=job_id)
@@ -100,7 +117,11 @@ def test_get_fine_tune_job(self, mock_server: MockServer):
 
     def test_delete_fine_tune_job(self, mock_server: MockServer):
         request_id = str(uuid.uuid4())
-        response_body = '{"output": {"status": "success"}, "request_id": "%s", "code": null, "message": "", "usage": null}' % request_id  # noqa E501
+        response_body = (
+            '{"output": {"status": "success"}, '
+            f'"request_id": "{request_id}", '
+            '"code": null, "message": "", "usage": null}'
+        )
         mock_server.responses.put(response_body)
         rsp = FineTunes.delete(TEST_JOB_ID)
         req = mock_server.requests.get(block=True)
@@ -110,14 +131,19 @@ def test_delete_fine_tune_job(self, mock_server: MockServer):
 
     def test_cancel_fine_tune_job(self, mock_server: MockServer):
         request_id = str(uuid.uuid4())
-        response_body = '{"output": {"status": "success"}, "request_id": "%s", "code": null, "message": "", "usage": null}' % request_id  # noqa E501
+        response_body = (
+            '{"output": {"status": "success"}, '
+            f'"request_id": "{request_id}", '
+            '"code": null, "message": "", "usage": null}'
+        )
         mock_server.responses.put(response_body)
         rsp = FineTunes.cancel(TEST_JOB_ID)
         req = mock_server.requests.get(block=True)
         assert req['path'] == f'/api/v1/fine-tunes/{TEST_JOB_ID}/cancel'
         assert rsp.status_code == HTTPStatus.OK
         assert rsp.request_id == request_id
 
+    # pylint: disable=unused-argument
     def test_stream_event(self, mock_server: MockServer):
         responses = FineTunes.stream_events(TEST_JOB_ID)
         idx = 0

tests/legacy/test_http_models_api.py tests/unit/test_http_models_api.pytests/legacy/test_http_models_api.py renamed to tests/unit/test_http_models_api.py

@@ -9,6 +9,7 @@
 
 
 class TestModelRequest(MockRequestBase):
+    # pylint: disable=unused-argument
     def test_list_models(self, http_server):
         rsp = Models.list()
         assert rsp.status_code == HTTPStatus.OK

tests/legacy/test_messages.py tests/unit/test_messages.pytests/legacy/test_messages.py renamed to tests/unit/test_messages.py

@@ -17,14 +17,20 @@ class TestMessages(MockServerBase):
 
     @classmethod
     def setup_class(cls):
+        # pylint: disable=consider-using-with
         cls.case_data = json.load(
             open("tests/data/messages.json", "r", encoding="utf-8"),
         )
         super().setup_class()
 
     def test_create(self, mock_server: MockServer):
-        request_body = self.case_data["create_message_request"]
-        response_body = self.case_data["create_message_response"]
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        request_body = self.case_data["create_message_request"]  # type: ignore
+        # pylint: disable=unsubscriptable-object
+        response_body = self.case_data[  # type: ignore
+            "create_message_response"
+        ]
         mock_server.responses.put(json.dumps(response_body))
         response = Messages.create(**request_body)
         req = mock_server.requests.get(block=True)
@@ -34,7 +40,11 @@ def test_create(self, mock_server: MockServer):
         assert len(response.content) == 1
 
     def test_update(self, mock_server: MockServer):
-        response_body = self.case_data["create_message_response"]
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_body = self.case_data[  # type: ignore
+            "create_message_response"
+        ]
         mock_server.responses.put(json.dumps(response_body))
         thread_id = str(uuid.uuid4())
         message_id = str(uuid.uuid4())
@@ -55,7 +65,11 @@ def test_update(self, mock_server: MockServer):
         assert len(response.content) == 1
 
     def test_retrieve(self, mock_server: MockServer):
-        response_obj = self.case_data["create_message_response"]
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_obj = self.case_data[  # type: ignore
+            "create_message_response"
+        ]
         response_str = json.dumps(response_obj)
         mock_server.responses.put(response_str)
         thread_id = "tid"
@@ -68,7 +82,9 @@ def test_retrieve(self, mock_server: MockServer):
         assert len(response.content) == 1
 
     def test_list(self, mock_server: MockServer):
-        response_obj = self.case_data["list_message_response"]
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_obj = self.case_data["list_message_response"]  # type: ignore
         mock_server.responses.put(json.dumps(response_obj))
         thread_id = "test_thread_id"
         response = Messages.list(
@@ -80,16 +96,21 @@ def test_list(self, mock_server: MockServer):
         )
         # get assistant id we send.
         req = mock_server.requests.get(block=True)
-        assert (
-            req
-            == f"/api/v1/threads/{thread_id}/messages?limit=10&order=inc&after=after&before=before"
+        expected_path = (
+            f"/api/v1/threads/{thread_id}/messages?"
+            "limit=10&order=inc&after=after&before=before"
         )
+        assert req == expected_path
         assert len(response.data) == 2
         assert response.data[0].id == "msg_1"
         assert response.data[1].id == "msg_0"
 
     def test_list_message_files(self, mock_server: MockServer):
-        response_obj = self.case_data["list_message_files_response"]
+        # type: ignore[index]
+        # pylint: disable=unsubscriptable-object
+        response_obj = self.case_data[  # type: ignore
+            "list_message_files_response"
+        ]
         mock_server.responses.put(json.dumps(response_obj))
         thread_id = "test_thread_id"
         message_id = "test_message_id"
@@ -103,10 +124,11 @@ def test_list_message_files(self, mock_server: MockServer):
         )
         # get assistant id we send.
         req = mock_server.requests.get(block=True)
-        assert (
-            req
-            == f"/api/v1/threads/{thread_id}/messages/{message_id}/files?limit=10&order=inc&after=after&before=before"
-        )  # noqa E501
+        expected_path = (
+            f"/api/v1/threads/{thread_id}/messages/{message_id}/files?"
+            "limit=10&order=inc&after=after&before=before"
+        )
+        assert req == expected_path
         assert len(response.data) == 2
         assert response.data[0].id == "file-1"
         assert response.data[1].id == "file-2"
@@ -133,9 +155,10 @@ def test_retrieve_message_file(self, mock_server: MockServer):
         )
         # get assistant id we send.
         req = mock_server.requests.get(block=True)
-        assert (
-            req
-            == f"/api/v1/threads/{thread_id}/messages/{message_id}/files/{file_id}"
+        expected_path = (
+            f"/api/v1/threads/{thread_id}/messages/{message_id}/"
+            f"files/{file_id}"
         )
+        assert req == expected_path
         assert response.id == file_id
         assert response.message_id == message_id

tests/legacy/test_multimodal_dialog.py tests/unit/test_multimodal_dialog.pytests/legacy/test_multimodal_dialog.py renamed to tests/unit/test_multimodal_dialog.py

@@ -1,10 +1,10 @@
 # -*- coding: utf-8 -*-
 # Copyright (c) Alibaba, Inc. and its affiliates.
-import sys
-import pytest
 import logging
+import sys
 import time
-from dashscope.common.logging import logger
+
+import pytest
 from dashscope.multimodal.dialog_state import DialogState
 from dashscope.multimodal.multimodal_dialog import (
     MultiModalDialog,
@@ -21,9 +21,13 @@
 
 logger = logging.getLogger("dashscope")
 logger.setLevel(logging.DEBUG)
-# create console handler and set level to debug
 console_handler = logging.StreamHandler()
 
+# Global variable for dialog ID
+g_dialog_id = None
+# Global variable for conversation instance
+conver_instance = None
+
 
 # 定义voice chat服务回调
 class TestCallback(MultiModalCallback):
@@ -36,20 +40,22 @@ def on_started(self, dialog_id):
 
     def on_stopped(self):
         logger.info("stopped with server.")
-        pass
 
     def on_state_changed(self, state: DialogState):
         if state == DialogState.LISTENING:
             # app.update_text("开始收音。。。请提问")
-            pass
-        elif state == DialogState.THINKING:
-            pass
+            return
+        if state == DialogState.THINKING:
             # app.update_text("思考中。。。请耐心等待")
-        elif state == DialogState.RESPONDING:
-            pass
+            return
+        if state == DialogState.RESPONDING:
             # app.update_text("正在回答。。。")
+            return
 
-    def on_speech_audio_data(self, data: bytes):
+    def on_speech_audio_data(
+        self,
+        data: bytes,
+    ):  # pylint: disable=unused-argument
         # pcm_play.play(data)
         return
 
@@ -60,22 +66,22 @@ def on_error(self, error):
     def on_responding_started(self):
         # 开始端侧播放
         # pcm_play.start_play()
-        global conver_instance
-        conver_instance.send_local_responding_started()
-        return
+        global conver_instance  # pylint: disable=global-variable-not-assigned
+        if conver_instance is not None:
+            conver_instance.send_local_responding_started()
 
-    def on_responding_ended(self, payload):
+    def on_responding_ended(self, payload):  # pylint: disable=unused-argument
         logger.debug("on responding ended")
-        conver_instance.send_local_responding_ended()
+        global conver_instance  # pylint: disable=global-variable-not-assigned
+        if conver_instance is not None:
+            conver_instance.send_local_responding_ended()
         # pcm_play.stop_play()
 
     def on_speech_content(self, payload):
-        pass
         if payload is not None:
             logger.debug(payload)
 
     def on_responding_content(self, payload):
-        pass
         if payload is not None:
             logger.debug(payload)
 
@@ -86,8 +92,9 @@ def on_request_accepted(self):
 
     def on_close(self, close_status_code, close_msg):
         logger.info(
-            "close with status code: %d, msg: %s"
-            % (close_status_code, close_msg),
+            "close with status code: %d, msg: %s",
+            close_status_code,
+            close_msg,
         )