From bd7f5f6006db213abd8adbba0db4f505dfcaccbb Mon Sep 17 00:00:00 2001 From: Maryanne Wachter Date: Sat, 26 Oct 2024 20:07:17 -0700 Subject: [PATCH 1/2] feat: remove broken assertions, add color test --- tests/test_e57.py | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/tests/test_e57.py b/tests/test_e57.py index f5598de..8b56285 100644 --- a/tests/test_e57.py +++ b/tests/test_e57.py @@ -34,8 +34,6 @@ def test_read_intensity(): intensity = pointcloud.intensity assert isinstance(intensity, np.ndarray) assert len(intensity) == 1_220 - assert np.all(intensity >= 0.3935) - assert np.all(intensity <= 0.5555) def test_no_rgb_intensity(): @@ -45,6 +43,26 @@ def test_no_rgb_intensity(): assert len(intensity) == 0 +def test_read_color_values(): + pointcloud = e57.read_points(r"testdata/pipeSpherical.e57") + color = pointcloud.color + + first_point_color = color[0] + assert first_point_color[0] == pytest.approx(0.27450982) + assert first_point_color[1] == pytest.approx(0.30980393) + assert first_point_color[2] == pytest.approx(0.19607843) + + mid_point_color = color[len(color) // 2] + assert mid_point_color[0] == pytest.approx(0.18823529) + assert mid_point_color[1] == pytest.approx(0.21568628) + assert mid_point_color[2] == pytest.approx(0.15294118) + + last_point_color = color[-1] + assert last_point_color[0] == pytest.approx(0.11764706) + assert last_point_color[1] == pytest.approx(0.14117658) + assert last_point_color[2] == pytest.approx(0.08627451) + + def test_box_dimensions(): pointcloud: np.ndarray = e57.read_points(r"testdata/bunnyFloat.e57") points = pointcloud.points From fa928b7592e4ef6e7808d23c51cb3e40ab69dfb5 Mon Sep 17 00:00:00 2001 From: Maryanne Wachter Date: Sat, 26 Oct 2024 21:49:31 -0700 Subject: [PATCH 2/2] fix: past test revision --- tests/test_e57.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_e57.py b/tests/test_e57.py index 8b56285..507e7fe 100644 --- a/tests/test_e57.py +++ b/tests/test_e57.py @@ -34,6 +34,8 @@ def test_read_intensity(): intensity = pointcloud.intensity assert isinstance(intensity, np.ndarray) assert len(intensity) == 1_220 + assert np.all(intensity >= 0.3935) + assert np.all(intensity <= 0.5555) def test_no_rgb_intensity():