From 8cb2f76a441beb63b7079ec117ab4e54f2b925a7 Mon Sep 17 00:00:00 2001 From: David Norman Date: Fri, 21 Feb 2020 23:28:28 -0800 Subject: [PATCH 1/2] return MPRemoteCommandHandlerStatus from target action selectors --- Recast/PlayerViewController.swift | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/Recast/PlayerViewController.swift b/Recast/PlayerViewController.swift index 5919658b..376a2a81 100644 --- a/Recast/PlayerViewController.swift +++ b/Recast/PlayerViewController.swift @@ -213,7 +213,7 @@ class PlayerViewController: ViewController { // MARK: - Player Controls - @objc func playPauseButtonWasPressed(_ sender: UIButton) { + @objc func playPauseButtonWasPressed(_ sender: UIButton) -> MPRemoteCommandHandlerStatus { if player.rate == 0.0 { if currentTime == duration { currentTime = 0.0 @@ -222,6 +222,7 @@ class PlayerViewController: ViewController { } else { player.pause() } + return .success } private func skip(seconds: Double) { @@ -233,12 +234,14 @@ class PlayerViewController: ViewController { }) } - @objc func skipBackButtonWasPressed(_ sender: UIButton) { + @objc func skipBackButtonWasPressed(_ sender: UIButton) -> MPRemoteCommandHandlerStatus { skip(seconds: -30) + return .success } - @objc func skipForwardButtonWasPressed(_ sender: UIButton) { + @objc func skipForwardButtonWasPressed(_ sender: UIButton) -> MPRemoteCommandHandlerStatus { skip(seconds: 30) + return .success } @objc func timeSliderDidChange(_ sender: UISlider) { @@ -333,8 +336,8 @@ class PlayerViewController: ViewController { func configureCommands() { UIApplication.shared.beginReceivingRemoteControlEvents() let commandCenter = MPRemoteCommandCenter.shared() - commandCenter.pauseCommand.addTarget(self, action: #selector(playPauseButtonWasPressed(_:))) commandCenter.playCommand.addTarget(self, action: #selector(playPauseButtonWasPressed(_:))) + commandCenter.pauseCommand.addTarget(self, action: #selector(playPauseButtonWasPressed(_:))) commandCenter.skipForwardCommand.addTarget(self, action: #selector(skipForwardButtonWasPressed(_:))) commandCenter.skipBackwardCommand.addTarget(self, action: #selector(skipBackButtonWasPressed(_:))) commandCenter.skipForwardCommand.preferredIntervals = [30] From 6401f7eef3ca68ce2fb51b3802133e1b17ae06da Mon Sep 17 00:00:00 2001 From: David Norman Date: Fri, 21 Feb 2020 23:32:42 -0800 Subject: [PATCH 2/2] undo unrelated change --- Recast/PlayerViewController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Recast/PlayerViewController.swift b/Recast/PlayerViewController.swift index 376a2a81..70d7592b 100644 --- a/Recast/PlayerViewController.swift +++ b/Recast/PlayerViewController.swift @@ -336,8 +336,8 @@ class PlayerViewController: ViewController { func configureCommands() { UIApplication.shared.beginReceivingRemoteControlEvents() let commandCenter = MPRemoteCommandCenter.shared() - commandCenter.playCommand.addTarget(self, action: #selector(playPauseButtonWasPressed(_:))) commandCenter.pauseCommand.addTarget(self, action: #selector(playPauseButtonWasPressed(_:))) + commandCenter.playCommand.addTarget(self, action: #selector(playPauseButtonWasPressed(_:))) commandCenter.skipForwardCommand.addTarget(self, action: #selector(skipForwardButtonWasPressed(_:))) commandCenter.skipBackwardCommand.addTarget(self, action: #selector(skipBackButtonWasPressed(_:))) commandCenter.skipForwardCommand.preferredIntervals = [30]