End to end tests are skipped

[pinage404]

Hello,

I was trying to contribute

I would like to add a test

But some end to end tests are skipped

cookcli/tests/e2e/preferences.spec.ts

Line 4 in eb05342

test.describe.skip('Preferences', () => { // Skip - page not implemented yet

cookcli/tests/e2e/recipe-display.spec.ts

Line 4 in eb05342

test.describe.skip('Recipe Display', () => { // Skip - requires recipe content

cookcli/tests/e2e/recipe-scaling.spec.ts

Line 4 in eb05342

test.describe.skip('Recipe Scaling', () => { // Skip - requires recipe with scaling

Why are they skipped ?

[dubadub]

Some technical debt, they need to be updated or deleted

[pinage404]

The first commit of these files added them as skipped

6260356#diff-788a9794f34dbcf949b279b48c0931b6b82d8bbf031fec59a6dc61d01b3443d1R4

I tried to unskip some of them for about 1 hour

But they are wrong :

• Like calling a method on the wrong object

  cookcli/tests/e2e/recipe-display.spec.ts

  Line 16 in bd4c4fb

  const firstRecipe = await helpers.getRecipeCards().first();

   -    const firstRecipe = await helpers.getRecipeCards().first();
   +    const firstRecipe = (await helpers.getRecipeCards()).first();

• Like going to the wrong URL for the current test

  cookcli/tests/e2e/recipe-display.spec.ts

  Line 11 in bd4c4fb

  await helpers.navigateTo('/');

• Like the test pass even when the thing is absent on a test that should verify that they is present

  cookcli/tests/e2e/recipe-display.spec.ts

  Line 193 in bd4c4fb

  if (await recipeImage.count() > 0) {

  cookcli/tests/e2e/recipe-display.spec.ts

  Line 200 in bd4c4fb

  expect(true).toBe(true);

It looks like AI slop

IMHO, they give false confidence : there are tests, the test pass (some are skipped), so i expect my change didn't break thing

Only tests descriptions seem good

[dubadub]

Yeah, all the tests generated with AI, feel free to delete these.

[dubadub]

fixed mosted of the tests which were skiped