From 7b716a0ed448e4c775b112027ff60a3689f11502 Mon Sep 17 00:00:00 2001 From: Sean Mann Date: Fri, 20 Dec 2024 19:01:42 -0800 Subject: [PATCH 1/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index dae1a26..e4b4ab8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -110,3 +110,16 @@ In general, reviewers are acting in the role of maintainers in the open-source m 1. Share non-blocking improvement feedback 1. Things like typos, spelling errors, capitalization, rephrasing (Depending on repo-specific styles some of these might be required) 1. Ask questions for reviewer's own understanding & learning + +#### The reviewer checklist + +A reviewer's job is to ensure that the answer to all these questions is 'yes'. Only then should a PR be approved. + +- [ ] Does this PR have an issue associated with it? +- [ ] Was the issue triaged? +- [ ] Does the PR have a problem statement that is clear and for an existing agreed upon quality bar? (subjective: typos, color strings, etc) +- [ ] Does the PR fix only the issue or problem statement described in the simplest way? (subjective) +- [ ] Does the PR have sufficient test coverage? (subjective: does it need tests? do they exist? are they in the pr?) +- [ ] Have manual testing requirements been done? (e.g. hackmudclient needs manual testing on windows) +- [ ] Does any documentation need to be updated or created? +- [ ] Is a migration required for this change? (e.g. marks schema migration, account or user schema migration) From 8c294093408e8e4d19ab90653ead8c7fee47589e Mon Sep 17 00:00:00 2001 From: Sean Mann Date: Sat, 21 Dec 2024 16:05:49 -0800 Subject: [PATCH 2/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e4b4ab8..b410c25 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -123,3 +123,4 @@ A reviewer's job is to ensure that the answer to all these questions is 'yes'. O - [ ] Have manual testing requirements been done? (e.g. hackmudclient needs manual testing on windows) - [ ] Does any documentation need to be updated or created? - [ ] Is a migration required for this change? (e.g. marks schema migration, account or user schema migration) +- [ ] Was all debugging output code removed from the change? From 8c87454b948047b75f2744a22f1e77f6a2e27bca Mon Sep 17 00:00:00 2001 From: kbinreallife <141305609+kbinreallife@users.noreply.github.com> Date: Tue, 31 Dec 2024 15:39:57 -0800 Subject: [PATCH 3/3] Update CONTRIBUTING.md Co-authored-by: Fayti1703 --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b410c25..7afb8ae 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -115,9 +115,9 @@ In general, reviewers are acting in the role of maintainers in the open-source m A reviewer's job is to ensure that the answer to all these questions is 'yes'. Only then should a PR be approved. -- [ ] Does this PR have an issue associated with it? -- [ ] Was the issue triaged? - [ ] Does the PR have a problem statement that is clear and for an existing agreed upon quality bar? (subjective: typos, color strings, etc) + - [ ] Does this PR have an issue associated with it? + - [ ] Was the issue triaged? - [ ] Does the PR fix only the issue or problem statement described in the simplest way? (subjective) - [ ] Does the PR have sufficient test coverage? (subjective: does it need tests? do they exist? are they in the pr?) - [ ] Have manual testing requirements been done? (e.g. hackmudclient needs manual testing on windows)