[Feature Request] Update Legacy Branch to Not Read/Write to SCA.ADC_Monitoring Block

[bdorney]

Brief summary of issue

The SCA.ADC_MONITORING block was removed from GEM_AMC in v3.8.4.

However not all test stands have migrated to this version yet due to issues with OH FW. We need to have some protection regarding writing/reading from these nodes

Types of issue

• Bug report (report an issue with the code)
• Feature request (request for change which adds functionality)

Expected Behavior

In locations below we could either:

1. Do a read of the AMC FW and if below 3.8.4 then the read/write this block as normal; if above 3.8.4 do nothing, or
2. Put all read/writes to this block in a try...except block and try to catch either uhal._core.exception.

If a node name is not found in the xhal/reg_utils equivalent command no exception is raised so no handling is "needed." Given this branch is legacy anyway I doubt something further is needed.

Current Behavior

The SCA.ADC_MONITORING block is presently used in two places:

% grep -R "SCA.ADC_MONITORING" *.py
monitorTemperatures.py:    origSCAMonOffVal = amcBoard.readRegister("GEM_AMC.SLOW_CONTROL.SCA.ADC_MONITORING.MONITORING_OFF")
testConnectivity.py:    writeRegister(amc,"GEM_AMC.SLOW_CONTROL.SCA.ADC_MONITORING.MONITORING_OFF",0xffffffff)

Context (for feature requests)

Need software to be able to use either FW regardless of release.

Your Environment

• Version used: dae6fb9
• Shell used:

[lpetre-ulb]

We need an updated version of testConnectivity.py for the QC tests at ULB for next Monday, so I will work the patch and test it.