From d612bb4bdb157ca121aef03cd0071a9ab943727c Mon Sep 17 00:00:00 2001 From: cheyang Date: Fri, 4 Apr 2025 13:51:04 +0800 Subject: [PATCH 1/2] Fix not checking result issue Signed-off-by: cheyang --- pkg/utils/crtl_utils_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/utils/crtl_utils_test.go b/pkg/utils/crtl_utils_test.go index 1e0a9c569b4..bc08f7df823 100644 --- a/pkg/utils/crtl_utils_test.go +++ b/pkg/utils/crtl_utils_test.go @@ -441,10 +441,10 @@ func TestGenerateRandomRequeueDurationFromEnv(t *testing.T) { for _, test := range tests { t.Run(test.name, func(t *testing.T) { if test.runtimeReconcileDuration != "" { - os.Setenv(RuntimeReconcileDurationEnv, test.runtimeReconcileDuration) + _ = os.Setenv(RuntimeReconcileDurationEnv, test.runtimeReconcileDuration) } if test.runtimeReconcileOffset != "" { - os.Setenv(RuntimeReconcileDurationOffsetEnv, test.runtimeReconcileOffset) + _ = os.Setenv(RuntimeReconcileDurationOffsetEnv, test.runtimeReconcileOffset) } defer func() { _ = os.Unsetenv(RuntimeReconcileDurationEnv) From c5cfde674385346dd9ac59c81f56dacf5d1443a5 Mon Sep 17 00:00:00 2001 From: cheyang Date: Fri, 4 Apr 2025 13:53:48 +0800 Subject: [PATCH 2/2] Use ReplaceAll to replace Replace Signed-off-by: cheyang --- hack/sdk/main.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hack/sdk/main.go b/hack/sdk/main.go index 6f70b0f9ecb..d7791d32997 100644 --- a/hack/sdk/main.go +++ b/hack/sdk/main.go @@ -66,14 +66,14 @@ func main() { } func swaggify(name string) string { - name = strings.Replace(name, "github.com/fluid-cloudnative/fluid/api/v1alpha1", "", -1) - name = strings.Replace(name, "github.com/kubernetes-sigs/kube-batch/pkg/client/clientset/", "", -1) - name = strings.Replace(name, "k8s.io/api/core/", "", -1) - name = strings.Replace(name, "k8s.io/apimachinery/pkg/apis/meta/", "", -1) - name = strings.Replace(name, "k8s.io/kubernetes/pkg/controller/", "", -1) - name = strings.Replace(name, "k8s.io/client-go/listers/core/", "", -1) - name = strings.Replace(name, "k8s.io/client-go/util/workqueue", "", -1) - name = strings.Replace(name, "k8s.io/apimachinery/pkg/api/resource", "", -1) - name = strings.Replace(name, "/", ".", -1) + name = strings.ReplaceAll(name, "github.com/fluid-cloudnative/fluid/api/v1alpha1", "") + name = strings.ReplaceAll(name, "github.com/kubernetes-sigs/kube-batch/pkg/client/clientset/", "") + name = strings.ReplaceAll(name, "k8s.io/api/core/", "") + name = strings.ReplaceAll(name, "k8s.io/apimachinery/pkg/apis/meta/", "") + name = strings.ReplaceAll(name, "k8s.io/kubernetes/pkg/controller/", "") + name = strings.ReplaceAll(name, "k8s.io/client-go/listers/core/", "") + name = strings.ReplaceAll(name, "k8s.io/client-go/util/workqueue", "") + name = strings.ReplaceAll(name, "k8s.io/apimachinery/pkg/api/resource", "") + name = strings.ReplaceAll(name, "/", ".") return name }