Skip to content

infinite loop when importing package with same name as entry file #6

@brumm

Description

@brumm

given a preview'd file 'downshift.js', having a import Downshift from 'downshift' statement will lock up atom.

We could either

  • require local imports to always specify the full filename, including extension to differentiate between local files and named packages or
  • prevent a module from importing itself or
  • cache modules based on path, to support circular dependencies
    we would find a module in the cache and return its contents and dependencies without having to re-read and re-parse dependencies

The last option seems like the most 'correct' approach.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions