Skip to content

Commit d3830fd

Browse files
authored
Merge pull request #80 from britive/develop
v1.4.0rc2
2 parents 37b5446 + d775d2a commit d3830fd

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

CHANGELOG.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,22 @@
33
* All changes to the package starting with v0.3.1 will be logged here.
44
* As of v1.4.0 release candidates will be published in an effort to get new features out faster while still allowing time for full QA testing before moving the release candidate to a full release.
55

6+
## v1.4.0rc2 [2023-05-09]
7+
#### What's New
8+
* None
9+
10+
#### Enhancements
11+
* None
12+
13+
#### Bug Fixes
14+
* `checkout` bug when no `--mode/-m` is provided.
15+
16+
#### Dependencies
17+
* None
18+
19+
#### Other
20+
* None
21+
622
## v1.4.0rc1 [2023-05-09]
723
#### What's New
824
* Command `request approve`

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[metadata]
22
name = pybritive
3-
version = 1.4.0rc1
3+
version = 1.4.0rc2
44
author = Britive Inc.
55
author_email = support@britive.com
66
description = A pure Python CLI for Britive

src/pybritive/britive_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ def checkout(self, alias, blocktime, console, justification, mode, maxpolltime,
458458

459459
# these 2 modes implicitly say that console access should be checked out without having to provide
460460
# the --console flag
461-
if mode == 'console' or mode.startswith('browser'):
461+
if mode and (mode == 'console' or mode.startswith('browser')):
462462
console = True
463463

464464
self._validate_justification(justification)

0 commit comments

Comments
 (0)